Change in ovirt-engine[master]: frontend: Send "Version" header to the API
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: frontend: Send "Version" header to the API
......................................................................
frontend: Send "Version" header to the API
In the near future the server will support multiple versions of the API,
in particular it will support versions 3 and 4. The users of the API
will be encouraged to explicitly indicate what version they want to use.
To do so, the will be asked to send the "Version" with every request.
The value of this header will be the requested version. Alternatively it
will also be possible to specify the requested version as a prefix in
the URL, like "/v3/vms" or "/v4/vms". When the version isn't explicitly
specified the server will select a default, which will be configurable
in the future (currently it is "4", and it is hard-coded). To avoid
surprises if the default version is changed this patch modifies the
frontend so that it will always explicitly request version 4 of the API,
using the "Version" header.
Change-Id: I18f93fd451639f773aa61ec44ff5e53e0ce5e146
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionManager.java
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18f93fd451639f773aa61ec44ff5e53e0ce5e146
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: Preserve parameters when forwarding
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Preserve parameters when forwarding
......................................................................
restapi: Preserve parameters when forwarding
The version filter forwards requests to specific versions of the API,
adding the "/v3" or "/v4" prefix to the URL as needed. But when it does
this it also loses the matrix and query parameters. For example, if the
original URI is this:
/hosts/{host:id};force=true
The forwarded URI is this, with the version prefix but without the
parameters:
/v4/hosts/{hosts:id}
This patch fixes that error.
Change-Id: I4706634c26c3ea60c73cef5f2d070344e488b349
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53645
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4706634c26c3ea60c73cef5f2d070344e488b349
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine-sdk-ruby[master]: Fix typo in error message
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix typo in error message
......................................................................
Fix typo in error message
This patch fixes a typo in the error message generated when writing an
XML start element fails.
Change-Id: Id6f216bcf3077d9e7c1a0612aa843b34eab6cee9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk/ov_xml_writer.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6f216bcf3077d9e7c1a0612aa843b34eab6cee9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine-sdk-ruby[master]: Fix check of libxml writer creation
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix check of libxml writer creation
......................................................................
Fix check of libxml writer creation
Currently when the libxml output buffer is created, the code doesn't
check correctly the result of the method. As a result if an error
happens it won't be detected. This patch fixes that issue.
Change-Id: I8be40c43382af87538837366733875587b6ef1bd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk/ov_xml_writer.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53693
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8be40c43382af87538837366733875587b6ef1bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: removed duplicates among two methods
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: removed duplicates among two methods
......................................................................
core: removed duplicates among two methods
whether result should be valid or invalid can be expressed in one
variable, thus method testing if all inputs are valid is duplicate
Change-Id: I68df94b9c0bc7ba7207f6a502ae1617c9e8eec0a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 41 insertions(+), 55 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68df94b9c0bc7ba7207f6a502ae1617c9e8eec0a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: separate tests differing with bond mode
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: separate tests differing with bond mode
......................................................................
core: separate tests differing with bond mode
I have some issues with this test in following patch(do not pass whole
Bond from UI, but only required data), and it would be harder to
fix that problem differently than it's done in this patch.
There are several tests, which tests same stuff for all bond options.
These tests saves some computational time by reinitializing only bond
instance between tests, but this is cause of my problems, since I'm
replacing datatype of parameters.newOrModifiedBonds, so I'd have to
update inside of loop not only bond, but also all bonds in given
collection. So I opted to completely separate test for each bond mode.
This way is of course less
performant(not significantly though), but does not assume correct
behavior of validator being tested. Before this modification, tested
subject had to 'cooperate' and neither do touch 'bond' passed in
parameters nor to store data from it in any its [validators] inner
structures. Doing so whould probably cripple test, and test
should probably not assume this is not happening if it's possible to
write it like that.
I also introduced ErrorCollector, which will report all failing
bondmodes and not just first one.
Change-Id: I654b60f8456a16f5925658a84f8b44d5c7a7b5e4
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 47 insertions(+), 35 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I654b60f8456a16f5925658a84f8b44d5c7a7b5e4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: duplicate fixes, simplifications, few inspections fixed.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: duplicate fixes, simplifications, few inspections fixed.
......................................................................
core: duplicate fixes, simplifications, few inspections fixed.
• fixed unnecessary type parameters
• removed unnecessary array creation when calling varargs method
• added missing space before {
• extracted duplicate bond creation and used method for that
• extracted duplicate string literals to variable
• Arrays.asList(oneItem) —> Collections.singletonList(oneItem).
Change-Id: I3421a533f24e7ad7685878b103776639f23f6732
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 62 insertions(+), 51 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3421a533f24e7ad7685878b103776639f23f6732
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: Enable fencing of previous host which HE VM was runnin...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Enable fencing of previous host which HE VM was running on
......................................................................
core: Enable fencing of previous host which HE VM was running on
If host (for example hostA), which hosted engine VM was running on,
crashes, then hosted engine VM is restarted on another host (hostB).
When engine starts up on hostB, hostA is detected as non responsive, but
it's not fenced automatically because fencing is disabled for 5 minutes
after engine startup (config value DisableFenceAtStartupInSec). This
causes issues:
1. HA VMs executed on hostA are not restarted on different host
2. If hostA was SPM, new SPM cannot be selected
This patch enables fencing of hostA even during
DisableFenceAtStartupInSec timeout to prevent above issues.
Change-Id: Iff4368d02d3cbb71dd3cff9c2fc62586fa560a14
Bug-Url: https://bugzilla.redhat.com/1266099
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/PreviousHostedEngineHost.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
A packaging/dbscripts/upgrade/03_06_2030-add-index-on-origin-in-vm-static.sql
M packaging/dbscripts/vms_sp.sql
9 files changed, 141 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53669
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff4368d02d3cbb71dd3cff9c2fc62586fa560a14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: disable uncaught exception popup.
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: disable uncaught exception popup.
......................................................................
userportal, webadmin: disable uncaught exception popup.
- Added the ability to disable the uncaught exception popup.
Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/DisplayUncaughtUIExceptions.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
10 files changed, 46 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad7f6888229e09ed9588e449e925ba14cfb4a387
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in otopi[master]: packaging: bump version to 1.5.0
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: bump version to 1.5.0
......................................................................
packaging: bump version to 1.5.0
Change-Id: Iaedfe06cfdf84ef7ee9f01c9d33ee7fdee242648
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedfe06cfdf84ef7ee9f01c9d33ee7fdee242648
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months