Change in ovirt-engine[master]: gluster: optionally stop gluster services
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: gluster: optionally stop gluster services
......................................................................
gluster: optionally stop gluster services
Introduce an option in the Host Maintenance
Pop-up to stop gluster services. If this option
is selected then all gluster services will be
stopped.
This patch will introduce a callback for host maintenance
and the callback will monitor the host status and it will
stop all gluster process when host is moved to maintenance.
Change-Id: I7f0455bdac3e8615755d80a552141c714ee65241
Bug-Url: https://bugzilla.redhat.com/1303539
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostMaintenanceCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
17 files changed, 222 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/53588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f0455bdac3e8615755d80a552141c714ee65241
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[master]: node: Use package version
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Use package version
......................................................................
node: Use package version
Package version also includes the real version, not just the branch name.
Change-Id: I16e586477f677033e0bacc969a726f337d2a07a7
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Fabian Deutsch: Verified; Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52883
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16e586477f677033e0bacc969a726f337d2a07a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: webadmin: fix brick count validation issue in add-brick
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix brick count validation issue in add-brick
......................................................................
webadmin: fix brick count validation issue in add-brick
There is a validation issue in the add bricks pop up. It
complains saying 'At least 1 brick should be present' thoguh
there is a 1 or more brick in a distribute volume.
Its a regression from https://gerrit.ovirt.org/#/c/46554.
Always it returns false for distribute volume.
Change-Id: If660c70b0bee67699f6c38cce5afa97f4ec8ccf7
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/53703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If660c70b0bee67699f6c38cce5afa97f4ec8ccf7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: backend: override default job property in ImportRepoImageCom...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: backend: override default job property in ImportRepoImageCommand
......................................................................
backend: override default job property in ImportRepoImageCommand
This patch overrides the "storage" job property in
ImportRepoImageCommand to be the target storage domain's name.
Change-Id: Ie48f14e2cf34b8fcae409c76b95cc6d4ae01fd96
Bug-Url: https://bugzilla.redhat.com/1308642
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/53674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie48f14e2cf34b8fcae409c76b95cc6d4ae01fd96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: simplify the creation of vm-analyzer's factory
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: simplify the creation of vm-analyzer's factory
......................................................................
core: simplify the creation of vm-analyzer's factory
The factory is created by VmsMonitoring on each monitoring cycle,
including cycles that were triggered by events. On large scale,
the frequency can be high. Therefore, this patch removes the
injections to VmAnalyzerFactory and instead the dependencies
that are injected only once to the VmsMonitoring are passed to
its constructor.
Change-Id: I9a55c055212cac958da0fdbf86ef77bac60c20a8
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
2 files changed, 63 insertions(+), 16 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a55c055212cac958da0fdbf86ef77bac60c20a8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in jenkins[master]: periodic decrease of 20 days for warning & abandoning
by amarchuk＠redhat.com
Anton Marchukov has submitted this change and it was merged.
Change subject: periodic decrease of 20 days for warning & abandoning
......................................................................
periodic decrease of 20 days for warning & abandoning
Change-Id: Ia57d657b0b29543ae7dff99dcd83d760c56909b3
Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com>
---
M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Eyal Edri: Ready for merge
Anton Marchukov: Verified; Ready for review
Jenkins CI: Passed CI tests
David Caro: Looks good to me
--
To view, visit https://gerrit.ovirt.org/53691
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia57d657b0b29543ae7dff99dcd83d760c56909b3
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: cache host's numa nodes
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cache host's numa nodes
......................................................................
core: cache host's numa nodes
Analyze of profiling dumps shows that a significant portion
of the CPU time is spent on getting the numa nodes on the host.
This can be improved by querying them only once in the host
polling instead of doing that per-VM.
We can cache it because it is not expected to change so it will
be queried once and not per-polling operation, but it would
maybe make sense to query that nodes along with the VM numa
nodes in one query per-polling operation.
So for now the optimization is just to reduce the frequency
of the query of the host's numa nodes to be once per-polling.
Change-Id: I5d72ab207f861ca8e050068d101c998343cffc60
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MemoizingSupplier.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
3 files changed, 55 insertions(+), 12 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/53169
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d72ab207f861ca8e050068d101c998343cffc60
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Fix migration policy update for running VM
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Fix migration policy update for running VM
......................................................................
webadmin: Fix migration policy update for running VM
Problem description:
--------------------
When a VM is running and its migration policy is pinned,
a change of the migration policy to migrateable allows the running VM
to migrate to another host.
This behavior is a security threat, passing information from the pinned
host to the migration target. And migration could fail due to
incompatible target host.
Desired behavior:
-----------------
When a VM is running and changing migration policy from pinned to
Migrateable (manual or automatic).
- Provide warning and UX indicator.
- If user confirms proceed with normal update.
Implementation:
--------------
1. Replace @EditableOnVmStatusField with @EditableField to
fields {dedicatedVmForVdsList, migrationSupport} (VmBase.java). Disable
(vm restart requirement), when updating dedicated hosts field or
updating migrationSupport field.
2. Redesign VmNextRunConfiguration UI to display warnning if running VM
is unpinned. Modify VmListModel.java to append warning into
VmNextRunConfigurationModel.java . Also Modify VmNextRunConfiguration
layout and widget to display selective information (coresponding to
updated fields).
Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Bug-Url: https://bugzilla.redhat.com/1058384
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java
9 files changed, 166 insertions(+), 44 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/53646
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: exttool: aaa: fix recursive loop print
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: exttool: aaa: fix recursive loop print
......................................................................
exttool: aaa: fix recursive loop print
Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4
Bug-Url: https://bugzilla.redhat.com/1301345
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 7c45c1cbcb71fc0f888c5fcb060d4336c8c101ad)
---
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java
1 file changed, 16 insertions(+), 8 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: separate tests differing with bond mode 2
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: separate tests differing with bond mode 2
......................................................................
core: separate tests differing with bond mode 2
same fix as in I654b60f8456a16f5925658a84f8b44d5c7a7b5e4
applied to another method.
Change-Id: I0a2bcf00068f4291ff898130c01037a7250ee9d0
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 28 insertions(+), 19 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a2bcf00068f4291ff898130c01037a7250ee9d0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months