February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: edit running VM is not possible
by tjelinek＠redhat.com 29 Feb '16

29 Feb '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: edit running VM is not possible ...................................................................... webadmin: edit running VM is not possible It was not possible to edit the running VM. The reason was that the VmNextRunConfigurationModel in constructor always inited the latch which by default had the 'available' flag set to true (even not shown since this flag was set sooner than the listener which would actually show it was registered). As a consequence, the validate() method returned false, since the latch was "available" and unchecked. But since it was not rendered, it was not obvious to the user what the problem is making the dialog impossible to submit. The fix was just to move the initialization of the latch to the proper place. Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Bug-Url: https://bugzilla.redhat.com/1312636 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Define c'tors at the beginning of a class
by masayag＠redhat.com 29 Feb '16

29 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Define c'tors at the beginning of a class ...................................................................... engine: Define c'tors at the beginning of a class Change-Id: Ie413cc10ad5eeda1be0fa5778e0ef2babe1f6afa Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 30 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie413cc10ad5eeda1be0fa5778e0ef2babe1f6afa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Move a constant to its rightful class
by masayag＠redhat.com 29 Feb '16

29 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move a constant to its rightful class ...................................................................... engine: Move a constant to its rightful class Change-Id: I72b68eebd4af6066510534da5bc5214a785021bd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72b68eebd4af6066510534da5bc5214a785021bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use java naming convention
by masayag＠redhat.com 29 Feb '16

29 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use java naming convention ...................................................................... engine: Use java naming convention Change-Id: I6d3ce5d1d12305cb0ebcf739ad62737245427436 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 26 insertions(+), 26 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d3ce5d1d12305cb0ebcf739ad62737245427436 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use java stream api and clear unused method
by masayag＠redhat.com 29 Feb '16

29 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use java stream api and clear unused method ...................................................................... engine: Use java stream api and clear unused method Change-Id: Ie3169ffeb7846d14b417a6598e3ded08bae59290 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 24 insertions(+), 40 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Liron Aravot: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3169ffeb7846d14b417a6598e3ded08bae59290 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: early return in batch operations with no elements
by mperina＠redhat.com 29 Feb '16

29 Feb '16

Martin Peřina has submitted this change and it was merged. Change subject: core: early return in batch operations with no elements ...................................................................... core: early return in batch operations with no elements Seems like currently on every batch operation (save/update/remove) we use a connection to the database. Not all the callers to these operations verify that there are actually elements in the collection of entities they pass. Therefore, we go deep into the stack and get a connection to the database in order to execute stored procedure that doesn't do anything. As a solution, this patch suggests to return early without doing anything in these operations when the passed collection of entities is empty. Change-Id: I31e10d048e9f6bf63bbc2ac51e330633c7dc3423 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDao.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/54032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31e10d048e9f6bf63bbc2ac51e330633c7dc3423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Network Import dialog open/cancel fails
by alkaplan＠redhat.com 29 Feb '16

29 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Import dialog open/cancel fails ...................................................................... webadmin: Network Import dialog open/cancel fails The Network Import dialog in the network list fails to close when cancel is pressed. It also opens only once, all further attempts to open it fail. The issue was caused by an incorrect model being injected into the model (the external provider one). The same dialog is also used in external providers network import. There it works fine, as the model is the right one. Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Bug-Url: https://bugzilla.redhat.com/1306585 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ImportNetworksPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 5 files changed, 375 insertions(+), 364 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove index from curly braces
by amureini＠redhat.com 28 Feb '16

28 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove index from curly braces ...................................................................... core: Remove index from curly braces This patch removes the index in curley braces. Change-Id: Ic4409c84faa0c10ec60f0716063c2abc62f23e84 Related-To: https://bugzilla.redhat.com/1309294 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4409c84faa0c10ec60f0716063c2abc62f23e84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmDeviceMonitoring save hash after updateFromFullList()
by ahadas＠redhat.com 28 Feb '16

28 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: VmDeviceMonitoring save hash after updateFromFullList() ...................................................................... core: VmDeviceMonitoring save hash after updateFromFullList() In VmDeviceMonitoring, after updateFromFullList(), on the next polling cycle only devices hash is updated, FullList is not called again. But, because isVmDevicesChanged() simply returned false and the VM wasn't touched, the new hash wasn't stored in the DB. This patch adds new return value for isVmDevicesChanged() - HASH_ONLY - to update hash in the DB without refreshing the device list. For the same goal added a new list of VMs whose hash needs to be saved. Change-Id: I5daad3d73f67a578cd0df4b56b104cf791a5fe2e Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 41 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5daad3d73f67a578cd0df4b56b104cf791a5fe2e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: sign websocket ticket did not work for VNC
by tnisan＠redhat.com 28 Feb '16

28 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: sign websocket ticket did not work for VNC ...................................................................... core: sign websocket ticket did not work for VNC The problem was, that the VNC has the tls_port null and the code have not expected it and failed on NPE. Change-Id: Id402460c6d014c9ec9594727c15fe08922991733 Bug-Url: https://bugzilla.redhat.com/1305837 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSignedWebsocketProxyTicketQuery.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id402460c6d014c9ec9594727c15fe08922991733 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0