Change in ovirt-engine-sdk-ruby[master]: Add builtin types to the model
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add builtin types to the model
......................................................................
Add builtin types to the model
Currently the SDK contains types and reader written manually for the
"Fault" and "Action" builtin types. This patch changs the code generator
so that it adds the definitions of these types to the model before
generating the code. As a result the types and readers are also
generated automatically, so there is no need to write them manually.
Change-Id: Id2a08df2f12aa29a4f412443275e8d2667f1a13e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/Tool.java
M sdk/lib/ovirt/sdk/v4.rb
D sdk/lib/ovirt/sdk/v4/action.rb
D sdk/lib/ovirt/sdk/v4/action_reader.rb
D sdk/lib/ovirt/sdk/v4/fault.rb
D sdk/lib/ovirt/sdk/v4/fault_reader.rb
6 files changed, 68 insertions(+), 184 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a08df2f12aa29a4f412443275e8d2667f1a13e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk-ruby[master]: Reduce the number of files
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Reduce the number of files
......................................................................
Reduce the number of files
Currently the SDK has one file for each class, which makes for a total
of hundreds of files. This patch changes the code generator so that it
generates related classes in the same files. For example, instead of
having a file for each type, there is now one single "types.rb" file
containing all or them.
Change-Id: Iaa6d87cd34ce1bff3cf2803ead6af7bdc4d1cfe9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M .gitignore
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
M sdk/lib/ovirt/sdk/v4.rb
R sdk/lib/ovirt/sdk/v4/action.rb
R sdk/lib/ovirt/sdk/v4/action_reader.rb
R sdk/lib/ovirt/sdk/v4/fault.rb
R sdk/lib/ovirt/sdk/v4/fault_reader.rb
R sdk/lib/ovirt/sdk/v4/list.rb
R sdk/lib/ovirt/sdk/v4/reader.rb
R sdk/lib/ovirt/sdk/v4/service.rb
R sdk/lib/ovirt/sdk/v4/struct.rb
R sdk/lib/ovirt/sdk/v4/writer.rb
16 files changed, 175 insertions(+), 396 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa6d87cd34ce1bff3cf2803ead6af7bdc4d1cfe9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[master]: node: Fix cp and add firewalld dependency
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Fix cp and add firewalld dependency
......................................................................
node: Fix cp and add firewalld dependency
Currently, in the installation/update cp -u will update the
existing backup file which can cause misleading conf.
To avoid this case, first remove any existing
backup file before copying the current firewalld conf to backup.
In addition a dependency on firewalld is added, to ensure
that firewalld completed all logic around the configuration
files and we can modify them to our needs.
Previously firewalld could be instaleld after the host-node pkg
which would lead to situation that host-node modified the firewalld.conf
but firewalld overwrote it again, once it got installed.
Change-Id: I4beaeb0b77d9bccea2ba0d6de84973d6c2c8efb5
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4beaeb0b77d9bccea2ba0d6de84973d6c2c8efb5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[master]: node: Node release does not depend on the ovirt-release
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Node release does not depend on the ovirt-release
......................................................................
node: Node release does not depend on the ovirt-release
Previously the ovirt-release-host-node package required the
same VR of the ovirt-release package, but this dependency is not
necessary, because: It is a valid use case to use the ovirt-release
-host-node rpm from master, but use the ovirt-release file from the
stable branch.
With the dependency it is not possible to have different VR for the
ovirt-release and ovirt-release-host-node packages.
With this patch it is now possible to have different VRs.
Change-Id: Ib3edf5d00c2cfc3b0596359246349ede1a9123f8
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54056
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3edf5d00c2cfc3b0596359246349ede1a9123f8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[master]: node: Use systemd scriptlets to perform preset operation
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Use systemd scriptlets to perform preset operation
......................................................................
node: Use systemd scriptlets to perform preset operation
Previously the node subpkg provided a preset file, but the presets
were not applied, because for this to happen, the %systemd_
scriptlets must be called.
This is now done.
Change-Id: I0b00b5fa0948c512da16288b7e8845521587c64e
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b00b5fa0948c512da16288b7e8845521587c64e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in jenkins[master]: ovirt-engine-extension-aaa-ldap: drop el7 on 3.5
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-extension-aaa-ldap: drop el7 on 3.5
......................................................................
ovirt-engine-extension-aaa-ldap: drop el7 on 3.5
ovirt-engine is not built anymore on el7 for 3.5
so this can't be built anymore.
Change-Id: I6a98bb14b461b7b86fb5e3888277739468567da4
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a98bb14b461b7b86fb5e3888277739468567da4
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: jsonrpc: version update
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: jsonrpc: version update
......................................................................
jsonrpc: version update
Bug-Url: https://bugzilla.redhat.com/1311096
Change-Id: If66c8fe85d5d5d15f1b55ac579095cf26a80eab7
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54035
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If66c8fe85d5d5d15f1b55ac579095cf26a80eab7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
8 years, 8 months
Change in ovirt-engine[master]: restapi: Ensure that V4 delegates are always non-null
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Ensure that V4 delegates are always non-null
......................................................................
restapi: Ensure that V4 delegates are always non-null
The V4 compatibility layer is composed by a set of server classes that
are almost empty, as they forward almost all the requests to the
corresponding V4 "delegates". The delegate is passed to the V4
constructor, and it is assumed to be always be non-null, but that isn't
explicitly checked. Some code coverage tools complain about the fact
that it can in theory be null. This patch adds an assertion to the
constructors, which will hoefully stop this complaining.
Change-Id: I7b1405a4856c9b4344f738864b3f18dfd5660da8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3Server.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/54031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b1405a4856c9b4344f738864b3f18dfd5660da8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: Revert "core: Remove condition for AsyncTaskType.notSupported."
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "core: Remove condition for AsyncTaskType.notSupported."
......................................................................
Revert "core: Remove condition for AsyncTaskType.notSupported."
This reverts commit 5ae63ab00decafc2c6eca035213aab549dce5421.
Change-Id: I7b3a106ace37f9b38dfbc10adeceb6fb6f4af807
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/54020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b3a106ace37f9b38dfbc10adeceb6fb6f4af807
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: honor SP=BLANK if provided on CLI answerfile
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: honor SP=BLANK if provided on CLI answerfile
......................................................................
storage: honor SP=BLANK if provided on CLI answerfile
When hosted-engine-setup deploys an additional host
it reads back the SP UUID from disk; this could be BLANK
(just a after the setup of the first host) or a valid value
if the engine already auto-imported the hosted-engine
storage domain.
Deploying additional host, hosted-engine-setup parses the
answerfile from the first host which contains SP=BLANK.
When the user runs hosted-engine-setup interactively
it parses the first host-answerfile after checking the
storage so hosted-engine-setup will always continue
with SP=BLANK.
Instead, if the user wants to run it unattended, he can
append an answerfile on CLI. Also in that case we have to
honor SP=BLANK if present (if not it's just a random value).
Raising if prepareImage fails since continuing will just
hide the real issue.
Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Bug-Url: https://bugzilla.redhat.com/1311317
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 32 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months