Change in ovirt-hosted-engine-setup[master]: storage: honor SP=BLANK if provided on CLI answerfile
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: honor SP=BLANK if provided on CLI answerfile
......................................................................
storage: honor SP=BLANK if provided on CLI answerfile
When hosted-engine-setup deploys an additional host
it reads back the SP UUID from disk; this could be BLANK
(just a after the setup of the first host) or a valid value
if the engine already auto-imported the hosted-engine
storage domain.
Deploying additional host, hosted-engine-setup parses the
answerfile from the first host which contains SP=BLANK.
When the user runs hosted-engine-setup interactively
it parses the first host-answerfile after checking the
storage so hosted-engine-setup will always continue
with SP=BLANK.
Instead, if the user wants to run it unattended, he can
append an answerfile on CLI. Also in that case we have to
honor SP=BLANK if present (if not it's just a random value).
Raising if prepareImage fails since continuing will just
hide the real issue.
Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Bug-Url: https://bugzilla.redhat.com/1311317
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 32 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53975
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56d2a671db4f288bcb72218a88cb071e241ff781
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: Revert "core: Remove condition for AsyncTaskType.notSupported."
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: Revert "core: Remove condition for AsyncTaskType.notSupported."
......................................................................
Revert "core: Remove condition for AsyncTaskType.notSupported."
This reverts commit df9aa9132341d0d07cad2ed202616ed73973e844.
Change-Id: I7b3a106ace37f9b38dfbc10adeceb6fb6f4af807
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/54017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b3a106ace37f9b38dfbc10adeceb6fb6f4af807
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-reports[master]: reports:fixed bug in query of br44
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: reports:fixed bug in query of br44
......................................................................
reports:fixed bug in query of br44
fixed bug in query of br44.
vm uptime(hours) was calculated incorrectly.
Change-Id: I95692100ca057ad369ec78f3e388c2b7c49e77f8
Bug-Url: https://bugzilla.redhat.com/1304656
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95692100ca057ad369ec78f3e388c2b7c49e77f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: VmDevicesMonitoring.Change create ArrayList on demand
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: VmDevicesMonitoring.Change create ArrayList on demand
......................................................................
core: VmDevicesMonitoring.Change create ArrayList on demand
Set lists in VmDevicesMonitoring.Change to null initially and create
them only when some objects are added. Since only part of the lists
will be used at the same time, this change will save memory.
Change-Id: I19ac122578f1d82a5cbabd65d3cb5dd98869524c
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 76 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53172
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19ac122578f1d82a5cbabd65d3cb5dd98869524c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[master]: node: Add vdsm-cli dependency
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Add vdsm-cli dependency
......................................................................
node: Add vdsm-cli dependency
vdsm-cli provide vdsClient which is a useful tool which should be
available on Node.
Change-Id: I3723cf6d5bc6843d6eae194e210be65889400722
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3723cf6d5bc6843d6eae194e210be65889400722
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[master]: [Node]: replace firewalld approach to set ovirthostnode as d...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: [Node]: replace firewalld approach to set ovirthostnode as default zone
......................................................................
[Node]: replace firewalld approach to set ovirthostnode as default zone
systemctl status firewalld always return 0 in anaconda/kickstart so it's
not possible to determine if we should use firewalld-cmd or
firewalld-offline-cmd. As it's supported as well
the manual installation of release pkgs via dnf/yum this patch
will copy current firewalld.conf for later restore and use
sed cmd to update the zone.
For more info:
Running in chroot, ignoring request -- exit code 0
https://bugzilla.redhat.com/show_bug.cgi?id=1110675
Change-Id: Idef65e4125044fee920c7865203d329ce90efb6f
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 17 insertions(+), 16 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53153
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idef65e4125044fee920c7865203d329ce90efb6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: packaging: Remove dependency on org.tukaani.xz
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: packaging: Remove dependency on org.tukaani.xz
......................................................................
core: packaging: Remove dependency on org.tukaani.xz
Removes dependency on org.tukaani.xz which is optional dependency of
apache-common-compress to support XZ compression. We don't use XZ
compression inside engine directly and apache-commmons-compress RPM
is part of EL7, so we no longer need to include it inside oVirt/RHEV
RPMs, so we no longer need to have this optional dependency to
satisfy legal requirements.
Change-Id: Icb86e2e03d2aa468dbac1732b9944658c7cdd027
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/common/src/main/modules/org/apache/commons/compress/main/module.xml
D backend/manager/dependencies/common/src/main/modules/org/tukaani/xz/main/module.xml
M ovirt-engine.spec.in
M pom.xml
5 files changed, 0 insertions(+), 28 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb86e2e03d2aa468dbac1732b9944658c7cdd027
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Storage Tab - s/"Edit"/"Manage Domain"
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Storage Tab - s/"Edit"/"Manage Domain"
......................................................................
core: Storage Tab - s/"Edit"/"Manage Domain"
Raname the "Edit" button to "Manage Domain" to conform with other
bottons in this tab.
Change-Id: I9890f530ccd0924c32b826f24ecc3a5ad7bd3a63
Bug-Url: https://bugzilla.redhat.com/1176217
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/53963
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9890f530ccd0924c32b826f24ecc3a5ad7bd3a63
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Update to commons-compress 1.5
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Update to commons-compress 1.5
......................................................................
core: Update to commons-compress 1.5
Version 1.5 is the one actually used in most environments, as it is what
CentOS 7 provides. This patch just changes it to make sure that the
version used during compiliation and tests is the same that will be used
in most production environments.
Change-Id: Id457409758e4645901c9aed73ca6b578e706c0a9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id457409758e4645901c9aed73ca6b578e706c0a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: changing the OVF update flow to use CoCo
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: changing the OVF update flow to use CoCo
......................................................................
core: changing the OVF update flow to use CoCo
This patch changes the OVF update flow to use CoCo instead of relying on
tasks, that'll allow us to use it for DC with spm and for DC without spm
without further changes.
Change-Id: I8511aa421ef95cbcd768f91bfb5f7d4122651d5c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageSpmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfStoresForStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfVolumeForStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProcessOvfUpdateForStorageDomainCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
8 files changed, 196 insertions(+), 314 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/41736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8511aa421ef95cbcd768f91bfb5f7d4122651d5c
Gerrit-PatchSet: 59
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months