Change in ovirt-engine[ovirt-engine-3.6.3]: core: Only allow continuous numa node indices
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Only allow continuous numa node indices
......................................................................
core: Only allow continuous numa node indices
QEMU only allow continuous virtual NUMA nodes indices. Therefore, on
numa node creation, update and removal make sure that:
* every index exists only once
* the smallest index starts with 0
* no index is missing.
Change-Id: I05e38768be59d9c2eee8a114a3e6d1f684ab5d2d
Bug-Url: https://bugzilla.redhat.com/1126180
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 195 insertions(+), 43 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05e38768be59d9c2eee8a114a3e6d1f684ab5d2d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Set command return value when building CoCo command fr...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Set command return value when building CoCo command from entity
......................................................................
core: Set command return value when building CoCo command from entity
The CommandCoordinatorImpl.buildCommand() method is called via
retrieveCommand() from several callbacks and the result is used to
persist changes to the command.
In some instances, such as AddDiskCommand, the command may have
previously set a return value that a caller may need to retrieve. When
the callbacks are executed and persist an update of the returned
command, the return value is cleared. This causes errors in the calling
code, and in the particular case where this was discovered, makes Image
Upload unable to identify its newly-created disk image.
Change-Id: Idf1067fffe69ed69d45606c0e656f06772864754
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf1067fffe69ed69d45606c0e656f06772864754
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: hosted engine: Avoid choosing the hosted engine sd as ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: hosted engine: Avoid choosing the hosted engine sd as master
......................................................................
core: hosted engine: Avoid choosing the hosted engine sd as master
Hosted engine domain will be under domain-monitoring in bootstrap mode and
when there is no pool and that prevents VDSM in connecting it to the
pool. to avoid further locking and special treatment we have for SPM we
would completly avoid using that domain as master.
Change-Id: Idd42aa656bea838059aaa274c91e7a5400b3b797
Bug-Url: https://bugzilla.redhat.com/1298697
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java
3 files changed, 70 insertions(+), 0 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd42aa656bea838059aaa274c91e7a5400b3b797
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in otopi[master]: packaging: otopi-1.4.1
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: otopi-1.4.1
......................................................................
packaging: otopi-1.4.1
Change-Id: Iacba71e242655a06ac7d615d1a027a651a4a51fa
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M configure.ac
M otopi.spec.in
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacba71e242655a06ac7d615d1a027a651a4a51fa
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: backend: look for OVF store disks only in data domains
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: look for OVF store disks only in data domains
......................................................................
backend: look for OVF store disks only in data domains
OVF store disks exist only in data domains.
Thus, when we attach a storage domain to a dc, we should look for them
only if it's a data domain, and with that prevent irrelevant warning
messages from being logged.
Change-Id: I2df09e5dd76fc75af8a4ad6e6ff0bf69679799fc
Bug-Url: https://bugzilla.redhat.com/1305343
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
2 files changed, 22 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
Idan Shaby: Verified
Objections:
Jenkins CI: Failed CI tests
Liron Aravot: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/53164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2df09e5dd76fc75af8a4ad6e6ff0bf69679799fc
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Fix display if Online Logical CPU Cores list
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix display if Online Logical CPU Cores list
......................................................................
webadmin: Fix display if Online Logical CPU Cores list
On medium/large servers (with many cores), the
"Online Logical CPU Cores" entry on the Hosts
General tab, corrupts the display of other
information
Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163
Bug-Url: https://bugzilla.redhat.com/1301871
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Oved Ourfali: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine-cli[master]: cli: Don' flush input streams
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Don' flush input streams
......................................................................
cli: Don' flush input streams
Flushing the input stream doesn't have any effect in the CLI, except
that it throws an unexpected exception in some platforms, namely in Mac
OS. This patch removes that flushing.
Change-Id: Icee9677795f32ebc09cca16191962b0f4c1a012a
Bug-Url: https://bugzilla.redhat.com/1303635
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/context.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icee9677795f32ebc09cca16191962b0f4c1a012a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: Avoid empty statistic values
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid empty statistic values
......................................................................
restapi: Avoid empty statistic values
Currently when the value returned by the backend for an statistic is
"null" the RESTAPI creates an "statistic" element with an empty "value"
inner element, like this:
<statistic href="..." id="..">
<name>data.total.tx</name>
<description>Total transmitted data</description>
<kind>COUNTER</kind>
<type>INTEGER</type>
<unit>BYTES</unit>
<values>
<value/>
</values>
</statistic>
This is contrary to the XML schema, as it specifies that the "value"
element should contain at least one "datum" element.
This patch fixes the API so that in these cases it will create an empty
"values" element instead:
<statistic href="..." id="..">
<name>data.total.tx</name>
<description>Total transmitted data</description>
<kind>COUNTER</kind>
<type>INTEGER</type>
<unit>BYTES</unit>
<values/>
</statistic>
Change-Id: I22090f89a608b6a2b3454191d55de38beeed2708
Bug-Url: https://bugzilla.redhat.com/1303346
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java
1 file changed, 18 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22090f89a608b6a2b3454191d55de38beeed2708
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix display if Online Logical CPU Cores list
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix display if Online Logical CPU Cores list
......................................................................
webadmin: Fix display if Online Logical CPU Cores list
On medium/large servers (with many cores), the
"Online Logical CPU Cores" entry on the Hosts
General tab, corrupts the display of other
information
Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163
Bug-Url: https://bugzilla.redhat.com/1301871
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: VmBase's getter/setter reordered
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: VmBase's getter/setter reordered
......................................................................
core: VmBase's getter/setter reordered
The clusterCompatibilityVersionOrigin's getter/setter methods
moved after field declaration section of the class.
Change-Id: Ic2b3b75b128ac75457d2b1b76f444d9cb7f6abb5
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2b3b75b128ac75457d2b1b76f444d9cb7f6abb5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months