Change in ovirt-engine[ovirt-engine-3.6.3]: core, frontend: Prevent console stealing from admin user
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core, frontend: Prevent console stealing from admin user
......................................................................
core, frontend: Prevent console stealing from admin user
Before this patch all users were able to take over a console from other
users. Now the console can only be stealed by admin users
(DbUser#isAdmin()).
* ConfitureConsoleOptionsQuery calls SetVmTicketCommand using
runAction() instead of runInternalAction() to allow premissions
checking
* ConfigureConsoleOptionsQuery reports errors of nested
SetVmTicketCommand calls in VdcQueryReturnValue#exceptionString
* SetVmTicketCommand has extended permission checking taking into
account current console user (VM#getConsoleUserId()).
* Frontend calls of ConfitureConsoleOptionsQuery are able to show
localized error messages to users (limited to one string error key, so
variable replacements are no available).
Change-Id: I83ce78829d3f435d0e8d98ab133777c32268303e
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1297018
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetVmTicketCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ShowErrorAsyncQuery.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 192 insertions(+), 11 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83ce78829d3f435d0e8d98ab133777c32268303e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Set default boot order if absent in OVF
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set default boot order if absent in OVF
......................................................................
core: Set default boot order if absent in OVF
Set a default boot order if <BootOrder> elements are absent from OVF.
The default boot order includes all bootable disks in the order the
appear in OVF.
Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1297202
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
2 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in jenkins[master]: ovirt-wgt: new builder job
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-wgt: new builder job
......................................................................
ovirt-wgt: new builder job
we're not going to use standard ci on this job
since we need to sync with upstream and we don't
want to fork.
Change-Id: I177ddb468ff15e92d50a5032718e4919781e5be8
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml
A jobs/confs/yaml/scms/ovirt-wgt.yaml
2 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me
--
To view, visit https://gerrit.ovirt.org/53215
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I177ddb468ff15e92d50a5032718e4919781e5be8
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: BaseGetAttachableDisksQuery streaming API
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseGetAttachableDisksQuery streaming API
......................................................................
core: BaseGetAttachableDisksQuery streaming API
Replaced a cumbersome for loop with a cleaner call to Java 8's streaming
API.
Change-Id: I6dec931be640d2abfd3345379e019851bae0768f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/BaseGetAttachableDisksQuery.java
1 file changed, 4 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dec931be640d2abfd3345379e019851bae0768f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: VmTemplateDaoTest steaming API
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmTemplateDaoTest steaming API
......................................................................
core: VmTemplateDaoTest steaming API
Removed the cumbersome usage of the
org.apache.commons.collections.Transformer and replaced it with the
cleaner, built-in streaming API.
Change-Id: I2e9e634982c72e0e70e318c77ec8d18a73e4f64c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53179
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e9e634982c72e0e70e318c77ec8d18a73e4f64c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: VmDaoTest steaming API
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmDaoTest steaming API
......................................................................
core: VmDaoTest steaming API
Removed the cumbersome usage of the
org.apache.commons.collections.Transformer and replaced it with the
cleaner, built-in streaming API.
Change-Id: Icd54aa12c4e363e9010116529eaa9c0babd8669b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd54aa12c4e363e9010116529eaa9c0babd8669b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: CpuAndMemoryBalancingPolicyUnit ReverseComparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CpuAndMemoryBalancingPolicyUnit ReverseComparator
......................................................................
core: CpuAndMemoryBalancingPolicyUnit ReverseComparator
Remove the redundant dependency on Apache Commons Collections and use
Java's standard way of reversing a Comparator's order.
Change-Id: Ic65537b53b0a4775ad57a67c09828ab0156a9939
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53176
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic65537b53b0a4775ad57a67c09828ab0156a9939
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove IdentifiableUtils
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove IdentifiableUtils
......................................................................
core: Remove IdentifiableUtils
Removed IdentifiableUtils - in Java 8's world, having utilities to
convert formats makes no sense, as you could just as easily stream() and
map(). As a side bonus, this also offers a minor performance
enhancement, as collections don't need to be recreated in every step of
the conversion.
Change-Id: I37e726eec932bd320cd1bc75374a310cdbe95574
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IdentifiableUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
2 files changed, 9 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37e726eec932bd320cd1bc75374a310cdbe95574
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: PmHealthCheckManager lambda expression
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: PmHealthCheckManager lambda expression
......................................................................
core: PmHealthCheckManager lambda expression
Replace a lambda block with an expression lambda to make the code
clearer and easier to read.
Change-Id: I40bdc464bac762562fad62ff3ee4c5c4aa9de66e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40bdc464bac762562fad62ff3ee4c5c4aa9de66e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: cleanup in vm-analyzer
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in vm-analyzer
......................................................................
core: cleanup in vm-analyzer
Remove getDbVm and getVdsManager from VmAnalyzer.
Change-Id: I2b54c0f16c3b2bca77caaf088482ea1002874ae7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
2 files changed, 38 insertions(+), 49 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53168
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b54c0f16c3b2bca77caaf088482ea1002874ae7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months