February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: pass dependencies of vm-analyzer using the ctor
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: pass dependencies of vm-analyzer using the ctor ...................................................................... core: pass dependencies of vm-analyzer using the ctor Pass the dependencies of VmAnalyzer using its constructor rather than using setters in order to simplify the code. Note that some of dependencies can be injected but it since there might be a lot of VMs running on each host, we prefer to inject them once in the factory and pass their reference instead. Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 4 files changed, 145 insertions(+), 109 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject specific daos to vms monitoring
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: inject specific daos to vms monitoring ...................................................................... core: inject specific daos to vms monitoring Inject the specific DAOs that VmsMonitoring is using instead of fetching them using DbFacade. Change-Id: I284fa964247d4bc30bf74d76c03520eff606186e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 31 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284fa964247d4bc30bf74d76c03520eff606186e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GuidUtils streaming
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GuidUtils streaming ...................................................................... core: GuidUtils streaming Reimplented GuidUtils#getGuidListFromString with modern Java 8 streams in order to clean up the code (and probably slightly improve performance). Change-Id: If8586f9e18028c209579f3c71bf133be0a3e54c8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 4 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8586f9e18028c209579f3c71bf133be0a3e54c8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getGuidListFromString null treatment
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: getGuidListFromString null treatment ...................................................................... core: getGuidListFromString null treatment Use Apache Commons Lang's StringUtils to split the input string in order to avoid having to explicitly handle empty strings. Nulls are converted to empty strings and just fed into the method. Change-Id: I5ba8c8734688c29da0ddb1adc7616ea62c3d89de Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ba8c8734688c29da0ddb1adc7616ea62c3d89de Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getGuidListFromStringArray null check
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: getGuidListFromStringArray null check ...................................................................... core: getGuidListFromStringArray null check Removed a redundant null check, as this is a private method, and the caller makes sure null isn't sent to it. Change-Id: I3aa34284debb13f0dc86fa57d42e5baffa2c87e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aa34284debb13f0dc86fa57d42e5baffa2c87e9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: private GuidUtils#getGuidListFromStringArray
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: private GuidUtils#getGuidListFromStringArray ...................................................................... core: private GuidUtils#getGuidListFromStringArray This method is not used externally, so it can safe be made private to ease its refactoring. Change-Id: I7f210f335e6a377738b19fedd8f111f063c5f977 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f210f335e6a377738b19fedd8f111f063c5f977 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: resatpi: BackendStorageDomainResource streaming API
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: resatpi: BackendStorageDomainResource streaming API ...................................................................... resatpi: BackendStorageDomainResource streaming API Replaced a cumbersome for loop with a cleaner call to Java 8's streaming API. Change-Id: I8a0bda22de6979f598e31f82ee2ad76937ab553c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0bda22de6979f598e31f82ee2ad76937ab553c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendFilesResource streaming API
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: BackendFilesResource streaming API ...................................................................... restapi: BackendFilesResource streaming API Replaced a cumbersome for loop with a cleaner call to Java 8's streaming API. Change-Id: Ie89abcd1302ff5cb4a8a6a261dae2d599cc13b1b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie89abcd1302ff5cb4a8a6a261dae2d599cc13b1b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove TagsDirectorTest#testCloneTag()
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove TagsDirectorTest#testCloneTag() ...................................................................... core: Remove TagsDirectorTest#testCloneTag() The Tags class has no special logic or implementation of cloning or serializing. The testCloneTag() uses apache.commons.collections.Trasformer to clone a Tags instance, but no production code does this, meaning this is essentially a test for apache, not oVirt Engine's code. In short, this test is completely redundant, and hence this patch just removes it. Change-Id: I665e44aa1e004cbd9ffd66c1992d414187fea3fd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I665e44aa1e004cbd9ffd66c1992d414187fea3fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: StorageRegisterEntityListModel#syncSearch
by amureini＠redhat.com 08 Feb '16

08 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageRegisterEntityListModel#syncSearch ...................................................................... webadmin: StorageRegisterEntityListModel#syncSearch Fixed the generics specification so that a model of T can be sorted by any Comparator<? extends T>. E.g., a model of VMs should be able to be sorted by a Comparator<Nameable> if we want to sort the VMs by name. Change-Id: Idf414e1f97408264808116cab0e4728bd22adcd8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterEntityListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53197 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf414e1f97408264808116cab0e4728bd22adcd8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0