Change in jenkins[master]: spagobi-dependencies: new jobs
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: spagobi-dependencies: new jobs
......................................................................
spagobi-dependencies: new jobs
Use releng builder until standard template is ready
Change-Id: Ie2789972ffe2dca92bc2992032c9d4bad99cfeac
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/projects/spagobi-dependencies/spagobi-dependencies.yaml
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2789972ffe2dca92bc2992032c9d4bad99cfeac
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: added warning when import windows without virtio
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: added warning when import windows without virtio
......................................................................
webadmin: added warning when import windows without virtio
It is dangerous not to attach VirtIO driwers to windows VMs - added message to
warn the user.
Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c
Bug-Url: https://bugzilla.redhat.com/1296593
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.ui.xml
4 files changed, 60 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Shahar Havivi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: RunVmValidator Entities
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RunVmValidator Entities
......................................................................
core: RunVmValidator Entities
Remove the redundant use of Entities and replace it with Java 8's
built-in streaming API.
Change-Id: I2e980540f61fa6e016527aa16f1228e3f6aac704
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
2 files changed, 4 insertions(+), 16 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e980540f61fa6e016527aa16f1228e3f6aac704
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: webadmin: show the "latest" template only when the new VM is...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: show the "latest" template only when the new VM is stateless
......................................................................
webadmin: show the "latest" template only when the new VM is stateless
It changes the behavior only for the new vm -> don't show the "latest"
templates when the VM is not stateless.
Change-Id: I5b2a7beeb2687521e73168d5171ef14a98185e06
Bug-Url: https://bugzilla.redhat.com/1293154
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
2 files changed, 80 insertions(+), 19 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52867
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b2a7beeb2687521e73168d5171ef14a98185e06
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: Test DestroyImageCheckCommand's
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Test DestroyImageCheckCommand's
......................................................................
core: Test DestroyImageCheckCommand's
This patch adds a test for DestroyImageCheckCommand's logic to check
which volumes still exist.
This patch contains:
1. Extracting the getFailedVolumeIds() method in
DestroyImageCheckCommand, so it can intelligently be tested.
2. Adding DestroyImageCheckCommandTest to test the aforementioned
getFailedVolumeIds().
Change-Id: I8633a9375216f559516c1f7f2e296dfc1bd679aa
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java
2 files changed, 91 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8633a9375216f559516c1f7f2e296dfc1bd679aa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: webadmin: change sizes of suggest boxes
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: change sizes of suggest boxes
......................................................................
webadmin: change sizes of suggest boxes
Change-Id: Ibdddf508a61c36f01f54b5f6f1eab1a7a46ad92c
Bug-Url: https://bugzilla.redhat.com/1293154
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52866
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdddf508a61c36f01f54b5f6f1eab1a7a46ad92c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStorageDomainCommand's comparators ...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStorageDomainCommand's comparators test
......................................................................
core: ProcessOvfUpdateForStorageDomainCommand's comparators test
Add a test for ProcessOvfUpdateForStorageDomainCommand's comparator.
This patch also produces a (very, VERY) slight performance improvement
as the comparator, which is stateless anyway, can be created once and
saved instead of creating a new instance of an anonymous class each
processing iteration.
Change-Id: If8d87c6b4e89711ae052727207c07527c9039a4f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommandComparatorTest.java
2 files changed, 61 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52592
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8d87c6b4e89711ae052727207c07527c9039a4f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStorageDomainCommand comparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStorageDomainCommand comparator
......................................................................
core: ProcessOvfUpdateForStorageDomainCommand comparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
Change-Id: I8c3c165a216115e6e1dbb088ef5df9b9358280e7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
1 file changed, 4 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c3c165a216115e6e1dbb088ef5df9b9358280e7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: Remove unused EngineMessage constants
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused EngineMessage constants
......................................................................
core: Remove unused EngineMessage constants
Change-Id: Id7cbb42c2ac05ef1b23e497326ab92dc023f4f28
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 0 insertions(+), 40 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7cbb42c2ac05ef1b23e497326ab92dc023f4f28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: AbstractPropertiesTestBase generics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AbstractPropertiesTestBase generics
......................................................................
core: AbstractPropertiesTestBase generics
Made AbstractPropertiesTestBase use a generalized Class object instead
of a raw object to help future users avoid unsafe casts and annoying
workarounds.
Change-Id: I39f7fe63b1547e00e63f5f81d2c4251fc00db921
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EngineErrorsTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogMessagesTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumTranslationProperties.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/EngineErrorsTest.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/EngineErrorsTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java
9 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39f7fe63b1547e00e63f5f81d2c4251fc00db921
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months