Change in ovirt-engine[master]: engine: Pass userRemovedNetworkAttachents to the attachments...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Pass userRemovedNetworkAttachents to the attachments persister
......................................................................
engine: Pass userRemovedNetworkAttachents to the attachments persister
HostSetupNetworkCommand fails with exception when removing an existing
attachment and adding a new one that refernces to the same network.
Change-Id: I784452995af4d57036909608c041e309a2e1eb32
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
5 files changed, 46 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I784452995af4d57036909608c041e309a2e1eb32
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: remove duplicate method getLabelToNic
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: remove duplicate method getLabelToNic
......................................................................
core: remove duplicate method getLabelToNic
+ used NetworkUtils.isLabeled instead of nullity check
+ renamed: getNicsToConfigureWithoutLabelsUpdates ->
getExistingInterfacesAndNewlyCreatedBonds
Bug-Url: https://bugzilla.redhat.com/1264405
Change-Id: I1dfb37c1ad5370c69dd3dd6617d9d28f9640f2e2
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
1 file changed, 4 insertions(+), 17 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dfb37c1ad5370c69dd3dd6617d9d28f9640f2e2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: inlined overrideNicWithUserConfiguration
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: inlined overrideNicWithUserConfiguration
......................................................................
core: inlined overrideNicWithUserConfiguration
Change-Id: Ibe104e403b6280ca275be32b3fec8c68f1b42292
Bug-Url: https://bugzilla.redhat.com/1264405
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java
1 file changed, 4 insertions(+), 13 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54414
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe104e403b6280ca275be32b3fec8c68f1b42292
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Do not pass VdsNetworkInterface as user overrides.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Do not pass VdsNetworkInterface as user overrides.
......................................................................
core: Do not pass VdsNetworkInterface as user overrides.
Change-Id: Ie1e65a0da1d124e29541df09c716086566f43eb2
Bug-Url: https://bugzilla.redhat.com/1264405
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserOverriddenNicValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
7 files changed, 98 insertions(+), 39 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54413
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1e65a0da1d124e29541df09c716086566f43eb2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: remove legacy support from HostNetworkAttachmentsPersi...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: remove legacy support from HostNetworkAttachmentsPersister
......................................................................
core: remove legacy support from HostNetworkAttachmentsPersister
Change-Id: I58236b3fc9694dcb923ce72ff559efcbdfc802d6
Bug-Url: https://bugzilla.redhat.com/1277495
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java
4 files changed, 14 insertions(+), 238 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58236b3fc9694dcb923ce72ff559efcbdfc802d6
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: remove SetupNetworksCommand and friends.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: remove SetupNetworksCommand and friends.
......................................................................
core: remove SetupNetworksCommand and friends.
Change-Id: I0ca2a6ad05481a919d653c95c202a81503bc8312
Bug-Url: https://bugzilla.redhat.com/1277495
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FutureVDSCommandType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
11 files changed, 0 insertions(+), 4,334 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54411
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ca2a6ad05481a919d653c95c202a81503bc8312
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: remove 3.0 API (bond manipulations)
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: remove 3.0 API (bond manipulations)
......................................................................
core: remove 3.0 API (bond manipulations)
1. removed commands:
• AddBondCommand
• RemoveBondCommand
• VdsBondCommand
2. removed no longer called vds commands:
• AddNetworkVDSCommand.java
• RemoveNetworkVDSCommand.java
3. removed parameter classes:
• AddBondParameters
• BondParametersBase
• RemoveBondParameters
4. removed unneeded AuditLogTypes:
• NETWORK_ADD_BOND
• NETWORK_ADD_BOND_FAILED
5. removed unneeded translations:
• NETWORK_NOT_EXISTS_IN_CLUSTER
• NETWORK_INTERFACE_IN_USE_BY_VLAN
• NETWORK_ALREADY_ATTACHED_TO_INTERFACE
• NETWORK_BOND_NAME_EXISTS
• NETWORK_BOND_PARAMETERS_INVALID
• EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED
Change-Id: I702d1fec500dc0f50d72bc40dac8e882474ab86b
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsBondCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BondParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveBondParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CommandEntityDaoTest.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RemoveNetworkVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
21 files changed, 1 insertion(+), 848 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I702d1fec500dc0f50d72bc40dac8e882474ab86b
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: remove 3.0 API (attach, detach, update)
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: remove 3.0 API (attach,detach,update)
......................................................................
core: remove 3.0 API (attach,detach,update)
1. removed commands:
• UpdateNetworkToVdsInterface
• AttachNetworkToVdsInterface
• DetachNetworkFromVdsInterface
2. removed related parameter classes:
• AttachNetworkToVdsParameters
• UpdateNetworkToVdsParameters
3. removed no longer needed parent:
• VdsNetworkCommand
4. removed unused AuditLogTypes:
• NETWORK_ATTACH_NETWORK_TO_VDS
• NETWORK_ATTACH_NETWORK_TO_VDS_FAILED
• NETWORK_DETACH_NETWORK_FROM_VDS
• NETWORK_DETACH_NETWORK_FROM_VDS_FAILED
5. removed unneeded VDSCommandTypes:
• VDSCommandType.EditNetwork
6. removed no longer called vds commands:
• EditNetworkVDSCommand.java
7. removed unneeded translations:
• NETWORK_HOST_IS_BUSY
• NETWORK_OLD_NETWORK_NOT_SPECIFIED
• NETWORK_ADDR_MANDATORY_IN_STATIC_IP
• NETWORK_INTERFACE_ALREADY_HAVE_NETWORK
• NETWORK_INTERFACE_CONNECT_TO_VLAN
• NETWORK_INTERFACE_NOT_ATTACH_TO_NETWORK
• NETWORK_DEFAULT_UPDATE_NAME_INVALID
• NETWORK_CHECK_CONNECTIVITY
• NETWORK_BOND_NOT_ATTACH_TO_NETWORK
• NETWORK_INTERFACE_NOT_EXISTS
• NETWORK_CAN_NOT_REMOVE_DEFAULT_NETWORK
Change-Id: Ia3897297135b2a262e8f168b59e5be89acabbeb6
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsNetworkCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Dns.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
19 files changed, 0 insertions(+), 1,027 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3897297135b2a262e8f168b59e5be89acabbeb6
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: mark audit log rows of deleted types as deleted
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: mark audit log rows of deleted types as deleted
......................................................................
core: mark audit log rows of deleted types as deleted
Change-Id: Id5321544e7cc0e74d38ec7bc90bc450af1773616
Bug-Url: https://bugzilla.redhat.com/1277496
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0360_mark_audit_log_rows_of_deleted_audit_log_types_as_deleted.sql
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54989
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5321544e7cc0e74d38ec7bc90bc450af1773616
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: engine: Allow Html5 as one of the default spice modes
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Allow Html5 as one of the default spice modes
......................................................................
engine: Allow Html5 as one of the default spice modes
Html5 is added among allowed default spice modes for engine-config.
Change-Id: I7f6439cd67f48a3eb38703dc1414805cdecbe9c2
Bug-Url: https://bugzilla.redhat.com/1311408
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/55124
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6439cd67f48a3eb38703dc1414805cdecbe9c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months