Change in ovirt-engine-sdk-ruby[master]: Use only query parameters
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Use only query parameters
......................................................................
Use only query parameters
Currently the SDK has to send parameters as both query and matrix
parameters, as the server some times requires query and some times
matrix. But the server has recently been fixed to support both, for all
paramers, so the SDK no longer needs to send both. This patch changes
the SDK so that it only uses query parameters.
Change-Id: Ib17aaaab7b5660619c2ac69ee2f5c737e61d9ce3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/lib/ovirtsdk4/http.rb
M sdk/spec/connection_spec.rb
3 files changed, 4 insertions(+), 98 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib17aaaab7b5660619c2ac69ee2f5c737e61d9ce3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[ovirt-3.6]: node: Add distag to node packages
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Add distag to node packages
......................................................................
node: Add distag to node packages
Make the Node packages only available on el7.
Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release36.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[ovirt-4.0]: node: Add distag to node packages
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Add distag to node packages
......................................................................
node: Add distag to node packages
Make the Node packages only available on el7.
Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release40.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-hosted-engine-setup[master]: Revert "add_host: SDK call update"
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Revert "add_host: SDK call update"
......................................................................
Revert "add_host: SDK call update"
After
Id6fad7867102c9e121c4c0ddfb4be7bba43bb9bd
will still rely on SDK from 3.6 since
SDK 4.0 is still under heavy refactoring.
Reverting this to 3.6 status for
compatibility reasons.
This reverts commit b61609627ad5147551b585d1365dc9ffd9498351.
Bug-Url: https://bugzilla.redhat.com/1318652
Change-Id: I30a02672bdcfa3c1984472594bfc91363122f78f
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30a02672bdcfa3c1984472594bfc91363122f78f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[master]: node: Add distag to node packages
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Add distag to node packages
......................................................................
node: Add distag to node packages
Make the Node packages only available on el7.
Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fd3e9f4f2b11bcbbe03180084f09c896f583726
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-hosted-engine-setup[master]: Revert "add_host: from cpu.set_id to cpu.set_type"
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Revert "add_host: from cpu.set_id to cpu.set_type"
......................................................................
Revert "add_host: from cpu.set_id to cpu.set_type"
After
Id6fad7867102c9e121c4c0ddfb4be7bba43bb9bd
will still rely on SDK from 3.6 since
SDK 4.0 is still under heavy refactoring.
Reverting this to 3.6 status for
compatibility reasons.
This reverts commit 4744f6c6fe48de23e81cac9691b9c6533cd3ec55.
Bug-Url: https://bugzilla.redhat.com/1318652
Change-Id: I7951b3b5343e8533bdb4832bdbeb8954440017dd
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7951b3b5343e8533bdb4832bdbeb8954440017dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: StorageDomainValidator functional interface
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageDomainValidator functional interface
......................................................................
core: StorageDomainValidator functional interface
Use lambdas as functional interfaces instead of anonymous
implementations, as per Java 8 and the project's standards.
Change-Id: I16bc9d1814585a468407d9df3abe28b9fdbe594d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
1 file changed, 31 insertions(+), 39 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16bc9d1814585a468407d9df3abe28b9fdbe594d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: KeysConfig default path constant
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: KeysConfig default path constant
......................................................................
core: KeysConfig default path constant
Renamed the constant to a proper upstream name referencing oVirt instead
of RHEV.
Change-Id: I5ae1bf6bc34ccfbbb07c063cbd9a0ac2800cc21e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/KeysConfig.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/54830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ae1bf6bc34ccfbbb07c063cbd9a0ac2800cc21e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove unused ConfigValues
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ConfigValues
......................................................................
core: Remove unused ConfigValues
This patch removes ConfigValues that are no longer used by the
application.
It removes:
* Entires in ConfigValues
* The corresponding entires in ConfigurationValues
* The corresponding entries in engine-config.properties
* The corresponding entries from the database
* Mocking of these entries in tests
Change-Id: I09b6e7133028fa7986f04583cedc453e31e36770
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/04_00_0330_delete_unused_vdc_options.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
7 files changed, 17 insertions(+), 137 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54848
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09b6e7133028fa7986f04583cedc453e31e36770
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Reindex vdc_options after upgrade
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Reindex vdc_options after upgrade
......................................................................
core: Reindex vdc_options after upgrade
Once installed in a running system, the vdc_options table is
relatively static, with users rarely changing it. However, upgrading
the system usually involves a large amount of changes to it (see
details below). This makes this table a good candidate for indexing at
the end of the upgrade (hence the script is added to the post_upgrade
directory).
Consider, e.g., upgrading from the latest 3.6 release (i.e., 3.6.3.4,
built from commit cb35e8c) to the current master branch (commit
7fe2363, which will eventually be a part of 4.0 when it's released):
In 3.6.3, this table had 871 rows. The upgrade to 4.0 deleted 468 of
them (~54%) and added 63 new lines (~7%). Reindexing it on my test
setup (Postgres 9.4.6 on Fedora 23, with default configurations) reduced
the size of the ix_vdc_options index from 80KB to 40KB (50%) and the
size of pk_vdc_options, the primary key's index, from 40KB to 32KB
(20%).
Change-Id: I2fff10b11bf3dafa71f96651ef2cecb491f89a86
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A packaging/dbscripts/upgrade/post_upgrade/0040_reindex_vdc_options.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fff10b11bf3dafa71f96651ef2cecb491f89a86
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months