Change in ovirt-engine[master]: core: Remove UserMessageOfTheDay ConfigValue
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove UserMessageOfTheDay ConfigValue
......................................................................
core: Remove UserMessageOfTheDay ConfigValue
The UserMessageofTheDay ConfigValue is only used by the
AsyncDataProvider, in a method which is never called itself.
This patch finishes removing this unused method, the ConfValue and
the ConfigurationValue associated with it.
Change-Id: Id07b2fc650ff03ed9373e018b1f4342dc914bb0b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
A packaging/dbscripts/upgrade/04_00_0320_delete_user_message_of_the_day.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
7 files changed, 1 insertion(+), 22 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54847
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id07b2fc650ff03ed9373e018b1f4342dc914bb0b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: build: push hamcrest down to the root pom.xml
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: build: push hamcrest down to the root pom.xml
......................................................................
build: push hamcrest down to the root pom.xml
hamcrest is a basic requirement for unit tests, like junit. This patch
removes its dependency from the various pom.xmls it appears in and
pushes it down to the root pom.xml, as was done with the other basic
testing libraries like junit and mockito.
Change-Id: I6728a3b15e90fb3b588c6622811d684eee73cccb
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/dal/pom.xml
M pom.xml
3 files changed, 6 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6728a3b15e90fb3b588c6622811d684eee73cccb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: tools: CriticalSpaceActionBlocker description
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: CriticalSpaceActionBlocker description
......................................................................
tools: CriticalSpaceActionBlocker description
Commit 19038bdfa4971ecf969c14e4174b89f2fcd251e5 renamed the
CriticalSpaceThreshold ConfigValue to CriticalSpaceActionBlocker, but
missed updating its description in engine-config.properties.
This patch fixes that mistake.
Change-Id: Idf79ea215d524b8d41df3a3463dd706c805febfa
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf79ea215d524b8d41df3a3463dd706c805febfa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Cleanup engine-config.properties
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Cleanup engine-config.properties
......................................................................
core: Cleanup engine-config.properties
engine-config.properties should represent a subset of ConfigValues users
are able to control easily. Several careless patches have left obsolete
references in it that do not represent valid config values any more and
just confuse users.
This patch removes these obsolete entries and introduces a unit test
which evaluates packaging/etc/engine-config/engine-config.properties
against the ConfigValues enum to ensure such mistakes don't happen
again.
Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/tools/pom.xml
A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigPropertiesTest.java
M packaging/etc/engine-config/engine-config.properties
3 files changed, 54 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove InitStorageSparseSizeInGB ConfigValue
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove InitStorageSparseSizeInGB ConfigValue
......................................................................
core: Remove InitStorageSparseSizeInGB ConfigValue
The InitStorageSparseSizeInGB ConfigValue is pointless, as the size
property of the disk already takes this into account. It has been
removed from production code throughout the codebase (although,
surprisingly, it was not removed from the tests), and only appears
mistakenly in the quote calculation of creating a new pool, where it has
no effect anyway, as its value is 1 and it's used in multiplication.
This patch finishes the job and removes all trace of this redundant
config value
Change-Id: I4358a78a88898fc93b095becc883dec5d066246e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/04_00_0310_delete_init_storage_sparse_size_in_gb.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
6 files changed, 2 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4358a78a88898fc93b095becc883dec5d066246e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove unused ConfigurationValues
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ConfigurationValues
......................................................................
core: Remove unused ConfigurationValues
ConfigurationValues are a subset of the ConfigValues exposed to the
various frontend applications. This patch removes such values that were
either added by mistake or neglected while refactoring/updating the
frontend code in a way they are no longer used by it.
Change-Id: If905cbe85a8c6d5dca4b49f6da1e4d616def3fdf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 0 insertions(+), 43 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54834
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If905cbe85a8c6d5dca4b49f6da1e4d616def3fdf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in jenkins[master]: Added github publisher to startand-ci github
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added github publisher to startand-ci github
......................................................................
Added github publisher to startand-ci github
Change-Id: I8c8741d6721e708b5e717e9b969abbb96b99a6a1
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/54880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c8741d6721e708b5e717e9b969abbb96b99a6a1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: restapi: Restore incorrect behaviour of V3 remove
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Restore incorrect behaviour of V3 remove
......................................................................
restapi: Restore incorrect behaviour of V3 remove
In version 3 of the API some DELETE operations have two signatures: with
and without a body. This is bad practice, and has been removed in
version 4 of the API. But we need to preserve them for backwards
compatibility, and the only way to differentiate one the other is to
use different "@Consumes" annotations. The signature that doesn't accept
a body should not have this annotation, so that it accepts requests that
don't include the "Accept" header, or "Accept: */*". The other signature
needs to have the annotation, specifying that it accepts XML and JSON,
so that it is selected when a body is included in the request. This
incorrect behaviour existed in version 3 of the API, but was lost when
the 3 to 4 transformation layer was introduced. This patch restores it.
Change-Id: I31f98d1a28c267b4fa48bea59ded539f789d76ef
Bug-Url: https://bugzilla.redhat.com/1318666
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3GlusterBricksServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31f98d1a28c267b4fa48bea59ded539f789d76ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine-sdk-ruby[master]: Use SSO service for authentication
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Use SSO service for authentication
......................................................................
Use SSO service for authentication
When authenticating the sdk should obtain
access_token from SSO and use Bearer
authentication to access api using the
access token.
Add a new option for Connection sso_url
which specifices the sso url
Change-Id: Ia82d6c00569fcd0d7948f151736314971ec4b473
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M README.adoc
A sdk/examples/external_authentication.rb
A sdk/examples/kerberos_authentication.rb
M sdk/lib/ovirtsdk4/http.rb
A sdk/spec/clusters_kerberos_service_spec.rb
M sdk/spec/spec_helper.rb
6 files changed, 383 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54763
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia82d6c00569fcd0d7948f151736314971ec4b473
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Rename "Virtual Disk" to "Disk"
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Rename "Virtual Disk" to "Disk"
......................................................................
core: Rename "Virtual Disk" to "Disk"
There are cases where the use of the term "Virtual Disk" is inaccurate,
for example when the disk can also be a floating disk or a template
disk.
This patch rephrases such instances to be more generic.
Change-Id: I2e1a4d7acc80bf0523696a3fe1f8c66f2e4abb57
Bug-Url: https://bugzilla.redhat.com/1271698
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DetachDiskFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RegisterCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
22 files changed, 23 insertions(+), 23 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/54713
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e1a4d7acc80bf0523696a3fe1f8c66f2e4abb57
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months