Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: fix external links
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: fix external links
......................................................................
userportal,webadmin: fix external links
- With the new wiki the urls of a bunch of links changed
this patch fixes the links to point to valid locations
again.
Change-Id: I2cce161035329ea20f570fffe13f2ff9206fe976
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312880
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M packaging/branding/ovirt.brand/external_resources.properties
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cce161035329ea20f570fffe13f2ff9206fe976
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-release[ovirt-3.6]: node: Use ovirt-release-host-node
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Use ovirt-release-host-node
......................................................................
node: Use ovirt-release-host-node
Change-Id: I70d193f39c5f50d6d119f8a42457859c6dd913b1
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M configure.ac
M ovirt-release36.spec.in
2 files changed, 10 insertions(+), 7 deletions(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70d193f39c5f50d6d119f8a42457859c6dd913b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: webadmin: removed unnecessary 'Run On' tooltips
by gshereme@redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: removed unnecessary 'Run On' tooltips
......................................................................
webadmin: removed unnecessary 'Run On' tooltips
Removed the unnesessary 'Run On' tooltips. They were added
because the 'Run On' field used to get truncated, but it
no longer does. So the tooltip was a duplicate of what's
already there.
Change-Id: I3ec9ac06875f5d1524290636c49c9ee3a983be6f
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java
4 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Roman Mohr: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/54845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ec9ac06875f5d1524290636c49c9ee3a983be6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: userportal: ignore CpuProfileOperator for everyone
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: ignore CpuProfileOperator for everyone
......................................................................
userportal: ignore CpuProfileOperator for everyone
The CpuProfileOperator on everyone made everyone see the power user portal.
This adds also this role to be ignored.
Change-Id: I4fff54bed5fe0b7550e55872dca1d5997c05ef4a
Bug-Url: https://bugzilla.redhat.com/1316849
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Tal Nisan: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54801
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fff54bed5fe0b7550e55872dca1d5997c05ef4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: console not correctly loaded for edit template
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: console not correctly loaded for edit template
......................................................................
webadmin: console not correctly loaded for edit template
The logic handling of the loading of the console was implemented only for the
existing VMs. Fixed by moving it to a base class and calling it also from
template.
Change-Id: I43786b9738b116549c7d29e5eea53c05da60c3fe
Bug-Url: https://bugzilla.redhat.com/1315886
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
3 files changed, 34 insertions(+), 33 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43786b9738b116549c7d29e5eea53c05da60c3fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: provide a more informative message on not enough space
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: provide a more informative message on not enough space
......................................................................
storage: provide a more informative message on not enough space
Provide a more informative message if there is not enough free
space on the storage domain.
Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a
Bug-Url: https://bugzilla.redhat.com/1318612
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/image.py
1 file changed, 12 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove wrong code in AddVmAndAttachToPoolCommand
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove wrong code in AddVmAndAttachToPoolCommand
......................................................................
core: Remove wrong code in AddVmAndAttachToPoolCommand
AddVmAndAttachToPoolCommand is adding a VM to an exisiting pool, the VM
added to the pool is based on the same non blank template as the rest of
the pool so the logic of creating a VM based on a blank template is wrong
and thus can be removed
Change-Id: I48f484f44e812063aabbb8bb7f7008616e4ffa5c
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
1 file changed, 16 insertions(+), 25 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f484f44e812063aabbb8bb7f7008616e4ffa5c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Remove wrong code in AddVmFromScratchCommand
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove wrong code in AddVmFromScratchCommand
......................................................................
core: Remove wrong code in AddVmFromScratchCommand
AddVmFromScratchCommand is called in all flows when a VM is created with a
blank template, in the case the VM cannot have disks to be created thus the
logic within addVmImages is incorreect and removed
Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
1 file changed, 1 insertion(+), 49 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I932ac5744deda45360c26db6d15afe8d485e7229
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in jenkins[master]: github:Fixed unwanted triggers by quoted messages
by dcaro@redhat.com
David Caro has submitted this change and it was merged.
Change subject: github:Fixed unwanted triggers by quoted messages
......................................................................
github:Fixed unwanted triggers by quoted messages
That usually happens on email responses
Change-Id: I8a7ca86397c1cf68a8728730c2d2a7cecdffa8e0
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/triggers/github.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/54843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a7ca86397c1cf68a8728730c2d2a7cecdffa8e0
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-hosted-engine-setup[master]: storage: provide a more informative message on not enough space
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: provide a more informative message on not enough space
......................................................................
storage: provide a more informative message on not enough space
Provide a more informative message if there is not enough free
space on the storage domain.
Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a
Bug-Url: https://bugzilla.redhat.com/1306573
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/image.py
1 file changed, 12 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf640f25c7c891ea9471c4fdb7df103c7b82212a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months