April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core : oVirt welcome page locale selector is broken
by gshereme＠redhat.com 14 Apr '16

14 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: core : oVirt welcome page locale selector is broken ...................................................................... core : oVirt welcome page locale selector is broken oVirt welcome page locale selector is broken Change-Id: I2d5f44608a9caec62e1e29cf30f23de24ebd9667 Bug-Url: https://bugzilla.redhat.com/1323484 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/LocaleFilter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d5f44608a9caec62e1e29cf30f23de24ebd9667 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: rename splash.js
by gshereme＠redhat.com 14 Apr '16

14 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: rename splash.js ...................................................................... userportal, webadmin: rename splash.js rename splash.js -> welcome-locale-selector.js Change-Id: I601e9dc60ea04014f6a1e1db1d799ba7d43871f6 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp R backend/manager/modules/welcome/src/main/webapp/welcome-locale-selector.js 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601e9dc60ea04014f6a1e1db1d799ba7d43871f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: removed unused css class
by gshereme＠redhat.com 14 Apr '16

14 Apr '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: removed unused css class ...................................................................... webadmin: removed unused css class Removed unused css class, cvp_clusterPolicyContent_pfly_fix Change-Id: Ic057bdd3b411d58684a22b51f0c602edb4d2bbba Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/56054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic057bdd3b411d58684a22b51f0c602edb4d2bbba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Make backend a request attribute
by juan.hernandez＠redhat.com 14 Apr '16

14 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Make backend a request attribute ...................................................................... restapi: Make backend a request attribute Currently the reference to the backend object is an attribute of each resource implementation. This patch changes the API so that it is a request attribute, managed by the "Current" object. This makes it easier to introduce other filters that replace or enrich it as part of the HTTP processing pipeline. Change-Id: I18f0437cc37fd74fb07aa27a3df97c213cf20bcb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/Current.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentFilter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmApplicationsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResourceTest.java 18 files changed, 26 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18f0437cc37fd74fb07aa27a3df97c213cf20bcb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: enable IPv6 in REST
by juan.hernandez＠redhat.com 14 Apr '16

14 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: enable IPv6 in REST ...................................................................... restapi: enable IPv6 in REST Change-Id: I7c522ef59f0b847c767c15de98c2142ca683b224 Bug-Url: https://bugzilla.redhat.com/1080725 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MappingLocator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/modules/org/ovirt/engine/api/restapi-types/main/module.xml M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapperTest.java 5 files changed, 164 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/52545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c522ef59f0b847c767c15de98c2142ca683b224 Gerrit-PatchSet: 65 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix NPE in Edit VM dialog
by tnisan＠redhat.com 14 Apr '16

14 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Edit VM dialog ...................................................................... webadmin: Fix NPE in Edit VM dialog NPE was thrown when Edit VM dialog was opened by selecting the vm followed by multiple clicks on action button (toolbar above table of vms) "Edit". The problem was in InstanceImagesModel#getAllCurrentDisks() that failed if getItems() returned `null` and in ExistingVmModelBehavior#updateInstanceImages$1.onSuccess that calls `lineModel.initialize` and thus transitively InstanceImagesModel#getAllCurrentDisks() before `getModel().getInstanceImages().setItems()` is called. Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Bug-Url: https://bugzilla.redhat.com/1326311 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add missing javax.mail.api dependency
by mperina＠redhat.com 14 Apr '16

14 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Add missing javax.mail.api dependency ...................................................................... core: Add missing javax.mail.api dependency Adds missing javax.mail.api dependency to fix: NoClassDefFoundError: javax/mail/internet/AddressException which is most probably caused by classloader differencies between WildFly 8 and 10. Change-Id: Ib98b6b0951c76d905a4674ec3ad2f60eafcf8422 Bug-Url: https://bugzilla.redhat.com/1326578 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ear/src/main/application/META-INF/jboss-deployment-structure.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib98b6b0951c76d905a4674ec3ad2f60eafcf8422 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix IpAddressPredicateTest.testCompressedIpv6AndNotC...
by alkaplan＠redhat.com 14 Apr '16

14 Apr '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix IpAddressPredicateTest.testCompressedIpv6AndNotCompressedIpv6 ...................................................................... engine: fix IpAddressPredicateTest.testCompressedIpv6AndNotCompressedIpv6 Change-Id: I4026f0b240a8c3c412bb6b9914ce945b451009f7 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/IpAddressPredicateTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/56145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4026f0b240a8c3c412bb6b9914ce945b451009f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: vdsbroker: wait for reconnection
by tnisan＠redhat.com 14 Apr '16

14 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: wait for reconnection ...................................................................... vdsbroker: wait for reconnection During setupNetworks we need to wait for reconnection before sending the command to vdsm. Change-Id: I0a962d661e165f97e03c1d4f9648f1489568d8b4 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1320128 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 59 insertions(+), 10 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a962d661e165f97e03c1d4f9648f1489568d8b4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move ear deps from manifest to XML config
by mperina＠redhat.com 14 Apr '16

14 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Move ear deps from manifest to XML config ...................................................................... core: Move ear deps from manifest to XML config Moves ear module dependencies from MANIFEST.MF to jboss-deployment-structure.xml. Change-Id: I14bf255106b7c9db1c241970037fd59b0332cab8 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ear/pom.xml M ear/src/main/application/META-INF/jboss-deployment-structure.xml D ear/src/main/resources/META-INF/MANIFEST.MF 3 files changed, 34 insertions(+), 40 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14bf255106b7c9db1c241970037fd59b0332cab8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0