Change in ovirt-engine[ovirt-engine-3.6]: core: Live Merge: Improve Live Merge Recovery Mechanism
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Live Merge: Improve Live Merge Recovery Mechanism
......................................................................
core: Live Merge: Improve Live Merge Recovery Mechanism
When sending live merge command, we may fail to get vdsm's response
due to network error. In this case, the parent of the volume that
should have been deleted (the volume that the data is merged in to)
will be marked as ILLEGAL. However, a merge job may have started, and
even possibly completed, and we want to allow the user to try live
merge again in order to remove the snapshot. When the user tries live
merge again, if the volume is already deleted from the chain or if
there is a running merge job, vdsm returs 'imageErr' or 'mergeErr',
respectively. In this patch, engine catches those errors and
continues the merge flow as if it succeeded. If merge succeeded the
volume is removed from database. Otherwise, volume stays in ILLEGAL
state.
Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5
Bug-Url: https://bugzilla.redhat.com/1301083
Bug-Url: https://bugzilla.redhat.com/1304761
Bug-Url: https://bugzilla.redhat.com/1314082
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 48 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/56734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[ovirt-3.6]: node: Enable sshd.service by default
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Enable sshd.service by default
......................................................................
node: Enable sshd.service by default
Previously we enabled sshd.socket by default, this lead to bug
https://bugzilla.redhat.com/show_bug.cgi?id=1327332#c5
Now we just enable the sshd.service, which should avoid this bug,
and also be aligned with what anaconda does.
Change-Id: I88a0703b1a4818c4817637ce1e6021e979602b45
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1323975
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M host-node/systemd/system-preset/98-ovirt-host-node.preset
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a0703b1a4818c4817637ce1e6021e979602b45
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[ovirt-3.6]: node: Don't touch vdsm
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Don't touch vdsm
......................................................................
node: Don't touch vdsm
vdsm has it's own presets for it's own services, thus we leave it untouched.
Change-Id: I582f0333cf115eb67d9e4ed734a0fdbb0683c058
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M host-node/systemd/system-preset/98-ovirt-host-node.preset
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56740
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I582f0333cf115eb67d9e4ed734a0fdbb0683c058
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[ovirt-3.6]: [Node]: Add requires for gluster pkgs
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: [Node]: Add requires for gluster pkgs
......................................................................
[Node]: Add requires for gluster pkgs
Gluster packages are required to be included in the node distro.
Change-Id: I3cf5f91a904535eb0adc3efabe92c89ead5cd12e
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-release36.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cf5f91a904535eb0adc3efabe92c89ead5cd12e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-hosted-engine-setup[master]: vdsm: switch from XML-RPC to JSON-RPC API
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: vdsm: switch from XML-RPC to JSON-RPC API
......................................................................
vdsm: switch from XML-RPC to JSON-RPC API
Requires: https://gerrit.ovirt.org/55244
Requires: https://gerrit.ovirt.org/55246
Requires: https://gerrit.ovirt.org/55247
Requires: https://gerrit.ovirt.org/55249
Requires: https://gerrit.ovirt.org/55250
Requires: https://gerrit.ovirt.org/55252
Requires: https://gerrit.ovirt.org/56206
Requires: https://gerrit.ovirt.org/56207
Requires: https://gerrit.ovirt.org/56217
Requires: https://gerrit.ovirt.org/56288
Change-Id: I8b87b35eb6d523f2b4e8edd52b1283072eed09f7
Bug-Url: https://bugzilla.redhat.com/1228641
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/mixins.py
M src/ovirt_hosted_engine_setup/tasks.py
M src/ovirt_hosted_engine_setup/vds_info.py
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py
M src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
M src/plugins/ovirt-hosted-engine-setup/system/packages.py
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py
M src/plugins/ovirt-hosted-engine-setup/vm/image.py
M src/plugins/ovirt-hosted-engine-setup/vm/memory.py
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
17 files changed, 173 insertions(+), 157 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b87b35eb6d523f2b4e8edd52b1283072eed09f7
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-release[ovirt-3.6]: epel: python-ecdsa has been renamed
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: epel: python-ecdsa has been renamed
......................................................................
epel: python-ecdsa has been renamed
Updated python-ecdsa to python2-ecdsa for epel7.
Change-Id: Ib35305aae9b19b7ac1a3009e32cb5aaff97de485
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 0069d6e7400e0f2b513e02444cc1b99d095c4a2d)
(cherry picked from commit d33519986449fbb085feb5512a6adfeceb9a47b4)
---
M ovirt-el7-deps.repo.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35305aae9b19b7ac1a3009e32cb5aaff97de485
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Live Merge: Improve Live Merge Recovery Mechanism
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Live Merge: Improve Live Merge Recovery Mechanism
......................................................................
core: Live Merge: Improve Live Merge Recovery Mechanism
When sending live merge command, we may fail to get vdsm's response
due to network error. In this case, the parent of the volume that
should have been deleted (the volume that the data is merged in to)
will be marked as ILLEGAL. However, a merge job may have started, and
even possibly completed, and we want to allow the user to try live
merge again in order to remove the snapshot. When the user tries live
merge again, if the volume is already deleted from the chain or if
there is a running merge job, vdsm returs 'imageErr' or 'mergeErr',
respectively. In this patch, engine catches those errors and
continues the merge flow as if it succeeded. If merge succeeded the
volume is removed from database. Otherwise, volume stays in ILLEGAL
state.
Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5
Bug-Url: https://bugzilla.redhat.com/1301083
Bug-Url: https://bugzilla.redhat.com/1304761
Bug-Url: https://bugzilla.redhat.com/1314082
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 48 insertions(+), 18 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved; Passed CI tests
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/56472
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic54ae8576410afbdd095fdae1fb298f2262218f5
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Don't prefill DWH connection pool
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Don't prefill DWH connection pool
......................................................................
core: Don't prefill DWH connection pool
This pool won't exist in some installations, as DWH is an optional
component, and prefilling it means that an exception will be generated
during startup, which confuses users. This patch changes the
configuration of the pool so that it isn't prefilled.
Change-Id: I808e018771f87ae23930db342db2184a3826dcc8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.xml.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I808e018771f87ae23930db342db2184a3826dcc8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk[master]: Move connection class to "ovirtsdk4" module
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Move connection class to "ovirtsdk4" module
......................................................................
Move connection class to "ovirtsdk4" module
Currently the "Connection" and "ConnectionBuilder" classes are part of
the "ovirtsdk4.http" module, but then the classes are imported from the
"ovitsdk4" module so that the user can just "import ovirtsdk4". But this
has the downside that tools that automatically generate documentation
will generate it under "ovirtsdk4.http", which can be confusing for
users. To avoid this potential source of confusion this patch moves the
"Connection" and "ConnnectionBuilder" classes to the "__init__.py" file
of the "ovirtsdk4" module.
Change-Id: Ia79b93b2e510a39af1592e0886ee958f5e90f5a7
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/http.py
2 files changed, 561 insertions(+), 565 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia79b93b2e510a39af1592e0886ee958f5e90f5a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk[master]: Use SSO service for authentication
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Use SSO service for authentication
......................................................................
Use SSO service for authentication
When authenticating the sdk should obtain access_token from SSO and use
Bearer authentication to access api using the access token.
Add a new option for Connection sso_url which specifices the sso url
Change-Id: I16c6e99ff39dff39afea8e16017c7836398cb452
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/lib/ovirtsdk4/http.py
1 file changed, 141 insertions(+), 15 deletions(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c6e99ff39dff39afea8e16017c7836398cb452
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months