May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: Make video device explicit
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Make video device explicit ...................................................................... Make video device explicit ovirt-engine specifies the video device it requires explicitly. This does the same thing for HE setup to avoid any surprises regarding VDSM reporting these devices. In some cases the implicitly added video devices were not completely reported of omitted by VDSM. Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971 Related-to: https://bugzilla.redhat.com/1326810 Related-to: https://bugzilla.redhat.com/1328921 Bug-Url: https://bugzilla.redhat.com/1339306 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/gr-he-setup/vm/configurevm.py M templates/vm.conf.in 3 files changed, 21 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in OVF disk creation
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in OVF disk creation ...................................................................... core: Fix error in OVF disk creation Change-Id: Ib29a2f9c098b71d7e3d8269a2eb877211f4be903 Bug-Url: https://bugzilla.redhat.com/1339330 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfVolumeForStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib29a2f9c098b71d7e3d8269a2eb877211f4be903 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: build: ovirt-release36-3.6.7_rc1
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release36-3.6.7_rc1 ...................................................................... build: ovirt-release36-3.6.7_rc1 Change-Id: Ic990d3a491d95dd1b6c727b23ff01dcd7e2d7837 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic990d3a491d95dd1b6c727b23ff01dcd7e2d7837 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: v2v-source vms list is cleaned in failure
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: v2v-source vms list is cleaned in failure ...................................................................... webadmin: v2v-source vms list is cleaned in failure While opening the Webadmin Import VM dialog and importing from VMware source or any other external source (v2v), the "virtual machines on source" list was not cleaned in case of entering invalid parameters. After this fix: if you enter valid parameters and click the "load" button -> the "virtual machines on source" list is displayed. If you then enter incorrect parameters and click the "load" button again (either field validation failure or connection failure), the "virtual machines on source" list is now cleaned while an error is displayed. The bug was opened for VMware but this fix is done for all external sources. Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372 Bug-Url: https://bugzilla.redhat.com/1298293 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixing not necessary NPEs, asking for dao only when ne...
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: fixing not necessary NPEs, asking for dao only when needed. ...................................................................... core: fixing not necessary NPEs, asking for dao only when needed. Change-Id: I5f19ea7405f450f76b48018da1c9343e19fe18aa Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 3 files changed, 29 insertions(+), 17 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f19ea7405f450f76b48018da1c9343e19fe18aa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add/UpdateVmInterfaceCommand fix compensation
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add/UpdateVmInterfaceCommand fix compensation ...................................................................... engine: Add/UpdateVmInterfaceCommand fix compensation 'VmBase.ssoMethod' field caused the bug. The enum 'SsoMethod' overrides 'toString()' method. Since 'JsonObjectDeserializerFactory' uses 'EnumResolver.constructUnsafeUsingToString' to create a map of enum keys to enum values, the key of the map is the value of the 'toString()' -> the lower case name of the enum. On the other hand, the serializer uses the 'name()' method as the key of the serialized enum. Since in 'SsoMethod' the 'name()' and the 'toString()' are not the same, the deserialier cannot find the serialized enum. Added '@JsonCreator' and '@JsonValue' to make sure the key in both serialization and deserialization will be the same. Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Bug-Url: https://bugzilla.redhat.com/1338601 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: introducing pool awareness of transaction and compensa...
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing pool awareness of transaction and compensation ...................................................................... core: introducing pool awareness of transaction and compensation This patch is needed so that if tx is rollbacked or compensation occurs, then pool content is updated accordingly. This patch is squashed from multiple smaller patches, if you need finer info, please look for following gerrit topic: https://gerrit.ovirt.org/#/q/topic:txAndCompensationAwareMacPools Change-Id: Idbd4967ca53403b03454b22a74f7d0f632104fc4 Bug-Url: https://bugzilla.redhat.com/1283062 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ObjectCompensation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContextBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolDecorator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDcTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ReleaseMacsTransientCompensation.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientCompensationBusinessEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientEntityType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java 34 files changed, 973 insertions(+), 168 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbd4967ca53403b03454b22a74f7d0f632104fc4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in creating a VM Cinder disk
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in creating a VM Cinder disk ...................................................................... core: Fix error in creating a VM Cinder disk Change-Id: I09be19d8089cef10e2f6283adb5dd65aa097da8d Bug-Url: https://bugzilla.redhat.com/1339300 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09be19d8089cef10e2f6283adb5dd65aa097da8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in importing a VM as a clone
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in importing a VM as a clone ...................................................................... core: Fix error in importing a VM as a clone Change-Id: Ife65f0c41a5d82e85421311e6d9b3b210096aafb Bug-Url: https://bugzilla.redhat.com/1339236 Bug-Url: https://bugzilla.redhat.com/1338526 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife65f0c41a5d82e85421311e6d9b3b210096aafb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Refresh with gerrit local modifications
by dcaro＠redhat.com 25 May '16

25 May '16

David Caro has submitted this change and it was merged. Change subject: Refresh with gerrit local modifications ...................................................................... Refresh with gerrit local modifications Change-Id: Ic295d64884809383be13ecf0e57c84118eec4e65 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED M hooks/custom_hooks/patchset-created.bz.2.correct_product M hooks/custom_hooks/update_tracker 3 files changed, 25 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic295d64884809383be13ecf0e57c84118eec4e65 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0