May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com 19 May '16

19 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number and sets the RPM relase number to 0.1. Change-Id: I1c122a4105f2f9a26ff24c39b7355e0ed2f00301 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c122a4105f2f9a26ff24c39b7355e0ed2f00301 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Release 3.6.5.1
by juan.hernandez＠redhat.com 19 May '16

19 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.6.5.1 ...................................................................... sdk: Release 3.6.5.1 Change-Id: Ida2d910acf6016f8c1868999795b1202a032311a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida2d910acf6016f8c1868999795b1202a032311a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: linux: Default flush caches hook for the guest agent
by vfeenstr＠redhat.com 19 May '16

19 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: linux: Default flush caches hook for the guest agent ...................................................................... linux: Default flush caches hook for the guest agent This patch adds a script to flush cache buffers of linux systems. This script will now be installed as a default hook before migrations and hibernations to allow faster migrations / hibernations. Since this script needs root permissions to function, the necessary elevation scripts have been added. Change-Id: Iccf6708cd40843884571d2ed9ccf1e420b13cc0f Bug-Url: https://bugzilla.redhat.com/1298120 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- A hooks/55-flush-caches.consolehelper A hooks/55-flush-caches.sudo M hooks/Makefile.am A hooks/flush-caches M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/consoleapps/Makefile.am A ovirt-guest-agent/consoleapps/ovirt-flush-caches M ovirt-guest-agent/pam/Makefile.am A ovirt-guest-agent/pam/ovirt-flush-caches M scripts/sudoers.ovirt-guest-agent M scripts/wrappers/Makefile.am A scripts/wrappers/ovirt-flush-caches-wrapper.sh 13 files changed, 103 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccf6708cd40843884571d2ed9ccf1e420b13cc0f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move disks storage existence check to DiskImagesValidator
by laravot＠redhat.com 19 May '16

19 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: move disks storage existence check to DiskImagesValidator ...................................................................... core: move disks storage existence check to DiskImagesValidator We check in multiple places whether disks exists on the storage domains by getting the list of the images on the storage domain. This patch moves the check to DiskImagesValidator and removes the duplicacy between ExportVmTemplateCommand and ImportValidator. Change-Id: I1427b3531dafc6dcb64001c4755b4e7276007682 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 49 insertions(+), 60 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1427b3531dafc6dcb64001c4755b4e7276007682 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: linux: Add atomic host awareness to container-list
by vfeenstr＠redhat.com 19 May '16

19 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: linux: Add atomic host awareness to container-list ...................................................................... linux: Add atomic host awareness to container-list For the container list script it is necessary that it becomes aware of being in a container and correspondingly tries to use the /host prefix for the docker socket path if it inside a container Change-Id: I63b95320674ee52fd8a4c8bb2328c39e24b5e2d1 Bug-Url: https://bugzilla.redhat.com/1273399 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M scripts/container-list 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63b95320674ee52fd8a4c8bb2328c39e24b5e2d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: Support for reporting active docker containers
by vfeenstr＠redhat.com 19 May '16

19 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Support for reporting active docker containers ...................................................................... Support for reporting active docker containers With this patch we'll be able to report active docker containers running on a VM. If there are no containers, the reported list would be empty. The reported data is a list of objects with the following fields: - id: Docker Container ID - names: List of aliases for the running container - image: Name of the running image - cmd: The command the container was started with - status: The status message of the container Change-Id: Iaeab78cdab55ba9a525479a1785c2c1e4730a862 Guest-Agent-API-Version: 3 Bug-Url: https://bugzilla.redhat.com/1273399 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/consoleapps/Makefile.am A ovirt-guest-agent/consoleapps/ovirt-container-list M ovirt-guest-agent/pam/Makefile.am A ovirt-guest-agent/pam/ovirt-container-list M scripts/Makefile.am A scripts/container-list M scripts/sudoers.ovirt-guest-agent M scripts/wrappers/Makefile.am A scripts/wrappers/ovirt-container-list-wrapper.sh M tests/guest_agent_test.py M tests/message_validator.py 16 files changed, 203 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeab78cdab55ba9a525479a1785c2c1e4730a862 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Avoid NPE when there is no href
by juan.hernandez＠redhat.com 19 May '16

19 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Avoid NPE when there is no href ...................................................................... restapi: Avoid NPE when there is no href Currently when an entity is created but it doesn't have an "href" attribute an NPE is generated. This patch changes the API so that the NPE is avoided. Change-Id: I6ccb473f678c247108238a05efc7af776a10f48e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ccb473f678c247108238a05efc7af776a10f48e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix coverity warnings
by alkaplan＠redhat.com 19 May '16

19 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix coverity warnings ...................................................................... engine: fix coverity warnings The patch fixes the following Coverity warnings: * CID 1355030 - Dereference of an explicit null value * CID 1355031 - Dereference of an explicit null value Also it adds test coverage for getIpv[46]AddressOfNetwork methods. Change-Id: I2fa38b889cb97b41a9e34e646c39903273a1128e Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java 1 file changed, 49 insertions(+), 17 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/57112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fa38b889cb97b41a9e34e646c39903273a1128e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetAllServerCpuList changed to user query
by ahadas＠redhat.com 19 May '16

19 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: GetAllServerCpuList changed to user query ...................................................................... core: GetAllServerCpuList changed to user query ... to be able to call it from user portal. It's required by AsyncDataProvider#initCpuMap method that is shared between webadmin and userportal. Currently userportal throws an exception during its load. Change-Id: Ifb81b8707403184d3efbb0c3265bcd238c1ab184 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb81b8707403184d3efbb0c3265bcd238c1ab184 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: Implementation for guest agent hook points
by vfeenstr＠redhat.com 19 May '16

19 May '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Implementation for guest agent hook points ...................................................................... Implementation for guest agent hook points This patch introduces the ability of the guest agent to handle lifecycle events and executes hooks which are configured for the given event. Change-Id: I77dc3278c28e3f156c54a1db653744c127bd1c3f Bug-Url: https://bugzilla.redhat.com/1298120 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M Makefile.am M configure.ac A hooks/Makefile.am M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/OVirtGuestService.py A ovirt-guest-agent/hooks.py 11 files changed, 157 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77dc3278c28e3f156c54a1db653744c127bd1c3f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0