May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix error message when unautherized access providers
by masayag＠redhat.com 10 May '16

10 May '16

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: fix error message when unautherized access providers ...................................................................... webadmin: fix error message when unautherized access providers Fix calling the translation twice on the validation messages which caused a disrapted message to appear. Change-Id: I0b88d146d5e7fe6cc4bbd88b9a403712a39fb489 Bug-Url: https://bugzilla.redhat.com/1303694 Signed-off-by: borod108 <bodnopoz(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Boris Odnopozov: Verified Daniel Erez: Looks good to me, approved Moti Asayag: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/57245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b88d146d5e7fe6cc4bbd88b9a403712a39fb489 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: change logic of validation of power management
by masayag＠redhat.com 10 May '16

10 May '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: change logic of validation of power management ...................................................................... engine: change logic of validation of power management This patch changes logic of validation of power management as follows: PM parameters are valid if: * user don't have pm enabled and fence agents are null. * user has pm enabled and send valid non-empty list of fence agents PM parameters aren't valid if: * user has pm enabled and send empty list of fence agents Change-Id: Ib7991fccfa544153c376707fb8b46abed8c77692 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1330209 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 12 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7991fccfa544153c376707fb8b46abed8c77692 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use system wide CA certificates by default
by juan.hernandez＠redhat.com 10 May '16

10 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: Use system wide CA certificates by default ...................................................................... Use system wide CA certificates by default This patch changes the SDK so that when TLS is enabled and no CA certificate file is explicitly provided, it will use the system wide CA certificates. Change-Id: Ib93e46bb4343071f7567e1d95980c4c9f9a0039c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc M sdk/lib/ovirtsdk4/http.rb M sdk/spec/connection_create_spec.rb 3 files changed, 11 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93e46bb4343071f7567e1d95980c4c9f9a0039c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adding type to OpenstackNetworkProvider
by juan.hernandez＠redhat.com 10 May '16

10 May '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Adding type to OpenstackNetworkProvider ...................................................................... restapi: Adding type to OpenstackNetworkProvider Change-Id: If6c861016195af28b5986adf7127a6432f40c6c2 Bug-Url: https://bugzilla.redhat.com/1314375 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProviderResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProvidersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackNetworkProviderMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackNetworkProviderMapperTest.java 4 files changed, 33 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6c861016195af28b5986adf7127a6432f40c6c2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: send all graphics device attrs as specParams
by ahadas＠redhat.com 10 May '16

10 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: send all graphics device attrs as specParams ...................................................................... core: send all graphics device attrs as specParams If Vdsm receives a graphic device, it doesn't look for global parameters, and checks only the device specParams. This patch makes sure we fill the specParams correctly, and that we don't send parameters in the global configuration anymore. This is safe because we already dropped compatibility with <= 3.4 Engines. Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Bug-Url: https://bugzilla.redhat.com/1331333 Backport-To: 3.6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 3 files changed, 28 insertions(+), 38 deletions(-) Approvals: Francesco Romani: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: added migration policies to engine-config
by tjelinek＠redhat.com 10 May '16

10 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: tools: added migration policies to engine-config ...................................................................... tools: added migration policies to engine-config Added a possibility to configure the migration policies using engine config. The dependency to jackson is there to make sure the provided policy is valid and also to give an example policy. Change-Id: I2f84034348b0af963cc63dd1cb2470d9b45c28c8 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MigrationPoliciesValueHelper.java M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MigrationPoliciesValueHelperTest.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 86 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f84034348b0af963cc63dd1cb2470d9b45c28c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in jenkins[master]: std ci: increase limit of parallel runs to 6
by eedri＠redhat.com 10 May '16

10 May '16

Eyal Edri has submitted this change and it was merged. Change subject: std ci: increase limit of parallel runs to 6 ...................................................................... std ci: increase limit of parallel runs to 6 - so far we let only 3 instances of a job to run in parallel on different slaves. This creates a status of idle slaves for no apparent reason since there is no real problem in utilizing all slaves to run more instances of the same job. This patch increase the amount to 6 (double), but we might increase it even more if we see the need and we have the resources for it. Change-Id: I755d1351ac6a7d579fc8e455fa4453283f35e9c4 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/templates/standard-stage.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/57306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I755d1351ac6a7d579fc8e455fa4453283f35e9c4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: rename: Fix SSO client callback prefix on engine ...
by sbonazzo＠redhat.com 10 May '16

10 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: Fix SSO client callback prefix on engine rename ...................................................................... packaging: rename: Fix SSO client callback prefix on engine rename Fix SSO client callback prefix after ovirt engine rename. ovirt-engine-rename needs to update the database to change the client callback prefix for SSO with the new engine fqdn. Change-Id: Ib8411eb1a2a188991aeea0f09472093aac716945 Bug-Url: https://bugzilla.redhat.com/1330168 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/sso_clients_sp.sql M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/__init__.py A packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 4 files changed, 91 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8411eb1a2a188991aeea0f09472093aac716945 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Allow choosing scale
by Shirly Radco 10 May '16

10 May '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Allow choosing scale ...................................................................... packaging: setup: Allow choosing scale Change-Id: I8e399cd3a9d9e2730b1e2e5f750308b8ac5eccb6 Bug-Url: https://bugzilla.redhat.com/1328805 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/scale.py 3 files changed, 165 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/57238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e399cd3a9d9e2730b1e2e5f750308b8ac5eccb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Copy db creds to engine
by Shirly Radco 10 May '16

10 May '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Copy db creds to engine ...................................................................... packaging: setup: Copy db creds to engine Bug-Url: https://bugzilla.redhat.com/1318665 Change-Id: Ie4a4c7e08015f5c6f60bb9e39724f46274671754 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/config.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/remote_engine.py 4 files changed, 223 insertions(+), 90 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4a4c7e08015f5c6f60bb9e39724f46274671754 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0