Change in ovirt-engine[ovirt-engine-3.6]: vdsbroker: timeout ping command when no response
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: vdsbroker: timeout ping command when no response
......................................................................
vdsbroker: timeout ping command when no response
During setup networks ping command is sent to confirm that reconfigured
network works properly. Sometimes there is no response due to short
network interruption so we need to timeout.
Change-Id: I26c1bc107936231757c1d035eb96fdec5c638f0d
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1329317
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M ovirt-engine.spec.in
M pom.xml
5 files changed, 25 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Pavel Zhukov: Verified
--
To view, visit https://gerrit.ovirt.org/57097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c1bc107936231757c1d035eb96fdec5c638f0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: vdsbroker: timeout ping command when no response
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: vdsbroker: timeout ping command when no response
......................................................................
vdsbroker: timeout ping command when no response
During setup networks ping command is sent to confirm that reconfigured
network works properly. Sometimes there is no response due to short
network interruption so we need to timeout.
Change-Id: I26c1bc107936231757c1d035eb96fdec5c638f0d
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M ovirt-engine.spec.in
M pom.xml
5 files changed, 24 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Passed CI tests
Alona Kaplan: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c1bc107936231757c1d035eb96fdec5c638f0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: remove unused 'GetMinimalSupportedVersionByNetworkFi...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: remove unused 'GetMinimalSupportedVersionByNetworkFilterName'
......................................................................
engine: remove unused 'GetMinimalSupportedVersionByNetworkFilterName'
Change-Id: I0586755689b3cab0a5374b0dd6b31541dfb3d017
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMinimalSupportedVersionByNetworkFilterNameQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoTest.java
M packaging/dbscripts/network_sp.sql
6 files changed, 0 insertions(+), 65 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0586755689b3cab0a5374b0dd6b31541dfb3d017
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: adding 'network filter id' to add/edit vnic profil...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: adding 'network filter id' to add/edit vnic profile and table
......................................................................
webadmin: adding 'network filter id' to add/edit vnic profile and table
Change-Id: Id69dfcb6cf7fec92927c7a8157ab153391b7ff06
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkFilter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/NetworkFilterRenderer.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java
13 files changed, 126 insertions(+), 1 deletion(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id69dfcb6cf7fec92927c7a8157ab153391b7ff06
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: show the inherited permissions also for the VM
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: show the inherited permissions also for the VM
......................................................................
webadmin: show the inherited permissions also for the VM
It has been explicitely turned off for VMs, but since there is a sortable
"inherited permissions" column, it makes sense to enable it again.
Change-Id: I6dd5774046891c6c17a337c05d601e1c164369f4
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dd5774046891c6c17a337c05d601e1c164369f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.6 rc2
by lveyde＠redhat.com
Lev Veyde has submitted this change and it was merged.
Change subject: oVirt Live 3.6.6 rc2
......................................................................
oVirt Live 3.6.6 rc2
Change-Id: I2ba03060fded25dffe6967cfc1c180a20b81ce75
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
Sandro Bonazzola: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ba03060fded25dffe6967cfc1c180a20b81ce75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: Adding 'network_filter_name' to vnic_profile_view
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adding 'network_filter_name' to vnic_profile_view
......................................................................
engine: Adding 'network_filter_name' to vnic_profile_view
Change-Id: I396cb6216922a9683ada2ce929d4594d203d33ae
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfileView.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileViewDaoImpl.java
M packaging/dbscripts/create_views.sql
3 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57041
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I396cb6216922a9683ada2ce929d4594d203d33ae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: rest+engine: add default network filter id
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: rest+engine: add default network filter id
......................................................................
rest+engine: add default network filter id
In case 'useDefaultNetworkFiterId' is true and
'EnableMACAntiSpoofingFilterRules' is enabled,
'NetworkFilter.VDSM_NO_MAC_SPOOFING' should be used.
Change-Id: I35413ef4a8857ef824190cd10d156595baddc0be
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVnicProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkFilter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
10 files changed, 91 insertions(+), 15 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35413ef4a8857ef824190cd10d156595baddc0be
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: add network filter id validation
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add network filter id validation
......................................................................
engine: add network filter id validation
1. Verify the 'id' exist in the 'network_filter' table.
2. Verify the 'id' is 'null' in case the 'default' flag is 'true'.
Change-Id: Idde5f98caa72704a5f4c116afe691ebe5d5d7c8c
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkFilter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 127 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52832
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idde5f98caa72704a5f4c116afe691ebe5d5d7c8c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
