June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: test external provider failed when not selection dat...
by shavivi＠redhat.com 21 Jun '16

21 Jun '16

Shahar Havivi has submitted this change and it was merged. Change subject: engine: test external provider failed when not selection data-center ...................................................................... engine: test external provider failed when not selection data-center if user select any datacenter (ie the datacenter is null) we need to select arbitrary datacenter. Bug-Url: https://bugzilla.redhat.com/1293591 Change-Id: I9a40ff28a5a1e3466939ec13ab2e9ee6557c34d1 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a40ff28a5a1e3466939ec13ab2e9ee6557c34d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: Fix pkg typo
by fabiand＠redhat.com 20 Jun '16

20 Jun '16

Fabian Deutsch has submitted this change and it was merged. Change subject: node: Fix pkg typo ...................................................................... node: Fix pkg typo Change-Id: I1ed1028047b69d62743733efb06d2be5b1412f39 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed1028047b69d62743733efb06d2be5b1412f39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: add requirement for vdsm hook fcoe
by fabiand＠redhat.com 20 Jun '16

20 Jun '16

Fabian Deutsch has submitted this change and it was merged. Change subject: node: add requirement for vdsm hook fcoe ...................................................................... node: add requirement for vdsm hook fcoe Change-Id: Ic9c14a7f47ee7d8728a36fff5294f567f0a24005 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347588 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests Douglas Schilling Landgraf: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9c14a7f47ee7d8728a36fff5294f567f0a24005 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: Fix pkg typo
by fabiand＠redhat.com 20 Jun '16

20 Jun '16

Fabian Deutsch has submitted this change and it was merged. Change subject: node: Fix pkg typo ...................................................................... node: Fix pkg typo Change-Id: I1ed1028047b69d62743733efb06d2be5b1412f39 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed1028047b69d62743733efb06d2be5b1412f39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use BusinessEntitySnapshotDao directly in Backend
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: use BusinessEntitySnapshotDao directly in Backend ...................................................................... core: use BusinessEntitySnapshotDao directly in Backend * Use BusinessEntitySnapshotDao in Backend directly rather then through DbFacade. * Make Bakend.compensate method non-static. Change-Id: I69514bb8c9ba7db77701233beed64d3ffeb33eb7 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69514bb8c9ba7db77701233beed64d3ffeb33eb7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: make Backend.initialize private
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: make Backend.initialize private ...................................................................... core: make Backend.initialize private * make Backend.initialize private - no way it has to be visible outside the class. * remove the method from the interface. Change-Id: I366a339192e4e10d8fe03190fa340a810c5478a1 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366a339192e4e10d8fe03190fa340a810c5478a1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract SystemStatisticsDao out of DbFacade
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: extract SystemStatisticsDao out of DbFacade ...................................................................... core: extract SystemStatisticsDao out of DbFacade Change-Id: I363b6c369a14fe01233e5b0c846e953416d91ede Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SystemStatisticsDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SystemStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SystemStatisticsDaoImplTest.java 6 files changed, 109 insertions(+), 50 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363b6c369a14fe01233e5b0c846e953416d91ede Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move DbFacadeDaoTest to the package of its under-test
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: move DbFacadeDaoTest to the package of its under-test ...................................................................... core: move DbFacadeDaoTest to the package of its under-test Change-Id: I9e7f9a2e44a610052d242217d28542d7030d9fa9 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java R backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeDaoTest.java 2 files changed, 4 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e7f9a2e44a610052d242217d28542d7030d9fa9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DbFacade.getInstance deprecation
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: DbFacade.getInstance deprecation ...................................................................... core: DbFacade.getInstance deprecation Change-Id: I4de2642fce18c2241f54369ee71567cb510530ee Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4de2642fce18c2241f54369ee71567cb510530ee Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract DbConnectionUtil out of DbFacade
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: extract DbConnectionUtil out of DbFacade ...................................................................... core: extract DbConnectionUtil out of DbFacade Change-Id: I5f3f3c13bea88653280fe00ca9c16e7221f94192 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java M backend/manager/modules/dal/pom.xml A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbConnectionUtil.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/DbConnectionUtilTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeDaoTest.java 8 files changed, 160 insertions(+), 121 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f3f3c13bea88653280fe00ca9c16e7221f94192 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0