June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: 403 returned when console can't be stolen
by juan.hernandez＠redhat.com 21 Jun '16

21 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: 403 returned when console can't be stolen ...................................................................... restapi: 403 returned when console can't be stolen HTTP status code changed from 500 to 403 when user asks for vv file and the console is already assigned to other user and user don't have sufficient permissions to steal the console. The reason is to indicate that it's not a server problem but rather permission/state issue. Change-Id: I72a9c9e0e84f8ca5253eb09cb447b88a4f55d4ce Bug-Url: https://bugzilla.redhat.com/1305600 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72a9c9e0e84f8ca5253eb09cb447b88a4f55d4ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ovirt-engine-notifier : Add support for SNMPv3 traps
by mperina＠redhat.com 21 Jun '16

21 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: ovirt-engine-notifier : Add support for SNMPv3 traps ...................................................................... ovirt-engine-notifier : Add support for SNMPv3 traps Add support to send SNMPv3 traps from ovirt-engine-notification service. New config variables SNMP_VERSION, SNMP_ENGINE_ID, SNMP_USERNAME, SNMP_AUTH_PASSPHRASE, SNMP_PRIVACY_PASSPHRASE, SNMP_SECURITY_LEVEL, SNMP_AUTH_PROTOCOL and SNMP_PRIVACY_PROTOCOL can be configured to send SNMPv3 traps. net-snmp supports MD5 and SHA auth protocols and AES128 privacy protocol. Change-Id: I5a47f16eaf1d5461f223d514383a26f5696ba255 Bug-Url: https://bugzilla.redhat.com/1268133 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dependencies/common/src/main/modules/org/snmp4j/main/module.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 4 files changed, 292 insertions(+), 61 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a47f16eaf1d5461f223d514383a26f5696ba255 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in otopi[master]: machine_dialog: fix the comparison for default
by didi＠redhat.com 21 Jun '16

21 Jun '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: machine_dialog: fix the comparison for default ...................................................................... machine_dialog: fix the comparison for default Currently, it evaluates to False even if no values is set. Set "default" to None so the comparison works properly. Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346860 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/plugins/otopi/dialog/machine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests Ryan Barry: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: cluster scheduling policy layout
by awels＠redhat.com 21 Jun '16

21 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: cluster scheduling policy layout ...................................................................... webadmin: cluster scheduling policy layout - Fixed issue where the properties editor of the scheduling policy was having issues laying out the fields consistently. - Updated new vnic profile to have boostrap layout (and fix same properties editor layout issues) - Updated NetworkAttachmentPopupView to have boostrap layout. - Updated HostNetworkQosWidget to have boostrap layout. Change-Id: Ia7902d43f694e75ce7eb650c13df30e5c04e8ddd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267259 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NetworkAttachmentPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NetworkAttachmentPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.ui.xml 15 files changed, 343 insertions(+), 355 deletions(-) Approvals: Alexander Wels: Verified Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7902d43f694e75ce7eb650c13df30e5c04e8ddd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Restore DataCenter#macPool
by juan.hernandez＠redhat.com 21 Jun '16

21 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Restore DataCenter#macPool ...................................................................... restapi: Restore DataCenter#macPool The `macPool` attribute of the `DataCenter` type was removed because it was going to be replaced by the `macPool` attribute of the `Cluster` type, but that change wasn't finally introduced in the initial release of version 4 fo the engine, so the original attribute needs to be re-introduced in order to preserve support for MAC pools. Change-Id: I17fe6fbc95e77b997bdb914f315664304eac3edc Bug-Url: https://bugzilla.redhat.com/1344284 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterOutAdapter.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17fe6fbc95e77b997bdb914f315664304eac3edc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Drop otopi_create-rpms on master
by sbonazzo＠redhat.com 21 Jun '16

21 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Drop otopi_create-rpms on master ...................................................................... Drop otopi_create-rpms on master Standard CI jobs of otopi on master/1.5 are currently enough. Keep 3.6 jobs for now. Change-Id: I64eca2ccd3b8b59f522c5c359d78937ea5d7c7b1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/otopi/otopi_create-rpms.yaml 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64eca2ccd3b8b59f522c5c359d78937ea5d7c7b1 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: ConnectStoragePoolVDSCommand - merging declartion...
by laravot＠redhat.com 21 Jun '16

21 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: ConnectStoragePoolVDSCommand - merging declartion/assignment ...................................................................... vdsbroker: ConnectStoragePoolVDSCommand - merging declartion/assignment storageDomains is declared and immediately assigned, this patch merges those statements. Change-Id: I285b48a446365457056fa1bdfd9aba9e388b0813 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I285b48a446365457056fa1bdfd9aba9e388b0813 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: dropped all history database foreign keys
by Shirly Radco 21 Jun '16

21 Jun '16

Shirly Radco has submitted this change and it was merged. Change subject: history: dropped all history database foreign keys ...................................................................... history: dropped all history database foreign keys Dropped all history database foreign keys for better etl write performance. Change-Id: I59311b930e033f2f6a9a9f2b6b5b48efca5c7371 Bug-Url: https://bugzilla.redhat.com/1347281 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0040_drop_all_history_db_foreign_keys.sql 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59311b930e033f2f6a9a9f2b6b5b48efca5c7371 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix db upgrade error during engine-setup
by sbonazzo＠redhat.com 21 Jun '16

21 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Fix db upgrade error during engine-setup ...................................................................... core: Fix db upgrade error during engine-setup Fixes database upgrade error Trying to upgrade from unsupported versions: 4.1 which was raised during engine-setup upgrade from 4.1 to 4.1 versions. Change-Id: Icadf7daa9c4351cbece3795102ce0aa30375e4bd Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icadf7daa9c4351cbece3795102ce0aa30375e4bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Load valid configuration for all arquillian tests
by mperina＠redhat.com 21 Jun '16

21 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Load valid configuration for all arquillian tests ...................................................................... core: Load valid configuration for all arquillian tests Make sure that the default config is loaded from the database and that a valid minimal oVirt configuration file is supplied to arquillian Change-Id: Ief0bd1ea4f86ff99fc4addd16f8aec11b005910f Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/TransactionalTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java M backend/manager/modules/bll/src/test/resources/engine.conf.defaults 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0bd1ea4f86ff99fc4addd16f8aec11b005910f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0