Change in ovirt-engine[master]: core: Improve transaction handling in arquillian based tests
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Improve transaction handling in arquillian based tests
......................................................................
core: Improve transaction handling in arquillian based tests
Remove Arquillian rules dependency and implement a cleaner automatic rollback mechanism.
Change-Id: I4b18b23ed19d4d6d6ec66f2c4868a51d5278a23d
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/TransactionalTestBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/ArquillianRule.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/ArquillianRuleExecutor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/ArquillianRuleExtension.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/MockTransactionManagerRule.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/RollbackRule.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/TransactionRollbackRule.java
A backend/manager/modules/bll/src/test/resources/META-INF/services/org.jboss.arquillian.core.spi.LoadableExtension
M backend/manager/modules/pom.xml
9 files changed, 115 insertions(+), 53 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b18b23ed19d4d6d6ec66f2c4868a51d5278a23d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Let entity builders return a fresh loaded entity from ...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Let entity builders return a fresh loaded entity from the database
......................................................................
core: Let entity builders return a fresh loaded entity from the database
Instead of returning the builder template on a #persist() call make sure
that a new entity - fresh from the database - is returned. This makes
the returned instance much more useful for tests.
Change-Id: I48d6290d886f23b62b0a50e38b10d10526f179b5
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/ClusterBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/MacPoolBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VdsBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VmBuilder.java
4 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48d6290d886f23b62b0a50e38b10d10526f179b5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Remove completely the 'capabilities' collection
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove completely the 'capabilities' collection
......................................................................
restapi: Remove completely the 'capabilities' collection
In version 4 of the API the top level 'capabilities' collection was
removed, and replaced by the new 'clusterlevels' collection. This patch
completes the cleanup, removing all the code that was used to implement
the 'capabilities' collection.
Change-Id: Ic2176623fe97971ae3848c4cfadd8b167201dc70
Bug-Url: https://bugzilla.redhat.com/1347157
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabilitiesResource.java
D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabiliyResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java
10 files changed, 2 insertions(+), 3,146 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2176623fe97971ae3848c4cfadd8b167201dc70
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Add cluster levels support
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add cluster levels support
......................................................................
restapi: Add cluster levels support
The top level 'capabilities' collection has been replaced by the new
'clusterlevels' collection. This new collection will contain the
information that isn't available in the model, like the list of CPU
types available for each cluster level:
GET /clusterlevels
This will return a list of `ClusterLevel` objects containing the details
for all the cluster levels supported by the system:
<cluster_levels>
<cluster_level id="3.6" href="/clusterlevels/3.6">
<cpu_types>
<cpu_type>
<name>Intel Conroe Family</name>
<level>2</level>
<architecture>x86_64</architecture>
</cpu_type>
...
</cpu_types>
...
</cluster_level>
</cluster_levels>
Each specific cluster level has it's own subresource, identified by the
version itself:
GET /clusterlevels/3.6
This will return the details of that version:
<cluster_level id="3.6" href="/clusterlevels/3.6">
<cpu_types>
<cpu_type>
<name>Intel Conroe Family</name>
<level>2</level>
<architecture>x86_64</architecture>
</cpu_type>
...
</cpu_types>
...
</cluster_level>
Change-Id: Ifcd16aa01e2e8e959fdd25977e21b154e949d934
Bug-Url: https://bugzilla.redhat.com/1347157
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.adoc
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ApiOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
8 files changed, 205 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59227
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcd16aa01e2e8e959fdd25977e21b154e949d934
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Update to model 4.1.0
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.0
......................................................................
restapi: Update to model 4.1.0
The more relevant changes in this new version of the model are the
following:
* Add `Update` method to the `DiskAttachment` service.
* Add types and services for cluster levels support.
Change-Id: I8b1b5bd357d64292cdc4c87904a477bfacb1e81a
Related-To: https://bugzilla.redhat.com/1347157
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java
M pom.xml
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59542
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b1b5bd357d64292cdc4c87904a477bfacb1e81a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: vdsbroker: ConnectStoragePool - log the passed domains map
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: vdsbroker: ConnectStoragePool - log the passed domains map
......................................................................
vdsbroker: ConnectStoragePool - log the passed domains map
This patch prints the passed domains map when executing ConnectStoragePool
for easier debugging.
Change-Id: I68cd07570432d1a04bb6ae025c1c165fe9719e11
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68cd07570432d1a04bb6ae025c1c165fe9719e11
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live 4.0.0_rc3
by lveyde＠redhat.com
Lev Veyde has submitted this change and it was merged.
Change subject: build: ovirt-live 4.0.0_rc3
......................................................................
build: ovirt-live 4.0.0_rc3
Change-Id: Ib4e1ad027506b31e9b109b2fd65c48d48b78e517
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4e1ad027506b31e9b109b2fd65c48d48b78e517
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[ovirt-live-3.6]: build: oVirt Live 3.6.7_rc5
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: oVirt Live 3.6.7_rc5
......................................................................
build: oVirt Live 3.6.7_rc5
Change-Id: Ic9ffc6f988e50dbc2d20ff702503a3951169731f
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ffc6f988e50dbc2d20ff702503a3951169731f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: ImportRepoImage CoCo refactor
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: engine: ImportRepoImage CoCo refactor
......................................................................
engine: ImportRepoImage CoCo refactor
Use CoCo in ImportRepoImage instead of SEAT.
Add a new command DownloadImageCommand.
Use AddDiskCommand instead of CreateImageFromScratch.
Implements the flow in CoCo as SerialChildExecutingCommand.
Change-Id: I6df31d055232295da20beacea1e026b1307fbc80
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AbstractSPMAsyncTaskHandler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DownloadImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCreateTaskHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DownloadImageCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportRepoImageParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
11 files changed, 306 insertions(+), 467 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6df31d055232295da20beacea1e026b1307fbc80
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: vdsbroker: reduce log level for timeout exception stack trace
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: vdsbroker: reduce log level for timeout exception stack trace
......................................................................
vdsbroker: reduce log level for timeout exception stack trace
Change-Id: Ie4b8ceae32ce34a04f7173e9f9db37c31df6202a
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4b8ceae32ce34a04f7173e9f9db37c31df6202a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months