Change in ovirt-engine[ovirt-engine-3.6]: core: Remove redundant else
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Remove redundant else
......................................................................
core: Remove redundant else
Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Remove redundant else when calling registerOvfStoreDisks
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Remove redundant else when calling registerOvfStoreDisks
......................................................................
core: Remove redundant else when calling registerOvfStoreDisks
Since a false result will cause throwing new exception there is no
reason to keep the else in the if statement.
Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Remove redundant else
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Remove redundant else
......................................................................
core: Remove redundant else
Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59263
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Connect all hosts on adding storage pool.
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Connect all hosts on adding storage pool.
......................................................................
core: Connect all hosts on adding storage pool.
Once we create a storage pool with multiple hosts, we connect the first
host to all the storage domains and create a storage pool.
After the create succeeded, the flow continues, and tries to fetch
all the unregistered disks before all the hosts in the Data Center
are connected to all the storage domains.
As part of the query of getting the unregistered disks, the engine uses
the getImagesList query.
This vds command uses IrsProxyData which executes
ConnectStoragePoolVDSCommand, and the host that execute this method uses
a random host which might not be connected.
To avoid this problem, once we have a host which successfully created a
storage pool we keep connect all the rest of the storage domains since
they are already being connected when getting activated.
Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59264
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Remove redundant else when calling registerOvfStoreDisks
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Remove redundant else when calling registerOvfStoreDisks
......................................................................
core: Remove redundant else when calling registerOvfStoreDisks
Since a false result will cause throwing new exception there is no
reason to keep the else in the if statement.
Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a
Bug-Url: https://bugzilla.redhat.com/1344314
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59265
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Query VMs list on CREATED_BY_USER_ID
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Query VMs list on CREATED_BY_USER_ID
......................................................................
core: Query VMs list on CREATED_BY_USER_ID
The VMs List can be queried on the CREATED_BY_USER_ID condition in REST, i.e.:
.../api/vms?search=created_by_user_id%3D[USER_ID]
The Webadmin's VM General Subtab shows user name/login of the VM creator.
Change-Id: I2a5f9a1f30150687d9c628f4d94f02a4473ebb1b
Bug-Url: https://bugzilla.redhat.com/1161625
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
7 files changed, 75 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Marek Libra: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a5f9a1f30150687d9c628f4d94f02a4473ebb1b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in jenkins[master]: added workspace cleanup to all {project}_{version}_create-rp...
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: added workspace cleanup to all {project}_{version}_create-rpms-{distro}-{arch}_{trigger} jobs
......................................................................
added workspace cleanup to all {project}_{version}_create-rpms-{distro}-{arch}_{trigger} jobs
Actually created a new defaults named create-rpms
to all create-rpms jobs and overriden the global
defaults with that create-rpms defaults
Change-Id: I87434963ac4625950d2683de0c8e0bac6cdaba2d
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/projects/defaults.yaml
M jobs/confs/yaml/templates/create-rpms_mock.yaml
2 files changed, 33 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Ready for merge
Gil Shinar: Verified
Jenkins CI: Passed CI tests
David Caro: Looks good to me
--
To view, visit https://gerrit.ovirt.org/54728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87434963ac4625950d2683de0c8e0bac6cdaba2d
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Use indexes before string format
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Use indexes before string format
......................................................................
aaa: Use indexes before string format
Localization may change the order of
string locations for some languages.
Use indexes for string format instead of
simple string format.
Change-Id: I7d4749735dad775e20c062a2f5627cef87bbee20
Bug-Url: https://bugzilla.redhat.com/1347148
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit bb10ba19fcf69fe0e0c403011aff9d697aca274a)
---
M backend/manager/modules/enginesso/src/main/resources/AppMessages.properties
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59297
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d4749735dad775e20c062a2f5627cef87bbee20
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: aaa: Use indexes before string format
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Use indexes before string format
......................................................................
aaa: Use indexes before string format
Localization may change the order of
string locations for some languages.
Use indexes for string format instead of
simple string format.
Change-Id: I7d4749735dad775e20c062a2f5627cef87bbee20
Bug-Url: https://bugzilla.redhat.com/1347148
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/resources/AppMessages.properties
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d4749735dad775e20c062a2f5627cef87bbee20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: aaa: Failed to execute login on behalf - for user admin.
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Failed to execute login on behalf - for user admin.
......................................................................
aaa: Failed to execute login on behalf - for user admin.
LoginOnBehalf needs to query user by id.
The SSO directory query needs to be a public
query to facilitate LoginOnBehalf.
Change-Id: Ib5bae00e5ab9ec05147487b916e8c4b36c3b81fa
Bug-Url: https://bugzilla.redhat.com/1344272
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
4 files changed, 24 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5bae00e5ab9ec05147487b916e8c4b36c3b81fa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months