June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Use interface and boot values in old API if provided
by tnisan＠redhat.com 15 Jun '16

15 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Use interface and boot values in old API if provided ...................................................................... restapi: Use interface and boot values in old API if provided Since the model currently still contains the boot and interface properties use them in old VM disk creation API calls (/vms/{vm_id}/disks). Bug-Url: https://bugzilla.redhat.com/1346752 Change-Id: I0eb512740f53fc09222adb48a26afb0731797427 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eb512740f53fc09222adb48a26afb0731797427 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Use existing DiskAttachment entity when editing a V...
by tnisan＠redhat.com 15 Jun '16

15 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Use existing DiskAttachment entity when editing a VM disk ...................................................................... restapi: Use existing DiskAttachment entity when editing a VM disk Change-Id: Ia9b440c4e3561129d93bd3622091026a48cd0950 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1346752 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b440c4e3561129d93bd3622091026a48cd0950 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Use interface and boot values in old API if provided
by tnisan＠redhat.com 15 Jun '16

15 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Use interface and boot values in old API if provided ...................................................................... restapi: Use interface and boot values in old API if provided Since the model currently still contains the boot and interface properties use them in old VM disk creation API calls (/vms/{vm_id}/disks). Bug-Url: https://bugzilla.redhat.com/1346752 Change-Id: I0eb512740f53fc09222adb48a26afb0731797427 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eb512740f53fc09222adb48a26afb0731797427 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use existing DiskAttachment entity when editing a V...
by tnisan＠redhat.com 15 Jun '16

15 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Use existing DiskAttachment entity when editing a VM disk ...................................................................... restapi: Use existing DiskAttachment entity when editing a VM disk Change-Id: Ia9b440c4e3561129d93bd3622091026a48cd0950 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1346752 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b440c4e3561129d93bd3622091026a48cd0950 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant else when calling registerOvfStoreDisks
by mlipchuk＠redhat.com 15 Jun '16

15 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant else when calling registerOvfStoreDisks ...................................................................... core: Remove redundant else when calling registerOvfStoreDisks Since a false result will cause throwing new exception there is no reason to keep the else in the if statement. Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Connect all hosts on adding storage pool.
by mlipchuk＠redhat.com 15 Jun '16

15 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Connect all hosts on adding storage pool. ...................................................................... core: Connect all hosts on adding storage pool. Once we create a storage pool with multiple hosts, we connect the first host to all the storage domains and create a storage pool. After the create succeeded, the flow continues, and tries to fetch all the unregistered disks before all the hosts in the Data Center are connected to all the storage domains. As part of the query of getting the unregistered disks, the engine uses the getImagesList query. This vds command uses IrsProxyData which executes ConnectStoragePoolVDSCommand, and the host that execute this method uses a random host which might not be connected. To avoid this problem, once we have a host which successfully created a storage pool we keep connect all the rest of the storage domains since they are already being connected when getting activated. Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: text enhancements in migrations tab
by tnisan＠redhat.com 15 Jun '16

15 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: text enhancements in migrations tab ...................................................................... webadmin: text enhancements in migrations tab - change the "No Migration Policy" to "Legacy" - change "Migration" side tab name to "Migration Policy" - Resilience Policy: add a question mark next to it containing the "Defines under which conditions the virtual machines will be migrated." Change-Id: I406595e6b660e80b2c9419e2931f27d030b1a9ab Bug-Url: https://bugzilla.redhat.com/1346194 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/NoMigrationPolicy.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTooltip.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 9 files changed, 50 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I406595e6b660e80b2c9419e2931f27d030b1a9ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant else
by mlipchuk＠redhat.com 15 Jun '16

15 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant else ...................................................................... core: Remove redundant else Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488 Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: text enhancements in migrations tab
by mbetak＠redhat.com 15 Jun '16

15 Jun '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: text enhancements in migrations tab ...................................................................... webadmin: text enhancements in migrations tab - change the "No Migration Policy" to "Legacy" - change "Migration" side tab name to "Migration Policy" - Resilience Policy: add a question mark next to it containing the "Defines under which conditions the virtual machines will be migrated." Change-Id: I406595e6b660e80b2c9419e2931f27d030b1a9ab Bug-Url: https://bugzilla.redhat.com/1346194 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/migration/NoMigrationPolicy.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTooltip.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 9 files changed, 50 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I406595e6b660e80b2c9419e2931f27d030b1a9ab Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: speed up text truncation detection
by gshereme＠redhat.com 15 Jun '16

15 Jun '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: speed up text truncation detection ...................................................................... webadmin: speed up text truncation detection Previously, the algorithm for detecting horizontal text truncation was bad and really slow. Improved it. The algorithm for detecting vertical truncation was good, but really slow. There is no performant way to detect this. But, I don't think we really need it. So, removing it. Change-Id: I81476b018fa96ff182339053c1e8b5eba9207dc1 Bug-Url: https://bugzilla.redhat.com/1326513 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 5 files changed, 14 insertions(+), 28 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81476b018fa96ff182339053c1e8b5eba9207dc1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0