Change in ovirt-engine[ovirt-engine-3.6]: core: Fix audit message when removing disk from snapshot
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix audit message when removing disk from snapshot
......................................................................
core: Fix audit message when removing disk from snapshot
Currently, when removing disk from snapshot, wrong audit message is
presented: "Disk ... from Snapshot(s) ... deletion has been completed
..." instead of "Disk ... from Snapshot(s) ... deletion was initiated
...". This patch fixes the audit message to the expected one.
Change-Id: I830d6898052671e759ad96923a892828fd6c228d
Bug-Url: https://bugzilla.redhat.com/1344516
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/59072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I830d6898052671e759ad96923a892828fd6c228d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: display invalid partner mac alert also when partne...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: display invalid partner mac alert also when partner mac is 00:00:00:00:00:00
......................................................................
webadmin: display invalid partner mac alert also when partner mac is 00:00:00:00:00:00
The invalid partner mac alert on mode 4 bonds (exclamation
mark next to bond name) must be displayed not only when the
mac is empty, but also when the mac is 00:00:00:00:00:00.
The partner mac is empty or 00:00:00:00:00:00 when there is
an error condition in the bond (mode=4). This is why we
must guard against this specific mac value.
Change-Id: I13bc65d4097edb7b84e1c77a1f539d2f24800019
Bug-Url: https://bugzilla.redhat.com/1281666
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13bc65d4097edb7b84e1c77a1f539d2f24800019
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6.7]: api: api doesnt pass the vminit when increasing vm in pool v2
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: api: api doesnt pass the vminit when increasing vm in pool v2
......................................................................
api: api doesnt pass the vminit when increasing vm in pool v2
First patch solve the issue if the template have vminit and not pass it
to the new VM,
What was missing was if the pool edited the vminit we don't want to take
the vminit from the template but from the pool.
(since the pool is not saving the vminit in the database we take it from
one of the vms - this is the same behaviour as the UI)
Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b
Bug-Url: https://bugzilla.redhat.com/1339287
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59044
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: api: api doesnt pass the vminit when increasing vm in pool v2
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: api: api doesnt pass the vminit when increasing vm in pool v2
......................................................................
api: api doesnt pass the vminit when increasing vm in pool v2
First patch solve the issue if the template have vminit and not pass it
to the new VM,
What was missing was if the pool edited the vminit we don't want to take
the vminit from the template but from the pool.
(since the pool is not saving the vminit in the database we take it from
one of the vms - this is the same behaviour as the UI)
Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b
Bug-Url: https://bugzilla.redhat.com/1339287
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59043
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Consolidate EditableField Annotations
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Consolidate EditableField Annotations
......................................................................
core: Consolidate EditableField Annotations
This patch combines the EditableField, EditableOnVmStatusField,
EditableOnTemplate, EditableOnVm, and EditableOnHostedEngine
annotations into the EditableVmField annotation.
It also combines the EditableField and EditableOnVdsStatusField
annotations into the EditableVdsField annotation.
These changes are meant to make proper usage of the
annotations easier and the resulting code easier to
read and understand.
Change-Id: Iac377ee408d0e711a2cf3b3e72460814aa3183f8
Bug-Url: https://bugzilla.redhat.com/1326512
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdsHandlerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmTemplateHandlerTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableField.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableHostedEngineField.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnTemplate.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVdsStatus.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVmStatusField.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableVdsField.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableVmField.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableVmTemplateField.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceAgent.java
20 files changed, 482 insertions(+), 259 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/54725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac377ee408d0e711a2cf3b3e72460814aa3183f8
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: packaging: Don't explicitly disable usage of JBoss modules i...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: Don't explicitly disable usage of JBoss modules indexes
......................................................................
packaging: Don't explicitly disable usage of JBoss modules indexes
JBoss modules has the capability to read and write module indexes stored
in external files. This used to be enabled by default till version 1.2.0
of JBoss modules. When it was enabled by default it caused potential
problems for the engine:
* The engine could try to write indexes in directories where it doesn't
have permission to write.
* The engine could try to use indexes that had been written for older
versions of the application server.
To avoid these two problems the engine was modified to explicitly
disable writing the modules, and to create a shallow copy of the modules
directories without the existing indexes.
But since version 1.2.0 of JBoss modules both reading and writing these
external index files is disabled by default. The version of the
application server that we use uses version 1.5.0 of JBoss modules, so
we no longer need any of these two workarounds. This patch removes them
completely.
Change-Id: I1aa9d9091e634be9d7154120d95bd6ae7a4142c1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/bin/engine-config.sh
M packaging/bin/ovirt-engine-crypto-tool.sh
M packaging/bin/ovirt-engine-extensions-tool.sh
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
M packaging/services/ovirt-engine/ovirt-engine.py
5 files changed, 3 insertions(+), 55 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59069
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1aa9d9091e634be9d7154120d95bd6ae7a4142c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStorageDomainCommand type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStorageDomainCommand type inference
......................................................................
core: ProcessOvfUpdateForStorageDomainCommand type inference
Change-Id: Id170396c54846acbc5b011afb5cd2169a71e0b64
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id170396c54846acbc5b011afb5cd2169a71e0b64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainCommandTest type inference
......................................................................
core: DeactivateStorageDomainCommandTest type inference
Change-Id: I0c249c7afa6ab4183a53f678956d2238e4e10ba1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c249c7afa6ab4183a53f678956d2238e4e10ba1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix audit message when removing disk from snapshot
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix audit message when removing disk from snapshot
......................................................................
core: Fix audit message when removing disk from snapshot
Currently, when removing disk from snapshot, wrong audit message is
presented: "Disk ... from Snapshot(s) ... deletion has been completed
..." instead of "Disk ... from Snapshot(s) ... deletion was initiated
...". This patch fixes the audit message to the expected one.
Change-Id: I830d6898052671e759ad96923a892828fd6c228d
Bug-Url: https://bugzilla.redhat.com/1344516
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I830d6898052671e759ad96923a892828fd6c228d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Adapt "Link" header for V3
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Adapt "Link" header for V3
......................................................................
restapi: Adapt "Link" header for V3
Version 4 of the API doesn't return the "capabilities" link because it
doesn't exist. Version 3 of the API adds it explicitly, but only to the
response body, it doesn't add it to the "Link" header. This patch
modifies the V3 compatibility layer so that the "Link" header generated
by version 4 of the API is removed and replaced by a value calculated
from the request body, this way it will the body and the header will
always be in sync.
Change-Id: Ieb2ad00a84e671629d8303898c7b08cd300cded2
Bug-Url: https://bugzilla.redhat.com/1342226
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit bef31bbe3c628e059e09d63d04540ae7deafeef7)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3SystemServer.java
1 file changed, 47 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb2ad00a84e671629d8303898c7b08cd300cded2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months