June 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Fix audit message when removing disk from snapshot

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix audit message when removing disk from snapshot ...................................................................... core: Fix audit message when removing disk from snapshot Currently, when removing disk from snapshot, wrong audit message is presented: "Disk ... from Snapshot(s) ... deletion has been completed ..." instead of "Disk ... from Snapshot(s) ... deletion was initiated ...". This patch fixes the audit message to the expected one. Change-Id: I830d6898052671e759ad96923a892828fd6c228d Bug-Url: https://bugzilla.redhat.com/1344516 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/59059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I830d6898052671e759ad96923a892828fd6c228d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Adapt "Link" header for V3

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Adapt "Link" header for V3 ...................................................................... restapi: Adapt "Link" header for V3 Version 4 of the API doesn't return the "capabilities" link because it doesn't exist. Version 3 of the API adds it explicitly, but only to the response body, it doesn't add it to the "Link" header. This patch modifies the V3 compatibility layer so that the "Link" header generated by version 4 of the API is removed and replaced by a value calculated from the request body, this way it will the body and the header will always be in sync. Change-Id: Ieb2ad00a84e671629d8303898c7b08cd300cded2 Bug-Url: https://bugzilla.redhat.com/1342226 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3SystemServer.java 1 file changed, 47 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb2ad00a84e671629d8303898c7b08cd300cded2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Set disk profile on image creation or update

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set disk profile on image creation or update ...................................................................... webadmin: Set disk profile on image creation or update Set the disk profile when an image is created or updated. Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Bug-Url: https://bugzilla.redhat.com/1297734 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: VM Start action properties list reviewed in RSDL

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: VM Start action properties list reviewed in RSDL ...................................................................... restapi: VM Start action properties list reviewed in RSDL The action properties list conforms the 'Initialization to VmInit' mapper (org.ovirt.engine.api.restapi.types.InitializationMapper) Bug-Url: https://bugzilla.redhat.com/1318701 Change-Id: I4b2e32ef4d0af0301df0444c075c445b9cf6acc7 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Looks good to me, approved Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b2e32ef4d0af0301df0444c075c445b9cf6acc7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: VmPool properties list reviewed in RSDL

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: VmPool properties list reviewed in RSDL ...................................................................... restapi: VmPool properties list reviewed in RSDL The list of VmPool action properties conforms the 'VmPoolMapper'. Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Bug-Url: https://bugzilla.redhat.com/1318703 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 28 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93f323e6481f613607832dbc03ba3cf663d58faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Set disk profile on image creation or update

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set disk profile on image creation or update ...................................................................... webadmin: Set disk profile on image creation or update Set the disk profile when an image is created or updated. Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Bug-Url: https://bugzilla.redhat.com/1297734 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc5528419f14af4424dca42a9af3ee81122adc5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: gluster: fix geo rep session key parsing issue

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix geo rep session key parsing issue ...................................................................... gluster: fix geo rep session key parsing issue There is a change in the geo rep ression key from glusterfs 3.7.12 onwards. Slave volume UUID is added as lost component to session key. Updating the session key parsing to handle both old and new versions. Change-Id: I8717817065c17b3d9d50b3ff6f524d7a530f2039 Bug-Url: https://bugzilla.redhat.com/1343650 Bug-Url: https://bugzilla.redhat.com/1343946 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8717817065c17b3d9d50b3ff6f524d7a530f2039 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix fallback to XMLRPC during protocol detection

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix fallback to XMLRPC during protocol detection ...................................................................... core: Fix fallback to XMLRPC during protocol detection Fixes issue when we fell back to XMLRPC after the 1st unsuccessful attempt to connect to the host instead of number of retries defined in ProtocolFallbackRetries engine-config variable. Change-Id: I35a0bc9a0181e03dff143ceaaed647eab15b7de9 Bug-Url: https://bugzilla.redhat.com/1345779 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35a0bc9a0181e03dff143ceaaed647eab15b7de9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Expose vm_pool.stateful field

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Expose vm_pool.stateful field ...................................................................... restapi: Expose vm_pool.stateful field Change-Id: I36f435b0c25f4363974f38917584f9d0f94245d4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1343672 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmPoolMapperTest.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/59014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f435b0c25f4363974f38917584f9d0f94245d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: api: api doesnt pass the vminit when increasing vm in pool v2

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: api: api doesnt pass the vminit when increasing vm in pool v2 ...................................................................... api: api doesnt pass the vminit when increasing vm in pool v2 First patch solve the issue if the template have vminit and not pass it to the new VM, What was missing was if the pool edited the vminit we don't want to take the vminit from the template but from the pool. (since the pool is not saving the vminit in the database we take it from one of the vms - this is the same behaviour as the UI) Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b Bug-Url: https://bugzilla.redhat.com/1339287 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8572c71665016bf3a8cab033989b2473f0ce994b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2016