June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Enable/Disable Pass-Through Host CPU Correctly
by awels＠redhat.com 14 Jun '16

14 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Enable/Disable Pass-Through Host CPU Correctly ...................................................................... webadmin: Enable/Disable Pass-Through Host CPU Correctly The 'Pass-Through Host CPU' option in the Host tab of the VM dialog should be enabled for non-PPC clusters when either: a. "Do not allow migration" is selected OR b. "Allow manual migration" is selected and no specific host is selected The option wasn't enabled when the "Allow manual migration" and "Any Host in Cluster" options were selected. This patch corrects that problem. Change-Id: I6b1fcd0187d5991ffb7528099aecf025d4652460 Bug-Url: https://bugzilla.redhat.com/1342928 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 21 insertions(+), 8 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/59092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b1fcd0187d5991ffb7528099aecf025d4652460 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject DAOs in Backend
by masayag＠redhat.com 14 Jun '16

14 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: inject DAOs in Backend ...................................................................... core: inject DAOs in Backend Obtain DAOs in Backend class using CDI rather than static methods in DbFacade. Consuming specific dependencies rather then "big all-know" (e.g. DbFacade) whould help resolving cirular dependency problems. Change-Id: I3170007c2491744c2a5f5d1a45674950235a32bd Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 22 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3170007c2491744c2a5f5d1a45674950235a32bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant DbFacade.getJdbcTemplate method
by masayag＠redhat.com 14 Jun '16

14 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: remove redundant DbFacade.getJdbcTemplate method ...................................................................... core: remove redundant DbFacade.getJdbcTemplate method Change-Id: I258be98592f14a2aaf056a2221bc01368413b970 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I258be98592f14a2aaf056a2221bc01368413b970 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fix possible NPE on pool creation/update
by tnisan＠redhat.com 14 Jun '16

14 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix possible NPE on pool creation/update ...................................................................... core: fix possible NPE on pool creation/update The given pool in the parameters might contain invalid cluster. Thus, null-check is added. Change-Id: I1a3897cde04b0ee6bf937b9188373199c08eca05 Bug-Url: https://bugzilla.redhat.com/1345853 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a3897cde04b0ee6bf937b9188373199c08eca05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: No UpdateVmCommand after Cluster Edit for external VMs
by tnisan＠redhat.com 14 Jun '16

14 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: No UpdateVmCommand after Cluster Edit for external VMs ...................................................................... core: No UpdateVmCommand after Cluster Edit for external VMs The UpdateClusterCommand avoids calling the UpdateVmCommand for External and HostedEngine VMs to prevent validation failure. Change-Id: I2120451866c8fad1a0c39635a07d056ab45a0f86 Bug-Url: https://bugzilla.redhat.com/1341145 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2120451866c8fad1a0c39635a07d056ab45a0f86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fix detection of unmanaged vms
by tnisan＠redhat.com 14 Jun '16

14 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix detection of unmanaged vms ...................................................................... core: fix detection of unmanaged vms When detecting an unmanaged VM running on the host, we add the dynamic data that is reported by VDSM to the database. This data does not contain the host that the VM is running on, so we end up having a running VM without the host that it runs on. This situation must be prevented. Change-Id: I9f488df83c9335922b0b422e85da4bc93b8a380b Bug-Url: https://bugzilla.redhat.com/1342818 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f488df83c9335922b0b422e85da4bc93b8a380b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: Enable repos after whitelisting
by fabiand＠redhat.com 14 Jun '16

14 Jun '16

Fabian Deutsch has submitted this change and it was merged. Change subject: node: Enable repos after whitelisting ...................................................................... node: Enable repos after whitelisting Change-Id: I427dd77dc057c0851fd16b956cabdc857ffb3b60 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M configure.ac M ovirt-release40.spec.in 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I427dd77dc057c0851fd16b956cabdc857ffb3b60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant code
by ahadas＠redhat.com 14 Jun '16

14 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove redundant code ...................................................................... core: remove redundant code The 'init' method in command classes is never called when the parameters class is null (that happens in compensation flow). Therefore, there is no need to check that inside. Change-Id: I2b4778b15f78fd82aed647b1772febd2d077b153 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b4778b15f78fd82aed647b1772febd2d077b153 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in parameters of add vm
by ahadas＠redhat.com 14 Jun '16

14 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in parameters of add vm ...................................................................... core: cleanup in parameters of add vm Remove unused field 'diskInfoList' Change-Id: Ieb33f29b8b99b26d7ca612ee96a96aa63357a01d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb33f29b8b99b26d7ca612ee96a96aa63357a01d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix serialization of pool related parameter classes
by ahadas＠redhat.com 14 Jun '16

14 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix serialization of pool related parameter classes ...................................................................... core: fix serialization of pool related parameter classes Fields in the parameters class should have setters and getters. Change-Id: Iae19a2056ba31164c65744ea016a00329e6abcf2 Bug-Url: https://bugzilla.redhat.com/1345853 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolOperationParameters.java 2 files changed, 25 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae19a2056ba31164c65744ea016a00329e6abcf2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0