Change in ovirt-engine[master]: core: persist reported switch type of network into vds_inter...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: persist reported switch type of network into vds_interface
......................................................................
core: persist reported switch type of network into vds_interface
Change-Id: I6342506210c90f2f795f2616428b645a21163d0b
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
2 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56193
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6342506210c90f2f795f2616428b645a21163d0b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: add switchType to VdsNetworksInterface and Cluster.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: add switchType to VdsNetworksInterface and Cluster.
......................................................................
core: add switchType to VdsNetworksInterface and Cluster.
Change-Id: Iceb0bfcaddfd8b3b81077db9a20b1241a13ce34c
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/DefaultSwitchType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/SwitchType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M packaging/dbscripts/clusters_sp.sql
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_00_0800_add_switch_type_to_vds_interface_and_cluster.sql
11 files changed, 71 insertions(+), 14 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceb0bfcaddfd8b3b81077db9a20b1241a13ce34c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: added switch attribute to HostSetupNetworksVDSCommand ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: added switch attribute to HostSetupNetworksVDSCommand and to HostNetwork
......................................................................
core: added switch attribute to HostSetupNetworksVDSCommand and to HostNetwork
Change-Id: I70e01efe791408392144043fc57c9f7d9da49724
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/network/SwitchType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
7 files changed, 69 insertions(+), 1 deletion(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70e01efe791408392144043fc57c9f7d9da49724
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: scheduling: Add selector step to the scheduler
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduling: Add selector step to the scheduler
......................................................................
scheduling: Add selector step to the scheduler
The new selector step (and relevant policy units) enhances the
flexibility of our scheduling process.
We used to have just two steps:
- filter out all non-compliant hosts
- compute weight for all remaining hosts
And then a hardcoded routine selected the "best" host
according to the accumulated weights.
The selector replaces this hardcoded logic with a pluggable
policy unit of type SELECTOR. Two example units are provided.
- BasicWeightSelector - copies the old logic
and
- RankSelector - uses rank instead of the raw weights
Change-Id: If63b90c3f5e02d9ccdc77dd920233e3013e933e0
Signed-off-by: Martin Sivák <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/BasicWeightSelectorPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/RankSelectorPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/selector/SelectorInstance.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/BasicWeightSelectorPolicyUnitTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/RankSelectorPolicyUnitTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnitType.java
11 files changed, 523 insertions(+), 36 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47772
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If63b90c3f5e02d9ccdc77dd920233e3013e933e0
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Allow adding 3.6 host without deploying HE
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Allow adding 3.6 host without deploying HE
......................................................................
core: Allow adding 3.6 host without deploying HE
The validation for adding hosts to 3.6 should allow action of 'none' on
those hosts since it doesn't have any effect on HE install and 3.6
supports that.
Change-Id: Ifbe61e41f145e2e8fefcb9f69b4ef24ae1f090e0
Bug-Url: https://bugzilla.redhat.com/1342500
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java
2 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58670
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbe61e41f145e2e8fefcb9f69b4ef24ae1f090e0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: build: post ovirt-engine-4.0.0.3
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: post ovirt-engine-4.0.0.3
......................................................................
build: post ovirt-engine-4.0.0.3
Change-Id: I162cb772ca82c05573782473c39736e2114b97e3
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M pom.xml
M version.mak
59 files changed, 66 insertions(+), 63 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Looks good to me, but someone else must approve
Rafael Martins: Verified
--
To view, visit https://gerrit.ovirt.org/58829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I162cb772ca82c05573782473c39736e2114b97e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: build: ovirt-engine-4.0.0.3
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: ovirt-engine-4.0.0.3
......................................................................
build: ovirt-engine-4.0.0.3
Change-Id: I26cd84d7c16b180c84e56877df5d5c874857ba16
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
60 files changed, 65 insertions(+), 65 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Looks good to me, but someone else must approve
Rafael Martins: Verified
--
To view, visit https://gerrit.ovirt.org/58826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26cd84d7c16b180c84e56877df5d5c874857ba16
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: setup: Image Proxy PKI setup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: setup: Image Proxy PKI setup
......................................................................
setup: Image Proxy PKI setup
The ovirt-imageio-proxy needs key and certificate files to enable SSL
communication to the engine. Enable creation of these files during
engine-setup so that the proxy can use them to decode and verify the
auth ticket used during the upload process.
Change-Id: I2261cddab398bdc7d8b5ffce5623ff41e353829a
Bug-Url: https://bugzilla.redhat.com/1342322
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58659
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2261cddab398bdc7d8b5ffce5623ff41e353829a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fixing style of 'Host Interfaces' sub tab
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixing style of 'Host Interfaces' sub tab
......................................................................
webadmin: Fixing style of 'Host Interfaces' sub tab
Change-Id: I72d0b8f9c6b427cd1eaf71a9a592b5c276bc396e
Bug-Url: https://bugzilla.redhat.com/1321459
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceHorizontalPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
5 files changed, 20 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72d0b8f9c6b427cd1eaf71a9a592b5c276bc396e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: typos in setup-networks error messages
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: typos in setup-networks error messages
......................................................................
webadmin: typos in setup-networks error messages
Change-Id: I837ca1260ccc6d5d94a9e48b16a4bb20a6ae036a
Bug-Url: https://bugzilla.redhat.com/1342943
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58818
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I837ca1260ccc6d5d94a9e48b16a4bb20a6ae036a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months