June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix image size after live merge
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix image size after live merge ...................................................................... core: Fix image size after live merge Change-Id: I2d072a81fdb87f2ba78541fc079c4c2367048cf5 Bug-Url: https://bugzilla.redhat.com/1333342 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/58671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d072a81fdb87f2ba78541fc079c4c2367048cf5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix image size after live merge
by amureini＠redhat.com 06 Jun '16

06 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix image size after live merge ...................................................................... core: Fix image size after live merge Change-Id: I2d072a81fdb87f2ba78541fc079c4c2367048cf5 Bug-Url: https://bugzilla.redhat.com/1333342 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/58560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d072a81fdb87f2ba78541fc079c4c2367048cf5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Remove VisibleLocalesInfoData
by awels＠redhat.com 06 Jun '16

06 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin,userportal: Remove VisibleLocalesInfoData ...................................................................... webadmin,userportal: Remove VisibleLocalesInfoData Removed unused VisibleLocalesInfoData which contained list of locales for the (non-existent) UI language dropdown. Change-Id: If5f349ff78ce5d011f29fa7c5acb7f3486e48ee1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/VisibleLocalesInfoData.java 5 files changed, 1 insertion(+), 58 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/58578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5f349ff78ce5d011f29fa7c5acb7f3486e48ee1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add support for VDSM 4.18
by amureini＠redhat.com 06 Jun '16

06 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add support for VDSM 4.18 ...................................................................... core: Add support for VDSM 4.18 The VDSM version that corresponds to oVirt 4.x is the 4.18.z generation. This patch adds it to the versions supported by the 4.0 version. Change-Id: Ice22c2c7c883d46050eb4e2857579bd47a1ad287 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice22c2c7c883d46050eb4e2857579bd47a1ad287 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: prevent notification flood for number of LVs
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: prevent notification flood for number of LVs ...................................................................... engine: prevent notification flood for number of LVs When creating more than <AlertOnNumberOfLVs> LVs on a storage domain (300 by default), we log that the number of LVs on the storage domain exceeded the threshold. Since one can register to get this notification by mail, we should prevent a mail flood. This patch restricts this event to be logged once in 3 hours for each storage domain. Change-Id: I4df27e5b7211cb00c49221e99d4cdeab82f21bd9 Bug-Url: https://bugzilla.redhat.com/1275182 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageDomainHelper.java 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df27e5b7211cb00c49221e99d4cdeab82f21bd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: Image Proxy PKI setup
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: setup: Image Proxy PKI setup ...................................................................... setup: Image Proxy PKI setup The ovirt-imageio-proxy needs key and certificate files to enable SSL communication to the engine. Enable creation of these files during engine-setup so that the proxy can use them to decode and verify the auth ticket used during the upload process. Change-Id: I2261cddab398bdc7d8b5ffce5623ff41e353829a Bug-Url: https://bugzilla.redhat.com/1342322 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2261cddab398bdc7d8b5ffce5623ff41e353829a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Can't assign ip for a network attached to the same n...
by alkaplan＠redhat.com 06 Jun '16

06 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Can't assign ip for a network attached to the same nic as mgmt ...................................................................... engine: Can't assign ip for a network attached to the same nic as mgmt The validation that caused this wrong blocking is 'networkIpAddressWasSameAsHostnameAndChanged()'. Comparing the code of the validation in the old setup network command to the new one, shows that besides the bug in the title, the old logic was changed by mistake. After rethinking about this validation we came to conclusion that the old and the new validations block cases that may be permitted by the vdsm. So we decided, for now, to remove the engine level validation. In case of a real problem, the vdsm will perform a rollback. Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Bug-Url: https://bugzilla.redhat.com/1340702 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkAttachmentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 7 files changed, 2 insertions(+), 175 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: when attaching net to a new bond, it shouldn't get...
by alkaplan＠redhat.com 06 Jun '16

06 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: when attaching net to a new bond, it shouldn't get bond's params ...................................................................... webadmin: when attaching net to a new bond, it shouldn't get bond's params Change-Id: Iecc35fa26d6ba85d1f172046f46b83f9c6194aa7 Bug-Url: https://bugzilla.redhat.com/1340624 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecc35fa26d6ba85d1f172046f46b83f9c6194aa7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RegisterDiskCommand type inference
by mlipchuk＠redhat.com 06 Jun '16

06 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterDiskCommand type inference ...................................................................... core: RegisterDiskCommand type inference Change-Id: I31443d4c3f51665274cd8cb5159c7a24ae26c8b6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31443d4c3f51665274cd8cb5159c7a24ae26c8b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: log vms retrieved on statistics polling
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: log vms retrieved on statistics polling ...................................................................... core: log vms retrieved on statistics polling Log the VMs we get from VDSM on statistics monitoring cycles. Only the first eight digits in the VM ID are printed along with its status. We add this in order to produce more data that could help us with on- going bug investigation. Change-Id: I9fa187c317e4bac5cc4ef41541a1c31532fa909b Bug-Url: https://bugzilla.redhat.com/1339291 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa187c317e4bac5cc4ef41541a1c31532fa909b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0