June 2016 - Engine-commits - oVirt List Archives

Change in mom[master]: Improve the message when getVmMemoryStats() returns 0
by msivak＠redhat.com 06 Jun '16

06 Jun '16

Martin Sivák has submitted this change and it was merged. Change subject: Improve the message when getVmMemoryStats() returns 0 ...................................................................... Improve the message when getVmMemoryStats() returns 0 Mom is currently expecting a non-zero return for memory usage to assume ovirt-guest-agent is active, and throws an warning log along with an 'error' message if the first check has a 0ed return. This patch removes the 'error' string in the warning message and also includes the VM uuid in the message to improve the message relevance. Change-Id: I4afba631f190440810b3f022987ff152773ac6e6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234953 Signed-off-by: Amador Pahim <apahim(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/45596 Reviewed-by: Adam Litke <alitke(a)redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/Collectors/GuestMemory.py M mom/HypervisorInterfaces/vdsmInterface.py M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Amador Pahim: Verified -- To view, visit https://gerrit.ovirt.org/45596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4afba631f190440810b3f022987ff152773ac6e6 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: prevent notification flood for number of LVs
by tnisan＠redhat.com 06 Jun '16

06 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: prevent notification flood for number of LVs ...................................................................... engine: prevent notification flood for number of LVs When creating more than <AlertOnNumberOfLVs> LVs on a storage domain (300 by default), we log that the number of LVs on the storage domain exceeded the threshold. Since one can register to get this notification by mail, we should prevent a mail flood. This patch restricts this event to be logged once in 3 hours for each storage domain. Change-Id: I4df27e5b7211cb00c49221e99d4cdeab82f21bd9 Bug-Url: https://bugzilla.redhat.com/1275182 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageDomainHelper.java 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/58639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df27e5b7211cb00c49221e99d4cdeab82f21bd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update vdsm-jsonrpc-java to verion 1.2.3
by masayag＠redhat.com 05 Jun '16

05 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: update vdsm-jsonrpc-java to verion 1.2.3 ...................................................................... core: update vdsm-jsonrpc-java to verion 1.2.3 Update vdsm-jsonrpc-java to verion 1.2.3 (final). Change-Id: Iae15520c831c0b8de36169f0287057684033d376 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae15520c831c0b8de36169f0287057684033d376 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix debug print of polled vms
by ahadas＠redhat.com 05 Jun '16

05 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix debug print of polled vms ...................................................................... core: fix debug print of polled vms Adding missing whitespace between the different VMs. Change-Id: I61a37f3872bc0518a07c4a46757f114d870112d8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61a37f3872bc0518a07c4a46757f114d870112d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix NPE during merge of snapshots
by tnisan＠redhat.com 05 Jun '16

05 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE during merge of snapshots ...................................................................... core: Fix NPE during merge of snapshots Commit 6e55d137d5ca (core: Move disks boot and interface properties to DiskVmelement) disk boot and interface properties moved to DiskVmElement. This change caused NPE during snapshot merge because the DiskVmElement wasn't set on destination image. This patch sets DiskVmElement on disk before calling OvfWriter. Change-Id: I5ffecab869f82b5b78a5e1f19bdecbb6927e44e1 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/58513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ffecab869f82b5b78a5e1f19bdecbb6927e44e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: infra/storage: send commands to the SPM on a FIFO basis
by laravot＠redhat.com 05 Jun '16

05 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: infra/storage: send commands to the SPM on a FIFO basis ...................................................................... infra/storage: send commands to the SPM on a FIFO basis The synchronized 'syncObj' object, used to serialize SPM commands from the manager to the hypervisor is not particularly fair, which makes these commands to arrive in random order on vdsm. This is particularly true when a lot of commands are sent to the manager, using the API for example. In this case, some delays may get very large. Using a fair ReentrentLock instead of executing the code in a synchronized block, respects the order of the commands, eliminating the chance of starvation. Using a reentrant lock makes it easy to report the number of threads waiting on the lock as well. Change-Id: I23fb85a4179c8a77bf1b3df532d43edc4207f33a Bug-Url: https://bugzilla.redhat.com/1277057 Bug-Url: https://bugzilla.redhat.com/1282764 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 2 files changed, 29 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23fb85a4179c8a77bf1b3df532d43edc4207f33a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: lsm: Remove auto-generated snapshot when LSM fails
by tnisan＠redhat.com 05 Jun '16

05 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: lsm: Remove auto-generated snapshot when LSM fails ...................................................................... lsm: Remove auto-generated snapshot when LSM fails Patch https://gerrit.ovirt.org/57302 handled removing the auto-generated snapshot when LSM successfully completes. This patch handles removing the auto-generated snapshot when LSM fails. Change-Id: Ib1ec65092fbc3bf204171da4cd32e4715019ff27 Bug-Url: https://bugzilla.redhat.com/1336214 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/58632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ec65092fbc3bf204171da4cd32e4715019ff27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Remove old shared status calculation
by tnisan＠redhat.com 05 Jun '16

05 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove old shared status calculation ...................................................................... core: Remove old shared status calculation Commit 904ab61 introduced an improved method of calculating a storage domain's shared status, which is indeed currently in use in the dwh_storage_domain_history_view. That patch, however, left the old mechanism in place alongside the new mechanism. This had no functional effect, as it's a left join on a column that's never queried, but it does cause a redundant performance penalty. This patch fixes the problem by removing this redundant join. Related-To: https://bugzilla.redhat.com/1306325 Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix creation of diskless snapshot without memory
by tnisan＠redhat.com 05 Jun '16

05 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix creation of diskless snapshot without memory ...................................................................... core: Fix creation of diskless snapshot without memory When creating a snapshot without memory the snapshot is created initially in OK status while relying on the fact that no async operations will run and the command won't reach the endAction() phase. When using the ConcurrentChildCommandsExecutionCallback, the command will always reach the endAction() method. This patch removes duplicated code between the execute() and the endAction() while adapting the endAction() to handle a snapshots which contains only configuration. Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701 Bug-Url: https://bugzilla.redhat.com/1342110 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java 1 file changed, 13 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/58634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix creation of diskless snapshot without memory
by laravot＠redhat.com 05 Jun '16

05 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Fix creation of diskless snapshot without memory ...................................................................... core: Fix creation of diskless snapshot without memory When creating a snapshot without memory the snapshot is created initially in OK status while relying on the fact that no async operations will run and the command won't reach the endAction() phase. When using the ConcurrentChildCommandsExecutionCallback, the command will always reach the endAction() method. This patch removes duplicated code between the execute() and the endAction() while adapting the endAction() to handle a snapshots which contains only configuration. Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701 Bug-Url: https://bugzilla.redhat.com/1342110 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java 1 file changed, 13 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/58543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica11d72fa366a65eda975770ad96d7ec1feb8701 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0