June 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: GetUnregisteredDisksQuery type inference

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredDisksQuery type inference ...................................................................... core: GetUnregisteredDisksQuery type inference Change-Id: I19e075a1881cc3d5436a223a02b5ce0d833c8914 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19e075a1881cc3d5436a223a02b5ce0d833c8914 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[master]: core: Make db functions immutable where possible

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make db functions immutable where possible ...................................................................... core: Make db functions immutable where possible Functions that returns results based only on the parameters (and not any underlying database table) should be defined as IMMUTABLE, to allow the database to perform pre-evaluations. Change-Id: I0e28e140282a0e22c687b4fe84701e8688e421ac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e28e140282a0e22c687b4fe84701e8688e421ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove old shared status calculation

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove old shared status calculation ...................................................................... core: Remove old shared status calculation Commit 904ab61 introduced an improved method of calculating a storage domain's shared status, which is indeed currently in use in the dwh_storage_domain_history_view. That patch, however, left the old mechanism in place alongside the new mechanism. This had no functional effect, as it's a left join on a column that's never queried, but it does cause a redundant performance penalty. This patch fixes the problem by removing this redundant join. Related-To: https://bugzilla.redhat.com/1306325 Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I835cf5ccbedba2c54c1b216ef6bb267a40f89a75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[master]: core: more efficient query for getting vms to monitor

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: core: more efficient query for getting vms to monitor ...................................................................... core: more efficient query for getting vms to monitor Once in every 5th iteration (currently every 15 secs) we query all the VMs that run on a given host for the sake of monitoring. We used to query them using the 'vms' view. 'vms' view get all the data of the VMs from vm_static, vm_dynamic, vm_statistics, cluster, storage_pool, quota, vds_static, vm_pool_map_view and snapshots, while the data needed by the monitoring resides only in vm_static, vm_dynamic and vm_statistics. This patch introduces another query dedicated for monitoring that is much more efficient than the previous one. Change-Id: Iac9d32f7bc47f7e7af9075e52b658b00cc7f64c3 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/vms_sp.sql 3 files changed, 74 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac9d32f7bc47f7e7af9075e52b658b00cc7f64c3 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[master]: core: refine log for retrieved vms on statistics cycle

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: core: refine log for retrieved vms on statistics cycle ...................................................................... core: refine log for retrieved vms on statistics cycle Now that there is no immediate need to log all the VMs we retrieve on statistics monitoring cycles, we: 1. reduce the log level of the detailed information (that contains both VM IDs and their statuses) to DEBUG 2. log a summary that contains the ID of the monitored host and the amount of fetched VMs in INFO level Change-Id: Ic89f4f6c59a896d8c9fa198f0ce7c74c9c9046aa Bug-Url: https://bugzilla.redhat.com/1339291 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/58567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89f4f6c59a896d8c9fa198f0ce7c74c9c9046aa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Import graphics devices from hosted engine VM

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Import graphics devices from hosted engine VM ...................................................................... core: Import graphics devices from hosted engine VM When importing the hosted engine VM we now import the Graphics devices (SPICE, VNC). Previously they were ignored because they never get an address property. Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5 Bug-Url: https://bugzilla.redhat.com/1326810 Bug-Url: https://bugzilla.redhat.com/1328921 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java A backend/manager/modules/vdsbroker/src/test/resources/external_vm.json A backend/manager/modules/vdsbroker/src/test/resources/he_vm.json A backend/manager/modules/vdsbroker/src/test/resources/internal_vm.json 5 files changed, 924 insertions(+), 109 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Bump vdsm-jsonrpc-java to 1.2.3

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Bump vdsm-jsonrpc-java to 1.2.3 ...................................................................... core: Bump vdsm-jsonrpc-java to 1.2.3 Bumps vdsm-jsonrpc-java to 1.2.3 (removing SNAPSHOT). Change-Id: I06b605bd234ced3a4890e8683143b4aa6470fc04 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b605bd234ced3a4890e8683143b4aa6470fc04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

8 years

1
0
0 / 0

Change in ovirt-engine[master]: lsm: Remove auto-generated snapshot when LSM fails

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: lsm: Remove auto-generated snapshot when LSM fails ...................................................................... lsm: Remove auto-generated snapshot when LSM fails Patch https://gerrit.ovirt.org/57302 handled removing the auto-generated snapshot when LSM successfully completes. This patch handles removing the auto-generated snapshot when LSM fails. Change-Id: Ib1ec65092fbc3bf204171da4cd32e4715019ff27 Bug-Url: https://bugzilla.redhat.com/1336214 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Ala Hino: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ec65092fbc3bf204171da4cd32e4715019ff27 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Checkbox labels in Install Host dialog

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Checkbox labels in Install Host dialog ...................................................................... webadmin: Checkbox labels in Install Host dialog Labels of checkboxes * Automatically configure host firewall * Activate host after install in Install Host dialog were hidden. Change-Id: Ic6962ce0024ccdfecf2788f465411f0357643a73 Bug-Url: https://bugzilla.redhat.com/1342476 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6962ce0024ccdfecf2788f465411f0357643a73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: Require oVirt Dashboard 1.0.0

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Require oVirt Dashboard 1.0.0 ...................................................................... packaging: Require oVirt Dashboard 1.0.0 Change-Id: Iee54201a0e4923360dc3a022342d46b360b5f865 Bug-Url: https://bugzilla.redhat.com/1342070 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee54201a0e4923360dc3a022342d46b360b5f865 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2016