Change in ovirt-engine[master]: core: adding CloneImageGroupVolumesStructureCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding CloneImageGroupVolumesStructureCommand
......................................................................
core: adding CloneImageGroupVolumesStructureCommand
Change-Id: I25fa2e9b665e59317db5a38dfcab8a5a65790aa8
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneImageGroupVolumesStructureCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
4 files changed, 181 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25fa2e9b665e59317db5a38dfcab8a5a65790aa8
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: adding CopyImageGroupVolumesDataCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding CopyImageGroupVolumesDataCommand
......................................................................
core: adding CopyImageGroupVolumesDataCommand
Change-Id: I6793dad637799dcc927a855d660320f922c7bf1d
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CopyImageGroupVolumesDataCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
3 files changed, 132 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6793dad637799dcc927a855d660320f922c7bf1d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Always populate V3 disk interface and bootable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Always populate V3 disk interface and bootable
......................................................................
restapi: Always populate V3 disk interface and bootable
Currently the V3 disk interface and bootable attributes are only
populated with a disk is retrieved, but it isn't populated for disk
objects returned by the "add" or "update" operations. To fix that
this patch moves the code that populates these attributes from the
implementation of the "get" operation to the adapter that transforms
all output disk objects.
Change-Id: I17634e05969ca826ae9a1c7aa08d9bfcfe0ef620
Bug-Url: https://bugzilla.redhat.com/1349594
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 7964f2a1c81c83048a6394155a2686597aad5d44)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
3 files changed, 30 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17634e05969ca826ae9a1c7aa08d9bfcfe0ef620
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Update OVF after cold merge
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: Update OVF after cold merge
......................................................................
core: Update OVF after cold merge
Currently, after cold merge the OVF is not updated. Hence, the OVF
doesn't contain the accurate data after cold merge. For example,
image actual size is wrong. This patch updates the OVF after cold
Change-Id: I73541b2cfaeef875c5bdc1f026150bcd3b2473a9
Bug-Url: https://bugzilla.redhat.com/1330978
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
2 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73541b2cfaeef875c5bdc1f026150bcd3b2473a9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Move logic from RemoveSnapshotSingleDiskLiveCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: Move logic from RemoveSnapshotSingleDiskLiveCommand
......................................................................
core: Move logic from RemoveSnapshotSingleDiskLiveCommand
Move syncDbRecords method and the methods it invokes, from
RemoveSnapshotSingleDiskLiveCommand class to
RemoveSnapshotSingleDiskCommandBase class in order to be reused by
RemoveSnapshotSingleDiskCommand (done in commit c5c7599c56).
Change-Id: I771ee8574a222fd9c0fb1218b57ce26966c0d5a9
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
2 files changed, 151 insertions(+), 143 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59599
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I771ee8574a222fd9c0fb1218b57ce26966c0d5a9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Change syncDbRecords declaration
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: Change syncDbRecords declaration
......................................................................
core: Change syncDbRecords declaration
Change syncDbRecords declaration so it can be reused by
RemoveSnapshotSingleDiskLiveCommand and
RemoveSnapshotSingleDiskCommand.
Change-Id: Idcb381ec40cb934a74ac51f4b4d0c5bff5113165
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb381ec40cb934a74ac51f4b4d0c5bff5113165
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Upgrade apache-sshd to 0.12.0
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Upgrade apache-sshd to 0.12.0
......................................................................
core: Upgrade apache-sshd to 0.12.0
Change-Id: Ib29e01a6a1d9ad8ca1e38db718e8961eb45c378f
Bug-Url: https://bugzilla.redhat.com/1347337
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59398
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib29e01a6a1d9ad8ca1e38db718e8961eb45c378f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: engine: add isMacInRange to MacPool
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add isMacInRange to MacPool
......................................................................
engine: add isMacInRange to MacPool
Change-Id: Ib03ee34496fe897a2981cc8e7ac9ddc1226c1174
Bug-Url: https://bugzilla.redhat.com/1209795
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPool.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java
4 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/58399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib03ee34496fe897a2981cc8e7ac9ddc1226c1174
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: webadmin: Fixing variable substitution in SUBNET_ADDED audit...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Fixing variable substitution in SUBNET_ADDED audit log
......................................................................
webadmin: Fixing variable substitution in SUBNET_ADDED audit log
AddSubnetToProviderCommand lacked the getters need to substitute
message variables in audit log.
This patch adds the needed getters.
Change-Id: I439a10a090fdfb373ff6e3e202170cb140064cbd
Bug-Url: https://bugzilla.redhat.com/1345810
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddSubnetToProviderCommand.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I439a10a090fdfb373ff6e3e202170cb140064cbd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: engine: Validate network providers against required fields.
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Validate network providers against required fields.
......................................................................
engine: Validate network providers against required fields.
It was possible to craete a an openstack network provider
without the required fields. This patch adds the required
validation.
Change-Id: I709e3df59eaf3cd0db983dd132342e90b1f02f74
Bug-Url: https://bugzilla.redhat.com/1333728
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 156 insertions(+), 7 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I709e3df59eaf3cd0db983dd132342e90b1f02f74
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months