July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: do not rely on resource manager to clear interface sta...
by ahadas＠redhat.com 20 Jul '16

20 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not rely on resource manager to clear interface statistics ...................................................................... core: do not rely on resource manager to clear interface statistics SetVmStatus used to rely on ResourceManager#internalSetVmStatus to clear the network interface statistics, if needed. But it was done without loading the network interfaces first. So this patch removes this redundant part for now and add a TODO comment to fix this. Change-Id: I89b3ec50b5f4ce10e3f9fabfc7997b4401d25d06 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b3ec50b5f4ce10e3f9fabfc7997b4401d25d06 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal, webadmin: show single exception alert.
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: show single exception alert. ...................................................................... userportal,webadmin: show single exception alert. - Update the alert panel to only show a single alert at once instead of multiple. If more than one is shown now show a counter of the number of alerts. This is achieved using a bootstrap 'badge'. - Updated the tooltip associated with the alert to show all the alerts. Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1320559 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java 4 files changed, 78 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Cluster version update locks all VMs
by tnisan＠redhat.com 20 Jul '16

20 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Cluster version update locks all VMs ...................................................................... core: Cluster version update locks all VMs Updating cluster version needs to call UpdateVmCommand to update VM devices (https://gerrit.ovirt.org/#/c/55636/) This patch adds locking of all necessary VMs in the UpdateClusterCommand if version is being changed. Locks are passed to UpdateVmCommand by setting LockProperties scope to None. Backport only change: initialization of UpdateClusterCommand#oldGroup was moved from validate() method to init() + tests. Inspired by patch https://gerrit.ovirt.org/#/c/50756. Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 75 insertions(+), 33 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: fix dao tests path search string
by sbonazzo＠redhat.com 20 Jul '16

20 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix dao tests path search string ...................................................................... fix dao tests path search string - removed double equal inside array - moved paths into array format Change-Id: I1aeb9c90827d0f09672b69267740fe746d56fc64 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M automation/check-patch.sh 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, approved Eyal Edri: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aeb9c90827d0f09672b69267740fe746d56fc64 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: show single exception alert.
by awels＠redhat.com 19 Jul '16

19 Jul '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: show single exception alert. ...................................................................... userportal,webadmin: show single exception alert. - Update the alert panel to only show a single alert at once instead of multiple. If more than one is shown now show a counter of the number of alerts. This is achieved using a bootstrap 'badge'. - Updated the tooltip associated with the alert to show all the alerts. Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1320559 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java 4 files changed, 78 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd167dd0b988578cf29bc7e46ee66aa995b4d489 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: periodic decrease of 20 days for warning & abandoning
by amarchuk＠redhat.com 19 Jul '16

19 Jul '16

Anton Marchukov has submitted this change and it was merged. Change subject: periodic decrease of 20 days for warning & abandoning ...................................................................... periodic decrease of 20 days for warning & abandoning Change-Id: I62c1bd7a8b6a1ad51f31fad9d5ed089756b20c81 Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Anton Marchukov: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62c1bd7a8b6a1ad51f31fad9d5ed089756b20c81 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: tools: Rephrase privacy protocol description
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: tools: Rephrase privacy protocol description ...................................................................... tools: Rephrase privacy protocol description Rephrase the description for SNMP_PRIVACY_PROTOCOL to make it clear that not all SNMP servers support AES192 and AES256 protocols. Change-Id: I3be8fc9b7d74d0116a775051705d41eccb6142ed Bug-Url: https://bugzilla.redhat.com/1354452 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit b66e38b60f0ea2645accb32cfcb2e26d91a10009) --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3be8fc9b7d74d0116a775051705d41eccb6142ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Added information about maintenance modes in the man page.
by sbonazzo＠redhat.com 19 Jul '16

19 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added information about maintenance modes in the man page. ...................................................................... Added information about maintenance modes in the man page. Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335952 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M man/hosted-engine.8 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: error fix
by masayag＠redhat.com 19 Jul '16

19 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: error fix ...................................................................... core: error fix error caused by wrong rebase. Change-Id: I2ed6f1e1df2bcfff53b540a16a4a75178911d406 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/qos/PersistentHostSetupNetworksParametersFactoryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed6f1e1df2bcfff53b540a16a4a75178911d406 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: run setup-upgrade job per patch for master
by sbonazzo＠redhat.com 19 Jul '16

19 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: run setup-upgrade job per patch for master ...................................................................... run setup-upgrade job per patch for master Change-Id: I57664c202c91d748b3c2bb6b8555e3836af10d61 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57664c202c91d748b3c2bb6b8555e3836af10d61 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0