July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: Logging of VmPoolMonitor fixed
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Logging of VmPoolMonitor fixed ...................................................................... core: Logging of VmPoolMonitor fixed * Log message about failed VM prestarting was not always printed. E.g. when there was only one VM in the pool. Fixed. * Log level of failures during prestarting was changed from INFO to WARN. * Ids of VMs that failed to prestart were added to the log. Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50 Bug-Url: https://bugzilla.redhat.com/1346848 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 17 insertions(+), 18 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1384c893015b8abf91e2863d4181d14c807dee50 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: show descriptive error on illegal max value
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show descriptive error on illegal max value ...................................................................... core: show descriptive error on illegal max value Show descriptive error on illegal max value in search engine. This patch fixes an issue when illegal negative max value is passed to the search engine. The problem was that the default value for the max parameter was -1 which was translated as "no max parameter given" so all records should be retrieved. Instead of that, the default value was changed to Integer.MAX_VALUE In addition, in case of RuntimeException, the exception was swallowed by SearchQuery::initQueryData method and therefor the error was not returned to the API call. I changed that such that a RuntimeException will be thrown again after writing to the log. Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352953 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 3 files changed, 8 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1821b4a8109da4c48c8d8d32c0c52dadd1603b78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: NPE on new instance type dialog
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE on new instance type dialog ...................................................................... webadmin: NPE on new instance type dialog The getOverrideMigrationPolicy().getEntity() may be null in some cases (new instance type) causing a NPE in and if statement. Fixed by having a null safe check. Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Bug-Url: https://bugzilla.redhat.com/1357440 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13171aaa1df7582d3cd5d27dc50f6e6faed18910 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix UI exception after creating new profile
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix UI exception after creating new profile ...................................................................... webadmin: Fix UI exception after creating new profile This prevents a race occuring when the query result from syncSearch has returned and fetchProfiles() was called yet the entity meanwhile was changed to null Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Bug-Url: https://bugzilla.redhat.com/1354547 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/ProfileListModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0.alpha13
by omachace＠redhat.com 19 Jul '16

19 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.0.alpha13 ...................................................................... [maven-release-plugin] prepare release 4.0.0.alpha13 Change-Id: I2a310d2c3b4d805c919288213050683f9b23f0e5 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a310d2c3b4d805c919288213050683f9b23f0e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by omachace＠redhat.com 19 Jul '16

19 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I888c514c815e4cfeecf59bcf99a06dd25e734629 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I888c514c815e4cfeecf59bcf99a06dd25e734629 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix a typo in log message for export/import
by ahadas＠redhat.com 19 Jul '16

19 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix a typo in log message for export/import ...................................................................... core: fix a typo in log message for export/import log.info("Conversion of VM from exteral enironment failed: {}", was replaced to: log.info("Conversion of VM from external environment failed: {}", Change-Id: Ifcfeabc66463abe41005128e4ab5a83b8a81000a Bug-Url: https://bugzilla.redhat.com/1356996 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcfeabc66463abe41005128e4ab5a83b8a81000a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix UI exception after creating new profile
by tnisan＠redhat.com 19 Jul '16

19 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix UI exception after creating new profile ...................................................................... webadmin: Fix UI exception after creating new profile This prevents a race occuring when the query result from syncSearch has returned and fetchProfiles() was called yet the entity meanwhile was changed to null Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Bug-Url: https://bugzilla.redhat.com/1354547 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/ProfileListModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51515a03b15ebf9c10ac34924e09c7cde50d2402 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Release 4.0.0.a5
by omachace＠redhat.com 19 Jul '16

19 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Release 4.0.0.a5 ...................................................................... Release 4.0.0.a5 Change-Id: I349ef5680aa240a7ab819a414d63885945465bcc Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M packaging/build.sh M sdk/lib/ovirtsdk4/version.py M sdk/setup.py 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I349ef5680aa240a7ab819a414d63885945465bcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.1.6
by juan.hernandez＠redhat.com 19 Jul '16

19 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.1.6 ...................................................................... Update to model 4.1.6 The more relevant changes in the new version of the model are the following: * Add the `originalTemplate` link to the virtual machine type. * Add `permits` to the cluster level type. * Add the `current` parameter to the virtual machine graphics consoles service. * Fix the name of the output parameter of the method to list affinity groups, should be `groups` instead of `list`. Change-Id: I86af813e79701f2f922f6e60a14dda83cab139c1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86af813e79701f2f922f6e60a14dda83cab139c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0