Change in ovirt-engine[ovirt-engine-4.0.2]: core: Support migrating the HE VM out of cluster
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Support migrating the HE VM out of cluster
......................................................................
core: Support migrating the HE VM out of cluster
This would allow migrating the hosted engine VM out of the cluster. This
is specifically needed in case where we want to migrate old cluster
version to a new cluster, with new version.
Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8
Bug-Url: https://bugzilla.redhat.com/1351533
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
2 files changed, 44 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
Jenny Tokar: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: Support migrating the HE VM out of cluster
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Support migrating the HE VM out of cluster
......................................................................
core: Support migrating the HE VM out of cluster
This would allow migrating the hosted engine VM out of the cluster. This
is specifically needed in case where we want to migrate old cluster
version to a new cluster, with new version.
Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8
Bug-Url: https://bugzilla.redhat.com/1351533
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
2 files changed, 44 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
Jenny Tokar: Looks good to me, but someone else must approve
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: GetHostJobsVDSCommand - reported progress is a Double
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: GetHostJobsVDSCommand - reported progress is a Double
......................................................................
core: GetHostJobsVDSCommand - reported progress is a Double
The progress retrived from vdsm code is Double, this patch aligns the code
to handle it as such.
Change-Id: Id1e95649e9d4c01e5f92ac1174b5e2645749dd16
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetHostJobsVDSCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1e95649e9d4c01e5f92ac1174b5e2645749dd16
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: CopyDataCommand - use SDM.copy_data verb
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: CopyDataCommand - use SDM.copy_data verb
......................................................................
core: CopyDataCommand - use SDM.copy_data verb
This patch changes CopyDataCommand to use the new SDM.copy_data along
with the required VDS command changes (as the api was changed since the
command was introduced).
Change-Id: I678cf26ae083f757a39eb6931664cae43cd1df9f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LocationInfoHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyVolumeDataVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CopyVolumeDataVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
8 files changed, 33 insertions(+), 34 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I678cf26ae083f757a39eb6931664cae43cd1df9f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: rm DoesImageExistVDSCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: rm DoesImageExistVDSCommand
......................................................................
core: rm DoesImageExistVDSCommand
DoesImageExistVDSCommand is a subclass of GetImageInfoVDSCommand
and is used to determine if the image exists.
The difference between this command and GetImageInfo is that GetImageInfo
parses to return value into a object.
As this command is executed as part of the validation when doing import,
we can simply use GetImageInfo and delete DoesImageExistVDSCommand.
Change-Id: I9b431ee842cf87b8b6378ef2641d64d2fa68df42
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DoesImageExistVDSCommand.java
3 files changed, 2 insertions(+), 43 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/60956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b431ee842cf87b8b6378ef2641d64d2fa68df42
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: GetImageInfo to use GetVolumeInfo
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: GetImageInfo to use GetVolumeInfo
......................................................................
core: GetImageInfo to use GetVolumeInfo
GetImageInfoVDSCommand is an IRS command that executes getVolumeInfo
on the SPM.
Additionally, we have the GetVolumeInfoVDSCommand that executes getVolumeInfo on
the passed host in the parameters.
Currently GetVolumeInfoVDSCommand doesn't return the actual image info, but only if it
managed to get the volume information. As we need to use it to get the actual info
instead of duplicating the code or exporting it to a helper class we can change GetImageInfo
to use GetVolumeInfo and to pass it the SPM host id, maintaining the same behavior with less
code.
Change-Id: Iebfd4678e2422352567cba61ca363348867541c2
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java
8 files changed, 83 insertions(+), 175 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/60957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebfd4678e2422352567cba61ca363348867541c2
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: BaseImagesCommand - isDataOperationsByHSM() logic
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: BaseImagesCommand - isDataOperationsByHSM() logic
......................................................................
core: BaseImagesCommand - isDataOperationsByHSM() logic
SDM flows would be implemented in such a way that in case that the host
which is performing the operation will go non responsive we'll be able
to poll using a different host by check the actual entity on the storage.
In order to do that on oVirt images, we intend to use the volume leases
so we can determine if the operation on the volume was ended or is still
running.
Export domains and local storage domains doesn't support volume leases
therefore if the performing host goes non responsive there's no way to track
the operation, therefore the SDM verbs aren't supposed to support those.
This patches update isDataOperationsByHSM() to return false if the domain
isn't data domain or if it is a local domain.
Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
1 file changed, 16 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/60964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: IrsProxyData - pool status/domain status SDM logic
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: IrsProxyData - pool status/domain status SDM logic
......................................................................
core: IrsProxyData - pool status/domain status SDM logic
This patch removes the remains of the IrsProxyData SDM changes
as we keep relying on the SPM for now.
Change-Id: I6eabba9cb4afe6b4e2b49300bd0195998e208d31
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 2 insertions(+), 22 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/61086
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eabba9cb4afe6b4e2b49300bd0195998e208d31
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: StorageJobCommand/Parameters - job id generation
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: StorageJobCommand/Parameters - job id generation
......................................................................
core: StorageJobCommand/Parameters - job id generation
The command should generate the job id only if not present.
There's no need to generate the job id in the command parameters class.
Change-Id: Iacaeb45c4db22fe15815d4f4823c0e07f64b65fd
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/61084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacaeb45c4db22fe15815d4f4823c0e07f64b65fd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: CreateVolumeParameters - set srcImageId
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: CreateVolumeParameters - set srcImageId
......................................................................
core: CreateVolumeParameters - set srcImageId
Change-Id: Iaeb9ede9a1de7ab99555a646cf3cdcbd0e644133
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeParameters.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61344
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaeb9ede9a1de7ab99555a646cf3cdcbd0e644133
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months