July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Restapi access should create sessions only if persisten...
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Restapi access should create sessions only if persistent_auth is requested ...................................................................... aaa: Restapi access should create sessions only if persistent_auth is requested Restapi authentication filters should not create sessions for bearer auth, only basic auth requests should have sessions created. Change-Id: I6f769c358e32637fa6289636542dd8548f786069 Bug-Url: https://bugzilla.redhat.com/1358434 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiAuthFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiNegotiationFilter.java 3 files changed, 4 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f769c358e32637fa6289636542dd8548f786069 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: after dwh build for 4.0.2
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after dwh build for 4.0.2 ...................................................................... build: after dwh build for 4.0.2 Change-Id: I2e6e217691600bf90bb12435b0064959d4cbc9e5 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e6e217691600bf90bb12435b0064959d4cbc9e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: dwh build for 4.0.2
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.0.2 ...................................................................... build: dwh build for 4.0.2 Change-Id: I0cbe7e2eb772d2d035d44d1b418fdeed9cb76c29 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cbe7e2eb772d2d035d44d1b418fdeed9cb76c29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Add V3 support for disks detail
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Add V3 support for disks detail ...................................................................... restapi: Add V3 support for disks detail Version 3 of the API supports a `detail` parameter that can be used to include inline details into certain objects. In particular it can be used to request details about the disks of a virtual machine: GET /ovirt-engine/api/vms Version: 3 Accept: application/xml; detail=disks This capability has been removed in version 4 of the API, but needs to be preserved in version 3, and it works for all the objects that it used to work, except for disks, because the "disks" collection has been replaced with "diskattachments". To fix this issue this patch moves the logic that handles the "detail" parameter to the V3 compatibility layer, where the "disks" collection still exists. Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit aad61b8c3c1911983c8851d7b04aa8ed67819d96) (cherry picked from commit 37e1269dd6fcb11958cd945875aa70ce6b43233f) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 5 files changed, 51 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Fix V3 VM and template disks collection links
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix V3 VM and template disks collection links ...................................................................... restapi: Fix V3 VM and template disks collection links The "disks" collection has been replaced by "diskattachments" in version 4 of the API. As a result the V3 links for the "disks" collectin can't be reliably calculated. This patch changes the V3 layer so that it discards the links calculated by V4 and replaces them with the correct ones. Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8993ba46f25231e43e3ab56e1afc6c49c09ac1cd) (cherry picked from commit 26c0fad4b7ac0f13326030b119bff6b3de965cdf) --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 11 files changed, 190 insertions(+), 87 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add V3 support for disks detail
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Add V3 support for disks detail ...................................................................... restapi: Add V3 support for disks detail Version 3 of the API supports a `detail` parameter that can be used to include inline details into certain objects. In particular it can be used to request details about the disks of a virtual machine: GET /ovirt-engine/api/vms Version: 3 Accept: application/xml; detail=disks This capability has been removed in version 4 of the API, but needs to be preserved in version 3, and it works for all the objects that it used to work, except for disks, because the "disks" collection has been replaced with "diskattachments". To fix this issue this patch moves the logic that handles the "detail" parameter to the V3 compatibility layer, where the "disks" collection still exists. Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit aad61b8c3c1911983c8851d7b04aa8ed67819d96) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 5 files changed, 51 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix V3 VM and template disks collection links
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix V3 VM and template disks collection links ...................................................................... restapi: Fix V3 VM and template disks collection links The "disks" collection has been replaced by "diskattachments" in version 4 of the API. As a result the V3 links for the "disks" collectin can't be reliably calculated. This patch changes the V3 layer so that it discards the links calculated by V4 and replaces them with the correct ones. Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8993ba46f25231e43e3ab56e1afc6c49c09ac1cd) --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 11 files changed, 190 insertions(+), 87 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: history: lower sampling interval
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: history: lower sampling interval ...................................................................... history: lower sampling interval Change-Id: I81723c713e632d18112ae97253b33e9f3baec13c Bug-Url: https://bugzilla.redhat.com/1349309 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/historyetl_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/samplerunjobs_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/sampletimekeepingjob_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/statisticssync_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/validateinstallation_4_0/contexts/Default.properties M etl_export/src/main/java/ovirt_engine_dwh/aggregationtohourly_4_0/AggregationToHourly.java M etl_export/src/main/java/ovirt_engine_dwh/statisticssync_4_0/StatisticsSync.java M etl_export/src/main/resources/ovirt_engine_dwh/historyetl_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/samplerunjobs_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/sampletimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/statisticssync_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/validateinstallation_4_0/contexts/Default.properties M packaging/dbscripts/create_views_3_6.sql M packaging/dbscripts/create_views_4_0.sql A packaging/dbscripts/upgrade/04_00_0050_added_seconds_in_status_to_sample_tables.sql M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M tos_project/context/connectionJDBC_4.0.item M tos_project/context/connectionJDBC_4.0.properties M tos_project/process/AggregationToHourly_4.0.item M tos_project/process/AggregationToHourly_4.0.properties M tos_project/process/HistoryETL_4.0.item M tos_project/process/HistoryETL_4.0.properties M tos_project/process/ParallelRun_4.0.item M tos_project/process/ParallelRun_4.0.properties M tos_project/process/SampleRunJobs_4.0.item M tos_project/process/SampleRunJobs_4.0.properties M tos_project/process/SampleTimeKeepingJob_4.0.item M tos_project/process/SampleTimeKeepingJob_4.0.properties M tos_project/process/StatisticsSync_4.0.item M tos_project/process/StatisticsSync_4.0.properties M tos_project/process/ValidateInstallation_4.0.item M tos_project/process/ValidateInstallation_4.0.properties 34 files changed, 676 insertions(+), 501 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Objections: Michal Skrivanek: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/60887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81723c713e632d18112ae97253b33e9f3baec13c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: lower sampling interval
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: history: lower sampling interval ...................................................................... history: lower sampling interval Change-Id: I81723c713e632d18112ae97253b33e9f3baec13c Bug-Url: https://bugzilla.redhat.com/1349309 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/historyetl_4_1/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_4_1/contexts/Default.properties M etl_export/ovirt_engine_dwh/samplerunjobs_4_1/contexts/Default.properties M etl_export/ovirt_engine_dwh/sampletimekeepingjob_4_1/contexts/Default.properties M etl_export/ovirt_engine_dwh/statisticssync_4_1/contexts/Default.properties M etl_export/ovirt_engine_dwh/validateinstallation_4_1/contexts/Default.properties M etl_export/src/main/java/ovirt_engine_dwh/aggregationtohourly_4_1/AggregationToHourly.java M etl_export/src/main/java/ovirt_engine_dwh/statisticssync_4_1/StatisticsSync.java M etl_export/src/main/resources/ovirt_engine_dwh/historyetl_4_1/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/parallelrun_4_1/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/sampletimekeepingjob_4_1/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/statisticssync_4_1/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/validateinstallation_4_1/contexts/Default.properties M packaging/dbscripts/create_views_3_6.sql M packaging/dbscripts/create_views_4_0.sql M packaging/dbscripts/create_views_4_1.sql A packaging/dbscripts/upgrade/04_01_0010_added_seconds_in_status_to_sample_tables.sql M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M tos_project/context/connectionJDBC_4.1.item M tos_project/context/connectionJDBC_4.1.properties M tos_project/process/AggregationToHourly_4.1.item M tos_project/process/AggregationToHourly_4.1.properties M tos_project/process/HistoryETL_4.1.item M tos_project/process/HistoryETL_4.1.properties M tos_project/process/ParallelRun_4.1.item M tos_project/process/ParallelRun_4.1.properties M tos_project/process/SampleRunJobs_4.1.item M tos_project/process/SampleRunJobs_4.1.properties M tos_project/process/SampleTimeKeepingJob_4.1.item M tos_project/process/SampleTimeKeepingJob_4.1.properties M tos_project/process/StatisticsSync_4.1.item M tos_project/process/StatisticsSync_4.1.properties M tos_project/process/ValidateInstallation_4.1.item M tos_project/process/ValidateInstallation_4.1.properties 34 files changed, 717 insertions(+), 512 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81723c713e632d18112ae97253b33e9f3baec13c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: Packaging: spec: Make engine-setup require jre 1.8
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Packaging: spec: Make engine-setup require jre 1.8 ...................................................................... Packaging: spec: Make engine-setup require jre 1.8 oVirt engine 3.6 could have worked with either jre 1.7 or 1.8. 4.0 requires 1.8. But engine-setup checks if required java version is available prior to upgrading the engine. So engine-setup will fail when upgrading from 3.6 with 1.7. Fix this by requiring the correct version by the package setup-plugin-ovirt-engine-common, which is where the check is done. Change-Id: I059daa2533e62ba3370608a507797f2b898f3235 Bug-Url: https://bugzilla.redhat.com/1350397 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 35f51a719f64ad4863eccc40bc32ba6061e56303) (cherry picked from commit bf2a5cee496ffbd5174876289c728d065f8e28b5) --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059daa2533e62ba3370608a507797f2b898f3235 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0