Change in ovirt-engine[master]: core: GetAllFromExportDomainQuery type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetAllFromExportDomainQuery type inference
......................................................................
core: GetAllFromExportDomainQuery type inference
Change-Id: Ifa84f291dc238f3545681a85897c565ad3504f9f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetAllFromExportDomainQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/61355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa84f291dc238f3545681a85897c565ad3504f9f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: GetAllFromExportDomainQuery DbFacade access
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetAllFromExportDomainQuery DbFacade access
......................................................................
core: GetAllFromExportDomainQuery DbFacade access
Change-Id: Ib3c6d2c7e713d984c11ed4eae400aecb90ab1e22
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetAllFromExportDomainQuery.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/61356
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3c6d2c7e713d984c11ed4eae400aecb90ab1e22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: webadmin: Unneeded Vdsm call when editing iSCSI SD
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Unneeded Vdsm call when editing iSCSI SD
......................................................................
webadmin: Unneeded Vdsm call when editing iSCSI SD
When editing an existing iSCSI, we need to get from Vdsm the list of
available LUNs.
However, due to multiple events triggered, we are sending the VDSM query
more than needed.
In this patch, we are minimizing the handling of the events triggered and
therefore the queries from 6 to 2 in the edit SD flow.
Change-Id: Ic6f5db4f74efaad05a6b84e14d12a700efc27b50
Bug-Url: https://bugzilla.redhat.com/1259353
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/59990
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6f5db4f74efaad05a6b84e14d12a700efc27b50
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: webadmin: Hide hosted engine tab when editing host
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Hide hosted engine tab when editing host
......................................................................
webadmin: Hide hosted engine tab when editing host
The hosted engine tab in host editing or adding dialog
in the ui is only relevant when adding a new host.
This patch hides the tab when a host is edited.
To achieve this the initialization of the popup window
was moved after the host model initialization.
This allows setting the visibility for hostedEngineTab in
HostPopupView by using the getIsNew method (was already
implemented but didn't work since the relevant fields
weren't initialized).
Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9
Bug-Url: https://bugzilla.redhat.com/1350423
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/61093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Add V3 payload adapter
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: restapi: Add V3 payload adapter
......................................................................
restapi: Add V3 payload adapter
This patch adds the missing V3 adapters for the "payloads" object.
Change-Id: Id267d3f580a63de9f1f5abcf9c577f5cbb98679e
Bug-Url: https://bugzilla.redhat.com/1359885
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 95f5a6b3ae48392376171c710a040b48e0f53370)
(cherry picked from commit e4a6a9c440a4391fc9dd984b2e1e684c9eec405f)
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3PayloadsInAdapter.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3PayloadsOutAdapter.java
2 files changed, 64 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id267d3f580a63de9f1f5abcf9c577f5cbb98679e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0.2]: sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing u...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing units
......................................................................
sla: Mark CPU_OVERCOMMIT_DURATION as editable in balancing units
This patch re-adds the CPU_OVERCOMMIT_DURATION field to the
scheduling unit annotations to make it visible in the UI and
editable in the scheduling policy dialogs.
Change-Id: I215cbc9bef44771259c5747a24b01321a3b0e005
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339640
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
2 files changed, 20 insertions(+), 18 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I215cbc9bef44771259c5747a24b01321a3b0e005
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Improve the way logging works
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve the way logging works
......................................................................
webadmin,userportal: Improve the way logging works
1. all logging related code extracted into ApplicationLogManager
2. added "error is effectively the same as last one" detection:
* on 1st occurence, error is logged as "Uncaught exception"
* on 2nd occurence, error is logged as "Uncaught exception (2x)"
* same message for any further occurences of the same error
3. error is remotely logged ONLY if both of following are true:
* application (browser) window has focus
* current error is NOT effectively the same as last one
An error E1 is effectively the same as error E2 if and only if
E1's stack trace has the same length as E2's stack trace and the
stack trace elements are equal at any given index.
Due to how GWT emulates java.lang.StackTraceElement, we're using
StackTraceElement.toString() to capture all important info:
declaringClass
methodName
fileName
lineNumber
Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2
Bug-Url: https://bugzilla.redhat.com/1358136
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ApplicationLogManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
6 files changed, 149 insertions(+), 54 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/61411
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: engine: fix background image on welcome and login pages
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: engine: fix background image on welcome and login pages
......................................................................
engine: fix background image on welcome and login pages
Apply the background image technique used in patternfly's login
page pattern to the welcome and login pages. This change will
prevent the background image from being truncated if the welcome
or login page is made short enough to scroll.
Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Bug-Url: https://bugzilla.redhat.com/1347807
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M packaging/branding/ovirt.brand/common.css
9 files changed, 339 insertions(+), 355 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/61361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.1.2
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-2.0.1.2
......................................................................
build: post ovirt-hosted-engine-setup-2.0.1.2
Change-Id: I85a2a38e7fe760c4af5c0b75408e00cd40c94ae2
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M configure.ac
M ovirt-hosted-engine-setup.spec.in
3 files changed, 11 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61406
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85a2a38e7fe760c4af5c0b75408e00cd40c94ae2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
7 years, 9 months
Change in ovirt-engine[master]: webadmin, userportal: Improve the way logging works
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve the way logging works
......................................................................
webadmin,userportal: Improve the way logging works
1. all logging related code extracted into ApplicationLogManager
2. added "error is effectively the same as last one" detection:
* on 1st occurence, error is logged as "Uncaught exception"
* on 2nd occurence, error is logged as "Uncaught exception (2x)"
* same message for any further occurences of the same error
3. error is remotely logged ONLY if both of following are true:
* application (browser) window has focus
* current error is NOT effectively the same as last one
An error E1 is effectively the same as error E2 if and only if
E1's stack trace has the same length as E2's stack trace and the
stack trace elements are equal at any given index.
Due to how GWT emulates java.lang.StackTraceElement, we're using
StackTraceElement.toString() to capture all important info:
declaringClass
methodName
fileName
lineNumber
Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2
Bug-Url: https://bugzilla.redhat.com/1358136
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ApplicationLogManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
6 files changed, 150 insertions(+), 52 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months