July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove VmDeviceUtils#EMPTY_SPEC_PARAMS
by amureini＠redhat.com 18 Jul '16

18 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmDeviceUtils#EMPTY_SPEC_PARAMS ...................................................................... core: Remove VmDeviceUtils#EMPTY_SPEC_PARAMS The constant conveys no extra information other than being an empty map, so there's no value in keeping it instead of just calling Collections#emptyMap() instead. Change-Id: I67dab16eb66df90f8d1689b65ef8bebd11d9082a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67dab16eb66df90f8d1689b65ef8bebd11d9082a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: image upload - propagate validation messages
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: image upload - propagate validation messages ...................................................................... core: image upload - propagate validation messages Propagate validation messages in UploadDiskImageCommand. Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Bug-Url: https://bugzilla.redhat.com/1352857 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: disk tab - storage domain selection on upload
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: disk tab - storage domain selection on upload ...................................................................... webadmin: disk tab - storage domain selection on upload Disk tab -> upload: Data Center and Storage Domains select-boxes should be changeable. Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Bug-Url: https://bugzilla.redhat.com/1352928 Bug-Url: https://bugzilla.redhat.com/1352855 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Disk upload dialog - update image type
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disk upload dialog - update image type ...................................................................... webadmin: Disk upload dialog - update image type Disk Upload dialog: 'Image Type' select-box - format should be selected according to the StorageType and VolumeType. Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Bug-Url: https://bugzilla.redhat.com/1353229 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 15 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix disable of the entire edit disk popup when VM ...
by tnisan＠redhat.com 18 Jul '16

18 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disable of the entire edit disk popup when VM is running ...................................................................... webadmin: Fix disable of the entire edit disk popup when VM is running Change I14dcbfb50a6249de6380346469baa055f7130662 (937704c5) introduced the ReadOnlyDiskModel used for image upload purposes, to decide whether to disable the entire dialog it used the isEditEnabled() methods from the parent model which although the misleading does not mean that the entire panel should be disabled but whether properties that are no editable when the VM is up should be disabled, this cause the edit dialog to be disabled at all times. This fixes it by calling getIsModelDisabled() after the initial load of the data centers Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74 Bug-Url: https://bugzilla.redhat.com/1349498 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 2 files changed, 3 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: bll: search: don't replace all ocurrence of pattern
by mperina＠redhat.com 18 Jul '16

18 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: bll: search: don't replace all ocurrence of pattern ...................................................................... bll: search: don't replace all ocurrence of pattern Previously we replaced all occurances of pattern in search text, which could lead in replacing unwanted characters. This patch changes the behaviour in a way, that we just replace first found characters. Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356675 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I659b9a6043643cc3ad2358bb12fa46cadb6e0f4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Upload drop-down menu button
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Upload drop-down menu button ...................................................................... webadmin: Upload drop-down menu button Added 'Upload' drop-down menu button to Disks tab to consolidate Start/Cancel/Pause resume commands. Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Before: http://i.imgur.com/yWbcCSO.png After: http://i.imgur.com/v1aCFJe.png Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 33 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/60699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Disk upload dialog - update image type
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disk upload dialog - update image type ...................................................................... webadmin: Disk upload dialog - update image type Disk Upload dialog: 'Image Type' select-box - format should be selected according to the StorageType and VolumeType. Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Bug-Url: https://bugzilla.redhat.com/1353229 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 15 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/60700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c3bc4584cb917d908c9109b89f4d6ba337b47f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Remove code duplication in v2v providers
by mbetak＠redhat.com 18 Jul '16

18 Jul '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Remove code duplication in v2v providers ...................................................................... backend: Remove code duplication in v2v providers The KVM, Vmware and XEN ProviderProxies contained significtant portion of duplicate that was extracted into new AbstractVmProviderProxy base class. For this purpose also their respective parameter classes now extend VmProviderProperties class containing shared fields on which AbstractVmProviderProxy depends. Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/AbstractVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/KVMVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/XENVmProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/KVMVmProviderProperties.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmwareVmProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/XENVmProviderProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 136 insertions(+), 248 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Disable Scan disks option for Export and ISO.
by mlipchuk＠redhat.com 18 Jul '16

18 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Disable Scan disks option for Export and ISO. ...................................................................... webadmin: Disable Scan disks option for Export and ISO. Scan Disks option should be disabled for export and ISO storage domain. Change-Id: I8ce142e5e1bff0aeeb0e44cad97990a1c4fd3502 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ce142e5e1bff0aeeb0e44cad97990a1c4fd3502 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0