July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: disk tab - storage domain selection on upload
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disk tab - storage domain selection on upload ...................................................................... webadmin: disk tab - storage domain selection on upload Disk tab -> upload: Data Center and Storage Domains select-boxes should be changeable. Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Bug-Url: https://bugzilla.redhat.com/1352928 Bug-Url: https://bugzilla.redhat.com/1352855 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a999af0b8c6c9b9a509ec1bfac13371cdcace62 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: image upload - propagate validation messages
by derez＠redhat.com 18 Jul '16

18 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: core: image upload - propagate validation messages ...................................................................... core: image upload - propagate validation messages Propagate validation messages in UploadDiskImageCommand. Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Bug-Url: https://bugzilla.redhat.com/1352857 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d408a4393953a7ba6ba4aa34b30f69686eb754c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: MoveOrCopyDisk - adjusting to dc with HSM data operations
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: MoveOrCopyDisk - adjusting to dc with HSM data operations ...................................................................... MoveOrCopyDisk - adjusting to dc with HSM data operations Change-Id: Iab47a9e52dc7fed75bb9866e4bfa63bf90dc85de Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab47a9e52dc7fed75bb9866e4bfa63bf90dc85de Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroup - adjusting to dc with HSM data operations
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroup - adjusting to dc with HSM data operations ...................................................................... core: CopyImageGroup - adjusting to dc with HSM data operations Change-Id: I76e25e72523800b59301a7cc0e7886af0a2de805 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 90 insertions(+), 53 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e25e72523800b59301a7cc0e7886af0a2de805 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CloneImageGroupVolumesStructure - support disks based ...
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructure - support disks based on templates ...................................................................... core: CloneImageGroupVolumesStructure - support disks based on templates This patch adjusts CloneImageGroupVolumesStructureCommand to support disks based on template disks. The command will inspect the cloned image, if it's based on template the template image group id will be used as the source image group. Change-Id: I2232a97f62f4ad8d25b0cc18db84941661c6b947 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2232a97f62f4ad8d25b0cc18db84941661c6b947 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeContainer - use the SPM.createVolume() verb
by laravot＠redhat.com 18 Jul '16

18 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeContainer - use the SPM.createVolume() verb ...................................................................... core: CreateVolumeContainer - use the SPM.createVolume() verb This patch updates the CreateVolumeContainerCommand to use to SPM.createVolume() verb instead of the SDM.createVolume(). Change-Id: I46e83652e5c504a27a0608205b967568aa818fe9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeContainerCommandParameters.java 2 files changed, 40 insertions(+), 24 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46e83652e5c504a27a0608205b967568aa818fe9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: source column is not needed in Pools "Disk Allocation"
by shavivi＠redhat.com 17 Jul '16

17 Jul '16

Shahar Havivi has submitted this change and it was merged. Change subject: ui: source column is not needed in Pools "Disk Allocation" ...................................................................... ui: source column is not needed in Pools "Disk Allocation" Bug-Url: https://bugzilla.redhat.com/1356492 Change-Id: I3d5d22478a9242cb2fb9ce790088c1acff829723 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d5d22478a9242cb2fb9ce790088c1acff829723 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupCommand - use getTaskIdList()
by laravot＠redhat.com 17 Jul '16

17 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupCommand - use getTaskIdList() ...................................................................... core: CopyImageGroupCommand - use getTaskIdList() Change-Id: I38b292b45b33f97294f071d79203720326bac7e9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/58542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b292b45b33f97294f071d79203720326bac7e9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImagesActionsParametersBase - export filling of the en...
by laravot＠redhat.com 17 Jul '16

17 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: ImagesActionsParametersBase - export filling of the entity info ...................................................................... core: ImagesActionsParametersBase - export filling of the entity info This patch exports the logic used to fill the entity info so that it can be reused in the class hirerchy. Change-Id: Iac3fd163a3d40119fe02a46dc07ad7643fead5cb Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac3fd163a3d40119fe02a46dc07ad7643fead5cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix test in VmDeviceDaoTest
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix test in VmDeviceDaoTest ...................................................................... core: Fix test in VmDeviceDaoTest Fix testUpdateVmDeviceUsingScsiReservationProperty to actually load the entity to compare the value of using usingScsiReservation rather than redundantly compare the entity's usingScsiReservation to what we set it to Change-Id: I0fa5916dfec1d100acde5212fc4b13d94d9ecb5c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa5916dfec1d100acde5212fc4b13d94d9ecb5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0