Change in ovirt-engine[master]: webadmin: Add Tooltip with VM shutdown reason
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Add Tooltip with VM shutdown reason
......................................................................
webadmin: Add Tooltip with VM shutdown reason
Added Status-column Tooltip in webadmin's VM Maintab
displaying optional reason of VM shut down.
Change-Id: Id789a35f8fdf66b3bba2c7dba01800a0b95925ca
Bug-Url: https://bugzilla.redhat.com/1317584
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/60399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id789a35f8fdf66b3bba2c7dba01800a0b95925ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: restapi: instance type not reported for pools
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: instance type not reported for pools
......................................................................
restapi: instance type not reported for pools
Added the same way as the templates have it.
Change-Id: Iae0c7b5c4f17ad7961ed41da196dbc4e1217db2a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310804
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae0c7b5c4f17ad7961ed41da196dbc4e1217db2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-ha[v2.0.z]: Fix size calculation when zeroing VDSM volumes
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Fix size calculation when zeroing VDSM volumes
......................................................................
Fix size calculation when zeroing VDSM volumes
Instead of os.stat().st_size, which works only on regular files,
open the file and seek to the end.
Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995
Bug-Url: https://bugzilla.redhat.com/1346341
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit b8b85afa1dcbf3810eaee4acdb0b97a45187403a)
---
M ovirt_hosted_engine_ha/lib/storage_backends.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/60269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.0.z
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Fix relation between DiskVmElements to VmDevices in fi...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix relation between DiskVmElements to VmDevices in fixures.xml
......................................................................
core: Fix relation between DiskVmElements to VmDevices in fixures.xml
The relation between the VMs to disks and VM to devices in fixtures.xml
was not symmetrical, this patch fixes it
Change-Id: Idcb5cddd99269403e8007f3c30e762439556c34a
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb5cddd99269403e8007f3c30e762439556c34a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Fix typo in BaseReadDaoTestCase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix typo in BaseReadDaoTestCase
......................................................................
core: Fix typo in BaseReadDaoTestCase
Rename getEneitiesTotalCount() to getEntitiesTotalCount()
Change-Id: I14f8192730317b988a6fd0134c5288cc525ab5a3
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseReadDaoTestCase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CommandEntityDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDefaultDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/storage/LibvirtSecretDaoTest.java
19 files changed, 21 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14f8192730317b988a6fd0134c5288cc525ab5a3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Rename GetAll stored procedure name for DiskVmElement
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Rename GetAll stored procedure name for DiskVmElement
......................................................................
core: Rename GetAll stored procedure name for DiskVmElement
Rename GetAllFromDiskVmElement() to use the plural form
GetAllFromDiskVmElements() as per DefaultReadDao standards
Change-Id: Ic6cfcd7bff2081708d6dec82dda719b762c348b4
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M packaging/dbscripts/disk_vm_element_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6cfcd7bff2081708d6dec82dda719b762c348b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Add DiskVmElementDaoTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add DiskVmElementDaoTest
......................................................................
core: Add DiskVmElementDaoTest
Change-Id: Ibc506efb9dd270dfcbc473419ba0e47e53071513
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java
1 file changed, 72 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc506efb9dd270dfcbc473419ba0e47e53071513
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in jenkins[master]: Added jenkins report job
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Added jenkins report job
......................................................................
Added jenkins report job
Like in D/S, I have added a job with groovy script
that sends a report about all unstable jobs
Change-Id: I9b9236dbdae3eb9a2f9cf519210f27a11739aa74
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
A jobs/confs/groovy-scripts/system_report.groovy
A jobs/confs/yaml/system_jobs.yaml
2 files changed, 129 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60441
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b9236dbdae3eb9a2f9cf519210f27a11739aa74
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: remove unaccessible memory during upgrade
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove unaccessible memory during upgrade
......................................................................
core: remove unaccessible memory during upgrade
This patch fixes an issue discovered in the upgrade process where the
upgrade fails while trying to convert memory volumes on a storage
domain that does not exist in the system to disk images.
So before doing the conversion, such memory volumes are first being
removed. They are unusable anyway.
Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Bug-Url: https://bugzilla.redhat.com/1353219
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60443
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Removing VmPoolUserCommandBase class
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Removing VmPoolUserCommandBase class
......................................................................
core: Removing VmPoolUserCommandBase class
Merging VmPoolUserCommandBase into AttachUserToVmFromPoolAndRunCommand:
* VmPoolUserCommandBase removed;
* initPoolUser() method moved into AttachUserToVmFromPoolAndRunCommand;
* VmPoolUserParameters renamed to
AttachUserToVmFromPoolAndRunParameters;
* VmPoolSimpleUserCommandBase renamed to VmPoolUserCommandBase;
* VmPoolSimpleUserParameters renamed to VmPoolUserParameters.
Change-Id: I76e689324b9eda80e614e77ae5b9e02d74b15eda
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolUserCommandBase.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachUserFromVmFromPoolParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolSimpleUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolUserParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java
11 files changed, 119 insertions(+), 133 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60442
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76e689324b9eda80e614e77ae5b9e02d74b15eda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months