Change in ovirt-engine[master]: core: CreateBrickCommandTest type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CreateBrickCommandTest type inference
......................................................................
core: CreateBrickCommandTest type inference
Change-Id: I8135ec86c6f29e2e867e59f331a6f595934bde0f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/60304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8135ec86c6f29e2e867e59f331a6f595934bde0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: CreateBrickCommandTest collections
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CreateBrickCommandTest collections
......................................................................
core: CreateBrickCommandTest collections
Used Collections#singletonList instead of Arrays#asList for single
element "constant" collections to gain a [minor] performance
improvement.
Change-Id: I38d164d6b621fbfa461d24509d83f9a1f07fe9c9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/60305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38d164d6b621fbfa461d24509d83f9a1f07fe9c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: upgrade: rework the upgrade tool
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: rework the upgrade tool
......................................................................
upgrade: rework the upgrade tool
We cannot upgrade switching to a new disk, so we identified a
different flow creating a backup of the current disk and
deploying in place the new appliance.
Depends-on: https://gerrit.ovirt.org/60054
Change-Id: I409d9143642601b28f54109864fe4b298be9ca38
Bug-Url: https://bugzilla.redhat.com/1319457
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M man/hosted-engine.8
M man/ovirt-hosted-engine-setup.8
M po/POTFILES.in
M po/pt_BR.po
M src/bin/hosted-engine.in
M src/bin/ovirt-hosted-engine-setup
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/tasks.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/Makefile.am
M src/plugins/gr-he-common/core/misc.py
M src/plugins/gr-he-common/core/remote_answerfile.py
M src/plugins/gr-he-common/engine/ca.py
M src/plugins/gr-he-common/engine/health.py
M src/plugins/gr-he-common/vm/boot_disk.py
M src/plugins/gr-he-common/vm/cloud_init.py
M src/plugins/gr-he-common/vm/misc.py
A src/plugins/gr-he-rollbackupgrade/Makefile.am
A src/plugins/gr-he-rollbackupgrade/core/Makefile.am
A src/plugins/gr-he-rollbackupgrade/core/__init__.py
A src/plugins/gr-he-rollbackupgrade/core/misc.py
M src/plugins/gr-he-upgradeappliance/core/misc.py
M src/plugins/gr-he-upgradeappliance/engine/Makefile.am
M src/plugins/gr-he-upgradeappliance/engine/__init__.py
D src/plugins/gr-he-upgradeappliance/engine/add_vm_disk.py
A src/plugins/gr-he-upgradeappliance/engine/misc.py
M src/plugins/gr-he-upgradeappliance/vm/configurevm.py
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
29 files changed, 1,328 insertions(+), 531 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I409d9143642601b28f54109864fe4b298be9ca38
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in jenkins[master]: mom: refresh supported distributions
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: mom: refresh supported distributions
......................................................................
mom: refresh supported distributions
- remove EOL fedora 22
- replace fedora 23 with new released fedora 24 for master
- remove el6 since vdsm is not supported there since 3.6
Change-Id: I6df7452b8acb5d8784be3b1217524ad89dc67617
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/mom/mom_create-rpms.yaml
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Eyal Edri: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60274
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6df7452b8acb5d8784be3b1217524ad89dc67617
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-setup[master]: upgrade: rework the upgrade tool
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: rework the upgrade tool
......................................................................
upgrade: rework the upgrade tool
We cannot upgrade switching to a new disk, so we identified a
different flow creating a backup of the current disk and
deploying in place the new appliance.
Depends-on: https://gerrit.ovirt.org/60054
Change-Id: I409d9143642601b28f54109864fe4b298be9ca38
Bug-Url: https://bugzilla.redhat.com/1319457
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M man/hosted-engine.8
M man/ovirt-hosted-engine-setup.8
M po/POTFILES.in
M po/pt_BR.po
M src/bin/hosted-engine.in
M src/bin/ovirt-hosted-engine-setup
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/tasks.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/Makefile.am
M src/plugins/gr-he-common/core/misc.py
M src/plugins/gr-he-common/core/remote_answerfile.py
M src/plugins/gr-he-common/engine/ca.py
M src/plugins/gr-he-common/engine/health.py
M src/plugins/gr-he-common/vm/boot_disk.py
M src/plugins/gr-he-common/vm/cloud_init.py
M src/plugins/gr-he-common/vm/misc.py
A src/plugins/gr-he-rollbackupgrade/Makefile.am
A src/plugins/gr-he-rollbackupgrade/core/Makefile.am
A src/plugins/gr-he-rollbackupgrade/core/__init__.py
A src/plugins/gr-he-rollbackupgrade/core/misc.py
M src/plugins/gr-he-upgradeappliance/core/misc.py
M src/plugins/gr-he-upgradeappliance/engine/Makefile.am
M src/plugins/gr-he-upgradeappliance/engine/__init__.py
D src/plugins/gr-he-upgradeappliance/engine/add_vm_disk.py
A src/plugins/gr-he-upgradeappliance/engine/misc.py
M src/plugins/gr-he-upgradeappliance/vm/configurevm.py
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
29 files changed, 1,328 insertions(+), 531 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I409d9143642601b28f54109864fe4b298be9ca38
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: rename VmInternalData
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: rename VmInternalData
......................................................................
core: rename VmInternalData
VmInternalData -> VdsmVm
Change-Id: I7a41ac5ecc642dc9dc2072ff09c5491423925d57
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VdsmVm.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java
15 files changed, 109 insertions(+), 109 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a41ac5ecc642dc9dc2072ff09c5491423925d57
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: Revert "packaging: Add Hosted Engine VM detection"
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Revert "packaging: Add Hosted Engine VM detection"
......................................................................
Revert "packaging: Add Hosted Engine VM detection"
This reverts commit 99f0d1d39ee8709f8b77a36fcf36e1a9be40eaba.
The patch is failing on non-hosted engine systems.
Change-Id: Ibb8431f617726dab0c201b4e3c5ef5777419575b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py
D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py
3 files changed, 0 insertions(+), 122 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60268
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb8431f617726dab0c201b4e3c5ef5777419575b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: refactor VmInternalData
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: refactor VmInternalData
......................................................................
core: refactor VmInternalData
Replace all constructors with one constructor that receives the notification
time. All other arguments should be set with setter methods. This simplifies
the instanciation of this class.
In addition, statically import the methods in VdsBrokerObjectsBuilder that
are used in VmStatsVdsBrokerCommand and in ListVDSCommand in order to make
it more readable.
Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java
5 files changed, 49 insertions(+), 51 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iceeacc97412fdba7bb54d1d1c4139d800a45528a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-ha[master]: Fix size calculation when zeroing VDSM volumes
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Fix size calculation when zeroing VDSM volumes
......................................................................
Fix size calculation when zeroing VDSM volumes
Instead of os.stat().st_size, which works only on regular files,
open the file and seek to the end.
Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995
Bug-Url: https://bugzilla.redhat.com/1346341
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/storage_backends.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/59241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfba9c165983e6b36dacdff844960827bbe57995
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: packaging: setup: Add Cockpit to firewall
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Add Cockpit to firewall
......................................................................
packaging: setup: Add Cockpit to firewall
Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098
Bug-Url: https://bugzilla.redhat.com/1335426
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 2ade86b901a4a3b7a3d0b8db3570b33ed79c976e)
---
M src/plugins/gr-he-setup/network/firewall.py
M templates/Makefile.am
A templates/hosted-cockpit.xml.in
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/60263
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2795e821e761cbb5511b18e86410090fea7dc098
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months