Change in ovirt-dwh[master]: packaging: setup: Do not write db password to answerfile if ...
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: Do not write db password to answerfile if provisioning
......................................................................
packaging: setup: Do not write db password to answerfile if provisioning
Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555
Bug-Url: https://bugzilla.redhat.com/1332892
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/dwh/constants.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: extract EntityDao out of DbFacade
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: extract EntityDao out of DbFacade
......................................................................
core: extract EntityDao out of DbFacade
Change-Id: I40356cab8da9ea54b903e6b1e0df9314299d1b6c
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EntityDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EntityDaoImpl.java
D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeDaoTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EntityDaoImplTest.java
M backend/manager/modules/dal/src/test/resources/test-beans.xml
8 files changed, 298 insertions(+), 226 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/59687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40356cab8da9ea54b903e6b1e0df9314299d1b6c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: exctact OsInfoDao out of DbFacade
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: exctact OsInfoDao out of DbFacade
......................................................................
core: exctact OsInfoDao out of DbFacade
Exctact OsInfoDao out of DbFacade and add a test for that.
Change-Id: Id05345deeeea1159f77ecb936dbc1a37bf18d448
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSource.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/OsInfoDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/OsInfoDaoImpl.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/dwh/OsInfoDaoImplTest.java
M backend/manager/modules/dal/src/test/resources/test-beans.xml
7 files changed, 171 insertions(+), 30 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/59686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id05345deeeea1159f77ecb936dbc1a37bf18d448
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: webadmin: Warn for running VMs when cluster level change
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: Warn for running VMs when cluster level change
......................................................................
webadmin: Warn for running VMs when cluster level change
When changing cluster level of a cluster with running VMs,
a warning is shown stating requirement to reboot all these VMs once
the cluster level is changed.
All running/paused non-[Hosted Engine|External] VMs are marked with
the NextRun configuration mark to denote the requirement.
The HE VM is handled in other path.
Prior this fix, the cluster level change was not allowed
when there were running VMs.
This fix solves issue with hosted engine VM running at the time of
cluster level change.
Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2
Bug-Url: https://bugzilla.redhat.com/1348907
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
14 files changed, 54 insertions(+), 50 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: remove redundant fields from DbFacade
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: remove redundant fields from DbFacade
......................................................................
core: remove redundant fields from DbFacade
The removed fields are:
* dbFacadeLocator
* onStartConnectionTimeout
* connectionCheckInterval
Change-Id: I470b33a6d9a19144977eed5b3bb154569be7a124
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/test/resources/test-beans.xml
2 files changed, 2 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/59524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I470b33a6d9a19144977eed5b3bb154569be7a124
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: core: If command is created to compensate existing business_...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: If command is created to compensate existing business_entity_snapshot records, it should be created with compensation enabled.
......................................................................
core: If command is created to compensate existing
business_entity_snapshot records, it should be created with
compensation enabled.
It does not make sense trying to compensate without compensation
enabled.
Change-Id: Ic06ae5ff9b6d1e6e25f78b8f28a228dc7210b6a1
Bug-Url: https://bugzilla.redhat.com/1350399
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59530
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06ae5ff9b6d1e6e25f78b8f28a228dc7210b6a1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in jenkins[master]: fixing email address
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fixing email address
......................................................................
fixing email address
Change-Id: If8461280bfb65f5c69ef3c99f5908a2fba69c580
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/60115
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8461280bfb65f5c69ef3c99f5908a2fba69c580
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-release[master]: Adds missing jackson-core dependency for hystrix RPMs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Adds missing jackson-core dependency for hystrix RPMs
......................................................................
Adds missing jackson-core dependency for hystrix RPMs
Adds jackson-core to enabled EPEL packages, becuase it's required by
hystrix-metrics-event-stream. This is needed only because of RPM
dependency, because during runtime hystrix will use jackson-core
provided by WildFly.
Change-Id: Iac1e24b97ff68fa90c46be28d0474fd713d64b3a
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M ovirt-el7-deps.repo.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eyal Edri: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac1e24b97ff68fa90c46be28d0474fd713d64b3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
7 years, 9 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Require spec_helper from .rspec
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Require spec_helper from .rspec
......................................................................
Require spec_helper from .rspec
This patch moves the requirement of the spec helper from the Ruby source
files to the ".rspec" file.
Change-Id: Idb6f02d65844dce49c7c3a1a5e93eff6f61d5041
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 404d9cf8c9c8e6a62a637350eb19052cff36be63)
---
A sdk/.rspec
M sdk/spec/action_reader_spec.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/connection_create_spec.rb
M sdk/spec/connection_timeout_spec.rb
M sdk/spec/connection_use_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/enum_spec.rb
M sdk/spec/fault_reader_spec.rb
M sdk/spec/reader_spec.rb
M sdk/spec/service_spec.rb
M sdk/spec/spec_helper.rb
M sdk/spec/storage_domain_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/vm_reader_spec.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vm_spec.rb
M sdk/spec/vm_writer_spec.rb
M sdk/spec/vms_service_spec.rb
M sdk/spec/writer_spec.rb
M sdk/spec/xml_reader_spec.rb
M sdk/spec/xml_writer_spec.rb
22 files changed, 12 insertions(+), 50 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb6f02d65844dce49c7c3a1a5e93eff6f61d5041
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
7 years, 9 months
Change in ovirt-engine-sdk-ruby[master]: Require spec_helper from .rspec
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Require spec_helper from .rspec
......................................................................
Require spec_helper from .rspec
This patch moves the requirement of the spec helper from the Ruby source
files to the ".rspec" file.
Change-Id: Idb6f02d65844dce49c7c3a1a5e93eff6f61d5041
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/.rspec
M sdk/spec/action_reader_spec.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/connection_create_spec.rb
M sdk/spec/connection_timeout_spec.rb
M sdk/spec/connection_use_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/enum_spec.rb
M sdk/spec/fault_reader_spec.rb
M sdk/spec/reader_spec.rb
M sdk/spec/service_spec.rb
M sdk/spec/spec_helper.rb
M sdk/spec/storage_domain_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/vm_reader_spec.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vm_spec.rb
M sdk/spec/vm_writer_spec.rb
M sdk/spec/vms_service_spec.rb
M sdk/spec/writer_spec.rb
M sdk/spec/xml_reader_spec.rb
M sdk/spec/xml_writer_spec.rb
22 files changed, 12 insertions(+), 50 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb6f02d65844dce49c7c3a1a5e93eff6f61d5041
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
7 years, 9 months