Change in ovirt-engine[master]: sso: text fixes in login page, remove placeholder
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: sso: text fixes in login page, remove placeholder
......................................................................
sso: text fixes in login page, remove placeholder
PatternFly specifies:
* no placeholders in username and password fields
* label of username field is "Username" (not "User Name")
* page title should be "Log In" (not "Login")
* Log-In button should be "Log In" (not "Login")
* Log-In button should be large size
Fixed the above.
Change-Id: I337f10183d2d49c8012c0aa6b6c17cee9dd65314
Bug-Url: https://bugzilla.redhat.com/1347109
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/resources/messages.properties
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
2 files changed, 9 insertions(+), 11 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/61564
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337f10183d2d49c8012c0aa6b6c17cee9dd65314
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: Make sure used is always <= total
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Make sure used is always <= total
......................................................................
webadmin: Make sure used is always <= total
- In certain situations it is possible that the DWH is
reporting used > 0 while total = 0. This patch makes
sure that used can never be higher than total.
Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360403
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationResourceSummary.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61577
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0.2]: core: protection from NPE in the initialization of RunVm
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: protection from NPE in the initialization of RunVm
......................................................................
core: protection from NPE in the initialization of RunVm
Need to verify that the VM to run exists before accessing it.
Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b
Bug-Url: https://bugzilla.redhat.com/1360265
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/61484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0.2]: engine: fix background image on welcome and login pages
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: fix background image on welcome and login pages
......................................................................
engine: fix background image on welcome and login pages
Apply the background image technique used in patternfly's login
page pattern to the welcome and login pages. This change will
prevent the background image from being truncated if the welcome
or login page is made short enough to scroll.
Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Bug-Url: https://bugzilla.redhat.com/1347807
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M packaging/branding/ovirt.brand/common.css
9 files changed, 339 insertions(+), 355 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/61423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: fix background image on welcome and login pages
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: fix background image on welcome and login pages
......................................................................
engine: fix background image on welcome and login pages
Apply the background image technique used in patternfly's login
page pattern to the welcome and login pages. This change will
prevent the background image from being truncated if the welcome
or login page is made short enough to scroll.
Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Bug-Url: https://bugzilla.redhat.com/1347807
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M packaging/branding/ovirt.brand/common.css
9 files changed, 339 insertions(+), 355 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/61422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e9af3e9ad1c7411b373d5d61cd76c83efa2df4e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Improve affinity label resources
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: restapi: Improve affinity label resources
......................................................................
restapi: Improve affinity label resources
Currently the resources that manage the virtual machines and hosts that
are part of an affinity label are implemented using abstract generic
base classes. This doesn't work correctly with some versions of
Resteasy, as generic methods aren't recognized as implementations of the
methods annotated with @GET. In addition the methods to add virtual
machines and hosts aren't implemented correctly, as they return "action"
instead of the expected "vm" or "host" elements.
To address these issues this patch removes the abstract generic base
classes, and moves the reusable code to a new helper class.
The methods that add virtual machines and hosts are modified so that
they return "vm" or "host", as expected.
Change-Id: I274750970f283bb9ce813f301a28a5cbc544eb60
Bug-Url: https://bugzilla.redhat.com/1350228
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit d9981535b8e4ee9b7e0f4850805fd7aa5eaa65ee)
---
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAffinityLabelledEntitiesResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAffinityLabelledEntityResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelHostsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/AffinityLabelMapper.java
9 files changed, 248 insertions(+), 199 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I274750970f283bb9ce813f301a28a5cbc544eb60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Make sure used is always <= total
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Make sure used is always <= total
......................................................................
webadmin: Make sure used is always <= total
- In certain situations it is possible that the DWH is
reporting used > 0 while total = 0. This patch makes
sure that used can never be higher than total.
Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360403
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationResourceSummary.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in jenkins[master]: increasing history of builds for ovirt-engine-upgrade jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: increasing history of builds for ovirt-engine-upgrade jobs
......................................................................
increasing history of builds for ovirt-engine-upgrade jobs
It was set to 40 and its not enough if an error
happend a week ago, so increasing to 120 to
match the standard CI history
Change-Id: I6c21616d60809f77d7a3e5a164c68ff2ad743e4a
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/engine-upgrade.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61556
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c21616d60809f77d7a3e5a164c68ff2ad743e4a
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Revert "ui: Hide registration if HE was run"
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: Revert "ui: Hide registration if HE was run"
......................................................................
Revert "ui: Hide registration if HE was run"
This reverts commit 610dda4b692ad3565121c85e1341e805aa086d25.
Change-Id: Ia07be116eafe34c1962e7d43b6f4786384f70c16
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55995
Continuous-Integration: Jenkins CI
Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com>
---
M src/engine_page.py
1 file changed, 0 insertions(+), 42 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified
Fabian Deutsch: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia07be116eafe34c1962e7d43b6f4786384f70c16
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.1.3
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-setup-2.0.1.3
......................................................................
build: ovirt-hosted-engine-setup-2.0.1.3
Change-Id: Id579a3fe6ed6f7b3e4f1d9d3900e25c73338d35a
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M configure.ac
M ovirt-hosted-engine-setup.spec.in
3 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id579a3fe6ed6f7b3e4f1d9d3900e25c73338d35a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
7 years, 9 months