Change in ovirt-engine[master]: gluster: add a dir under brick mount in replace brick
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: add a dir under brick mount in replace brick
......................................................................
gluster: add a dir under brick mount in replace brick
Mount directory should not be used as a brick directory.
We should add a directory under brick mount point and use that
as brick dir.
Change-Id: Ib25608504e8b0a161fcc64140c7db08277d49b22
Bug-Url: https://bugzilla.redhat.com/1369357
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/ReplaceBrickModel.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/62741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25608504e8b0a161fcc64140c7db08277d49b22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in otopi[master]: testing: added coverage reports
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: testing: added coverage reports
......................................................................
testing: added coverage reports
Added coverage support to otopi.
See README.environment for info on enabling coverage feature.
See automation/check-patch.sh on how to use it.
Added libselinux-python to the test environment avoiding the
re-execution of otopi, avoiding to mess with the coverage testing.
Change-Id: I2e7f3411da15575c08c99605fea74d1fb7879b0f
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M README.environment
M automation/check-merged.packages
M automation/check-merged.sh
M automation/check-patch.packages
M automation/check-patch.sh
A automation/coverage.rc
A automation/index.html
M src/otopi/constants.py
M src/otopi/main.py
9 files changed, 55 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Petr Balogh: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7f3411da15575c08c99605fea74d1fb7879b0f
Gerrit-PatchSet: 6
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: core: Only internal commands can manipulate read-only labels
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Only internal commands can manipulate read-only labels
......................................................................
core: Only internal commands can manipulate read-only labels
Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86
Bug-Url: https://bugzilla.redhat.com/1346250
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
(cherry picked from commit 99537632047b9ba9c9dfe52ee4247c17d9aa7931)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddLabelCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveLabelCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateLabelCommand.java
3 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/62725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Use matchers in StorageDomainValidatorTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use matchers in StorageDomainValidatorTest
......................................................................
core: Use matchers in StorageDomainValidatorTest
Use assertThat with ValidationResult matchers in
StorageDomainValidatorTest in order to adhere to the project standards
Change-Id: Ic34329f324f5867b703fa0f3b578ebc14655444e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic34329f324f5867b703fa0f3b578ebc14655444e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Add tests to StorageDomainValidator::isDataDomain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add tests to StorageDomainValidator::isDataDomain
......................................................................
core: Add tests to StorageDomainValidator::isDataDomain
Change-Id: I939e372b5b23469a998fa3e4b3dde7e71e4b3601
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I939e372b5b23469a998fa3e4b3dde7e71e4b3601
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Remove unused JsonRpcUtils#createClient
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused JsonRpcUtils#createClient
......................................................................
core: Remove unused JsonRpcUtils#createClient
Change-Id: Ifacff92823e2b8c01f7ae65cbdf643782c9cfaf2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifacff92823e2b8c01f7ae65cbdf643782c9cfaf2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: GlusterVolumeGeoRepConfigListXmlRpc#setSessionConfig
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GlusterVolumeGeoRepConfigListXmlRpc#setSessionConfig
......................................................................
core: GlusterVolumeGeoRepConfigListXmlRpc#setSessionConfig
Remove unused method.
Change-Id: Ic9aa8d1e020418f1bd91d5e0ed7d44f62c872394
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepConfigListXmlRpc.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9aa8d1e020418f1bd91d5e0ed7d44f62c872394
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: VmInfoBuilderImpl getOrDefault
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmInfoBuilderImpl getOrDefault
......................................................................
core: VmInfoBuilderImpl getOrDefault
Use getOrDefault instead of a hard-to-read ternary operator.
Change-Id: I9377eedf9dd72b0f4c20ed721fb0e0b904017aaf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9377eedf9dd72b0f4c20ed721fb0e0b904017aaf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: CreateGlusterVolumeSnapshotVDSCommand ternary
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CreateGlusterVolumeSnapshotVDSCommand ternary
......................................................................
core: CreateGlusterVolumeSnapshotVDSCommand ternary
Use Objects.toString(Object, String) instead of an unreadable ternary
expression.
Change-Id: I6b889262f60ed11be4d8b70a188dbd341193d3d4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b889262f60ed11be4d8b70a188dbd341193d3d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: vdsbroker: Clean up type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: vdsbroker: Clean up type inference
......................................................................
core: vdsbroker: Clean up type inference
Removed redundant type arguments where they could be inferred throughout
the vdsbroker package.
Change-Id: Iaed648bcf979d682389a4df9245bd79603aaa37a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ReconstructMasterVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
13 files changed, 41 insertions(+), 46 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62695
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaed648bcf979d682389a4df9245bd79603aaa37a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month