Change in ovirt-engine[master]: engine: Add a replaceWith method for custom seperator
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add a replaceWith method for custom seperator
......................................................................
engine: Add a replaceWith method for custom seperator
To be used when there is a need for a custom seperator but still keep the
default printed items.
Bug-Url: https://bugzilla.redhat.com/1294354
Change-Id: I8d9082ed5d48871cbb3e0f3b857f53986bc3c993
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java
2 files changed, 32 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/62390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d9082ed5d48871cbb3e0f3b857f53986bc3c993
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: restapi: Update to model 4.1.9
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.9
......................................................................
restapi: Update to model 4.1.9
The more relevant changes included in the new version of the model are
the following:
* Add the `clone_permissions` parameter to the operations that add
virtual machines and templates.
* Add the `clone` parameter to the operation that adds a new virtual
machine.
* Add the `ad_partner_mac` attribute to the bonding type.
* Add the `ad_aggregator_id` attribute to the host NIC type.
* Add the `upgradecheck` action to the host service.
* Add the `ExternalVmImportsService` and related types.
* Add the `active` property back to the disk type.
Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M pom.xml
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62497
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Only internal commands can manipulate read-only labels
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Only internal commands can manipulate read-only labels
......................................................................
core: Only internal commands can manipulate read-only labels
Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86
Bug-Url: https://bugzilla.redhat.com/1346250
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddLabelCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveLabelCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateLabelCommand.java
3 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
Yanir Quinn: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Cluster update updates VMs only if necessary
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Cluster update updates VMs only if necessary
......................................................................
core: Cluster update updates VMs only if necessary
i.e. if cluster compatibility version has changed.
This patch is supposed to decrease of probability of DB deadlocks caused
by concurrent updates of VM devices by limiting calls of
UpdateVmCommand.
This is a lightweight backport of https://gerrit.ovirt.org/#/c/60995
intended to be 3.6 only.
Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced
Bug-Url: https://bugzilla.redhat.com/1349526
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0.2]: packaging: setup: Enroll missing pki on upgrade
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: Enroll missing pki on upgrade
......................................................................
packaging: setup: Enroll missing pki on upgrade
Without this patch, imageio-proxy pki will not be generated on upgrade
from 3.6, because it did not exist then.
Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8
Bug-Url: https://bugzilla.redhat.com/1365451
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 8ba1dfc0f249b6c53b0920fbd65aa5f4af8764ea)
(cherry picked from commit a093bc82998fde17bb0ef8547c19861378275af3)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0.2]: packaging: spec: Require ovirt-imageio-proxy-setup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: Require ovirt-imageio-proxy-setup
......................................................................
packaging: spec: Require ovirt-imageio-proxy-setup
Make the engine plugin of engine-setup require
ovirt-imageio-proxy-setup.
Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Bug-Url: https://bugzilla.redhat.com/1365744
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit dcb12b888d6f35258883e540c68a09974d1c03c5)
(cherry picked from commit 87360124530710ee9d117425a90847c0f54c79d0)
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.2
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Kerberos negotiation for RESTAPI should be enabled by d...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
......................................................................
aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
The restapi negotiate should be enabled by
default, ENGINE_RESTAPI_NEGO=true. This
maintains compatibilty with v3 restapi
clients.
Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Bug-Url: https://bugzilla.redhat.com/1367513
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Ravi Nori: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: aaa: Kerberos negotiation for RESTAPI should be enabled by d...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
......................................................................
aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
The restapi negotiate should be enabled by
default, ENGINE_RESTAPI_NEGO=true. This
maintains compatibilty with v3 restapi
clients.
Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Bug-Url: https://bugzilla.redhat.com/1367513
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in jenkins[master]: Add experimental repo to repo closure script and jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Add experimental repo to repo closure script and jobs
......................................................................
Add experimental repo to repo closure script and jobs
Change-Id: Id719efb9fa229b4f51944655c6c795fd3a90cd34
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/shell-scripts/repos-check-closure_run-check.sh
M jobs/confs/yaml/templates/repos-check-closure.yaml
M jobs/packaging/repo_closure_check.sh
3 files changed, 26 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for review
Sharon Naftaly: Verified
Eyal Edri: Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id719efb9fa229b4f51944655c6c795fd3a90cd34
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in jenkins[master]: Yamlized repo closure jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Yamlized repo closure jobs
......................................................................
Yamlized repo closure jobs
Change-Id: Ib16c44e56b8bfe507203a729e33ab9023a3f6f8a
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
A jobs/confs/groovy-scripts/repos-check-closure_post-build.groovy
A jobs/confs/projects/repos-check-closure/repos-check-closure.yaml
A jobs/confs/shell-scripts/repos-check-closure_apply-cherry-pick.sh
A jobs/confs/shell-scripts/repos-check-closure_run-check.sh
A jobs/confs/yaml/templates/repos-check-closure.yaml
5 files changed, 114 insertions(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16c44e56b8bfe507203a729e33ab9023a3f6f8a
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month