August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: enlarge the create snapshot message dialog
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: enlarge the create snapshot message dialog ...................................................................... webadmin: enlarge the create snapshot message dialog Enlarge the size of the message Panel inside the snapshot creation dialog in order to avoid message truncation. Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Bug-Url: https://bugzilla.redhat.com/1360914 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/uicompat/exclude-filters.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Set default switchType if none is received from vdsm
by mperina＠redhat.com 16 Aug '16

16 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: engine: Set default switchType if none is received from vdsm ...................................................................... engine: Set default switchType if none is received from vdsm 3.6 vdsms do not report a switch type. This must be set to legacy, otherwise the network will be reported as out of sync. Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Bug-Url: https://bugzilla.redhat.com/1367483 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Wrong error message passed from SSO on password grant t...
by mperina＠redhat.com 16 Aug '16

16 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Wrong error message passed from SSO on password grant type failure ...................................................................... aaa: Wrong error message passed from SSO on password grant type failure Authentication failure in obtaining token from SSO using password grant type should return correct error message. Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Bug-Url: https://bugzilla.redhat.com/1366927 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Aleksei Slaikovskii: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: gluster: fix tool tip issue in VolumeStatusCell
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix tool tip issue in VolumeStatusCell ...................................................................... gluster: fix tool tip issue in VolumeStatusCell BrowserEvents are not propagated to base class AbstractCell from VolumeStatusCell. As a result tooltip was not getting displayed. Fixing by calling super class onBrowserEvent always Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Bug-Url: https://bugzilla.redhat.com/1365604 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> (cherry picked from commit c0913aa5de82b34b54939e4350d9ad9cb1f0112a) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeStatusCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Alexander Wels: Looks good to me, approved Ramesh N: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update capabilities for V3
by juan.hernandez＠redhat.com 16 Aug '16

16 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update capabilities for V3 ...................................................................... restapi: Update capabilities for V3 The "capabilities" provided by version 4 of the engine for version 3 of the API aren't generated directly, instead they are stored in a "capabilities.xml" file that is extracted from version 3 of the engine. This file needs to be updated when there are relevant changes in version 3 of the engine. This patch updates it, using version 3.6.7.5 of the engine. Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/resources/v3/capabilities.xml 1 file changed, 38 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: gluster: fix enumtranslater issue in SizeConverter
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix enumtranslater issue in SizeConverter ...................................................................... gluster: fix enumtranslater issue in SizeConverter LocalizedEnums are not defined correctly for SizeConverter.SizeUnit. As a result enum translation was not working correctly. Correcting the definitions in LocalizedEnums. Note: since EnumTranslator gives the enum name when the localization key is missing, it is not visible in the UI. Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da Bug-Url: https://bugzilla.redhat.com/1358837 Bug-Url: https://bugzilla.redhat.com/1269132 Bug-Url: https://bugzilla.redhat.com/1353289 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 18 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/62349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: fix tool tip issue in VolumeStatusCell
by awels＠redhat.com 16 Aug '16

16 Aug '16

Alexander Wels has submitted this change and it was merged. Change subject: gluster: fix tool tip issue in VolumeStatusCell ...................................................................... gluster: fix tool tip issue in VolumeStatusCell BrowserEvents are not propagated to base class AbstractCell from VolumeStatusCell. As a result tooltip was not getting displayed. Fixing by calling super class onBrowserEvent always Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Bug-Url: https://bugzilla.redhat.com/1365604 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeStatusCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/62277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - set correct status on failure
by laravot＠redhat.com 16 Aug '16

16 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - set correct status on failure ...................................................................... core: CommandBase - set correct status on failure When failing in executing command, the command status should be set to ENDED_WITH_FAILURE if the command isn't managed (by ATM or by CoCo) and EXECUTION_FAILED if it does (as it'll reach an end status by ATM/CoCo). Change-Id: I1a8899bec0b33e56a738368c98518840c3161a6e Bug-Url: https://bugzilla.redhat.com/1367438 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a8899bec0b33e56a738368c98518840c3161a6e Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Enroll missing pki on upgrade
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Enroll missing pki on upgrade ...................................................................... packaging: setup: Enroll missing pki on upgrade Without this patch, imageio-proxy pki will not be generated on upgrade from 3.6, because it did not exist then. Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8 Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 8ba1dfc0f249b6c53b0920fbd65aa5f4af8764ea) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Kernel cmdline 'on' -> '1'
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Kernel cmdline 'on' -> '1' ...................................................................... core: Kernel cmdline 'on' -> '1' Enabled kernel command line option is indicated by '1' instead of 'on' for 'kvm-(intel|amd).nested' and 'vfio_iommu_type1.allow_unsafe_interrupts' option since RHEL supports both ('1', 'on') whereas CentOS only '1'. This CentOS problem doesn't apply to '(amd|intel)_iommu' option thus it is left with more standard 'on'. Change-Id: I2c0a19fb8906c588120abc5c398e1b1b9ac8f57d Bug-Url: https://bugzilla.redhat.com/1360397 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/KernelCmdlineUtil.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Martin Polednik: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c0a19fb8906c588120abc5c398e1b1b9ac8f57d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0