Change in ovirt-engine-sdk[master]: Empty list is not written to XML
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Empty list is not written to XML
......................................................................
Empty list is not written to XML
When the user wants to send an empty list to the server, it is not
currently possible. For example when the user wants to create non VM
network he has to send an empty usages element. But if he sets the
"Network.usages" attribute to empty list, the empty usages element isn't
sent.
This patch fixes that.
Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
A sdk/tests/test_network_writer.py
2 files changed, 127 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66bc71cf5c4757fff57b3143218488315dc218b8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Empty list is not written to XML
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Empty list is not written to XML
......................................................................
Empty list is not written to XML
When the user wants to send an empty list to the server, it is not
currently possible. For example when the user wants to create non VM
network he has to send an empty usages element. But if he sets the
"Network.usages" attribute to empty list, the empty usages element isn't
sent.
This patch fixes that.
Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit a55cff7bac99e27e90d612c8ed6f266afcce9dd4)
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/spec/network_writer_spec.rb
2 files changed, 84 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Empty list is not written to XML
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Empty list is not written to XML
......................................................................
Empty list is not written to XML
When the user wants to send an empty list to the server, it is not
currently possible. For example when the user wants to create non VM
network he has to send an empty usages element. But if he sets the
"Network.usages" attribute to empty list, the empty usages element isn't
sent.
This patch fixes that.
Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/spec/network_writer_spec.rb
2 files changed, 84 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab4f0af3701b4b812800adc7cc527c4506b1a4ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Internal server error once automatically logged out
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Internal server error once automatically logged out
......................................................................
aaa: Internal server error once automatically logged out
Session expiration on webadmin or userportal
after redirecting to sso causes the session
attributes to be lost resulting in a NPE.
Passing app_url to sso and receiving it back
from sso instead of saving app_url in session
resolves the issue of session expiration.
Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712
Bug-Url: https://bugzilla.redhat.com/1376003
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit d64cb375f3c09827e39e3861401ba355e407280b)
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
7 files changed, 35 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64268
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix creation of template from VM with Cinder disks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix creation of template from VM with Cinder disks
......................................................................
core: Fix creation of template from VM with Cinder disks
Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a
Bug-Url: https://bugzilla.redhat.com/1378402
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64292
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix clone VM from snapshot with Cinder disks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix clone VM from snapshot with Cinder disks
......................................................................
core: Fix clone VM from snapshot with Cinder disks
Change-Id: Ib46e1bd24002e914b902c017c44ad8d8131d3b0c
Bug-Url: https://bugzilla.redhat.com/1377442
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib46e1bd24002e914b902c017c44ad8d8131d3b0c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Fix creation of template from VM with Cinder disks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix creation of template from VM with Cinder disks
......................................................................
core: Fix creation of template from VM with Cinder disks
Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a
Bug-Url: https://bugzilla.redhat.com/1378402
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8275dcbe4e3295fda4797870aaa7b455a87b0a1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Fix clone VM from snapshot with Cinder disks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix clone VM from snapshot with Cinder disks
......................................................................
core: Fix clone VM from snapshot with Cinder disks
Change-Id: Ib46e1bd24002e914b902c017c44ad8d8131d3b0c
Bug-Url: https://bugzilla.redhat.com/1377442
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib46e1bd24002e914b902c017c44ad8d8131d3b0c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[master]: Add example of add group from a directory service
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add example of add group from a directory service
......................................................................
Add example of add group from a directory service
This patch adds example of adding a group from a directory service.
Change-Id: I87b6decade678238c6b463fdbc911ce950df2dea
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddGroup.java
1 file changed, 61 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63778
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87b6decade678238c6b463fdbc911ce950df2dea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Add example of add group from a directory service
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add example of add group from a directory service
......................................................................
Add example of add group from a directory service
This patch adds example of adding a group from a directory service.
Change-Id: If80b5207dd23b3d06ca78b2f2d57f14fa9b02a48
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/examples/add_group.py
1 file changed, 54 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63777
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If80b5207dd23b3d06ca78b2f2d57f14fa9b02a48
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months