Change in ovirt-engine[master]: core: SnapshotVmConfigurationHelper injected
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: SnapshotVmConfigurationHelper injected
......................................................................
core: SnapshotVmConfigurationHelper injected
... instead of instantiation using `new`. The old approach caused NPE
inside SnapshotVmConfigurationHelper since its fields were not injected.
Change-Id: Ic104b94ddbfd43bfc7f587fc6d3c3dc536678e8a
Bug-Url: https://bugzilla.redhat.com/1377827
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmNextRunConfigurationQuery.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic104b94ddbfd43bfc7f587fc6d3c3dc536678e8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Copy test log files to the exported artifacts directory
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Copy test log files to the exported artifacts directory
......................................................................
Copy test log files to the exported artifacts directory
This patch changes the automation scripts so that the log files
generated by the tests are copied to the exported artifacts directory.
This way, if there are test failures, it will be easier to debug them.
Change-Id: I9e849b04836cb9bc324dec79d22fe7cd93ba74d4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M automation/build.py
M sdk/spec/spec_helper.rb
2 files changed, 13 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e849b04836cb9bc324dec79d22fe7cd93ba74d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: disable migration compression for default migration po...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: disable migration compression for default migration policy
......................................................................
core: disable migration compression for default migration policy
It may cause additional load on the host cpu we don't want to risk in default
policy.
Change-Id: I7776b31b31d41469f61f5357e67e34739d3336f3
Bug-Url: https://bugzilla.redhat.com/1374731
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7776b31b31d41469f61f5357e67e34739d3336f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: engine : Engine should not invoke revoke all on session expi...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine : Engine should not invoke revoke all on session expiration
......................................................................
engine : Engine should not invoke revoke all on session expiration
On session expiration SessionDataContainer
should not invoke revoke-all for the token.
If there are no other sessions for the token
SSO will cleanup the session on revoke.
Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d
Bug-Url: https://bugzilla.redhat.com/1377422
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit fe492153c06ba788c6ba6053275de394acd2fe37)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-host-deploy[master]: hosted-engine: set local maintenance to false when installin...
by stirabos@redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: hosted-engine: set local maintenance to false when installing host
......................................................................
hosted-engine: set local maintenance to false when installing host
When installing hosted engine host that was installed and then
removed from the engine its local maintenance would remain
set to true.
This patch sets the local maintenance to false when installing the
host.
Change-Id: I94edee9245728776af15099a3abd707bac19b11a
Bug-Url: https://bugzilla.redhat.com/1353600
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M src/plugins/ovirt-host-common/hosted-engine/configureha.py
1 file changed, 56 insertions(+), 1 deletion(-)
Approvals:
Simone Tiraboschi: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/64208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94edee9245728776af15099a3abd707bac19b11a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-release[master]: node: require ovirt-node-ng-nodectl
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: require ovirt-node-ng-nodectl
......................................................................
node: require ovirt-node-ng-nodectl
Nodectl provides an abstraction around imgbased functionality.
Require it in NGN
Change-Id: I1f5d89ca0c25eaa3719d984f8e103436f2336bdb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372719
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372717
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
---
M ovirt-release-master.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Ryan Barry: Verified
--
To view, visit https://gerrit.ovirt.org/63425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f5d89ca0c25eaa3719d984f8e103436f2336bdb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-host-deploy[master]: Revert "hosted-engine: set local maintenance to false when i...
by stirabos@redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: Revert "hosted-engine: set local maintenance to false when installing host"
......................................................................
Revert "hosted-engine: set local maintenance to false when installing host"
This reverts commit c283f5da53761eeb7a03229034b021ace2a2c702.
Change-Id: I263adb9922e9147eb5e7cc3da853a11de0d6299f
Bug-Url: https://bugzilla.redhat.com/1353600
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M src/plugins/ovirt-host-common/hosted-engine/configureha.py
1 file changed, 1 insertion(+), 20 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I263adb9922e9147eb5e7cc3da853a11de0d6299f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: adding debug message to DWH heart beat
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: adding debug message to DWH heart beat
......................................................................
core: adding debug message to DWH heart beat
Adding debug messages on DWH heart beat start/end in order to
investigate delays that occur sometimes when the result is that the
update of the corresponding field in DB not occurs in the configured
rate.
This will not solve the reported bug, rather it will give us information
which part cause the delay, the scheduling mechanism or the database.
Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373456
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fix backup log messages
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix backup log messages
......................................................................
core: fix backup log messages
Changing the message logged in case of backup from
"Started"/"Finished" to "Backup Started"/"Backup Finished"
Change-Id: I44bf5219c035a8e6b40fba2f8888bad5a48e9904
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372320
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64189
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44bf5219c035a8e6b40fba2f8888bad5a48e9904
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: sso: print only error message on login screen if fail
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: sso: print only error message on login screen if fail
......................................................................
aaa: sso: print only error message on login screen if fail
Before we printed full cause of the error to login screen, when login
failed. This error was unreadable to user, as user is interested only
to error message not full Java stack trace. This patch changes it, so
we now only show the error.
Change-Id: I45bfabbea16bac2e47506744d8e5c3429bbabe90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373092
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit fa6bd301ff12f3558550e17adcd7f97c907b32e0)
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45bfabbea16bac2e47506744d8e5c3429bbabe90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months