Change in ovirt-engine[ovirt-engine-4.0]: engine: Update hosts when gluster service enabled
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Update hosts when gluster service enabled
......................................................................
engine: Update hosts when gluster service enabled
When gluster service is enabled on cluster that
has existing hosts, the gluster properties
should be checked and updated.
Change-Id: I70fd4d43466aeb6712569f9e5180c11c8d113b00
Bug-Url: https://bugzilla.redhat.com/1313497
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 286 insertions(+), 225 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Moti Asayag: Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70fd4d43466aeb6712569f9e5180c11c8d113b00
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: engine: check gluster params while moving Host to maintenance
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: check gluster params while moving Host to maintenance
......................................................................
engine: check gluster params while moving Host to maintenance
Adding following checks before moving the host to Maintenance
1. Ensure gluster quorum can be met for all the volumes
in the gluster.
2. Ensure there are no unsynced entries present in
any gluster brick of the host moving to maintenance.
Non of the above checks will be performed incase of force
maintenance.
Change-Id: I4b53be0d35df0fa1087f056198872135f59bb49b
Bug-Url: https://bugzilla.redhat.com/1213291
Bug-Url: https://bugzilla.redhat.com/1196433
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 435 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/43773
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b53be0d35df0fa1087f056198872135f59bb49b
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: backend: Migrate TagsDirector to CDI
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: backend: Migrate TagsDirector to CDI
......................................................................
backend: Migrate TagsDirector to CDI
* Removed useless TagsHandler that just delegated to TagsDirector
* Instead, TagsDirector now implements ITagsHandler directly
* HandlersFactory is now also a CDI bean
Change-Id: I5267990e8756a3186340badb8917f5ffd73d5435
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllTagsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRootTagQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagByTagIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagByTagNameQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagsByTemplateIdQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandlersFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTagCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateTagCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java
14 files changed, 119 insertions(+), 90 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5267990e8756a3186340badb8917f5ffd73d5435
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: engine : serialization of command parameters allows serializ...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine : serialization of command parameters allows serialization of immutable objects
......................................................................
engine : serialization of command parameters allows serialization of immutable objects
Jackson serialization and deserialization should
handle unmodifiable and singleton collection
classes.
Change-Id: I6ab3651f0ef4c231cf17439d611f64eef90e2674
Bug-Url: https://bugzilla.redhat.com/1373242
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonCollectionIdResolver.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonCollectionMixIn.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonCustomTypeResolverBuilder.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonMapIdResolver.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonMapMixIn.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonImmutableSerializeDeserializeTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/TestCollectionsParams.java
9 files changed, 428 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab3651f0ef4c231cf17439d611f64eef90e2674
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: TestCommon: Remove System.out.println
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: TestCommon: Remove System.out.println
......................................................................
core: TestCommon: Remove System.out.println
Replace System.out.println with a proper logger, so the output can be
better controlled.
Change-Id: I141d89d89a93a87e74fac25e4756f270e1701dda
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I141d89d89a93a87e74fac25e4756f270e1701dda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: BasicTest: statically import assumeNotNull
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BasicTest: statically import assumeNotNull
......................................................................
core: BasicTest: statically import assumeNotNull
Statically import the method, as per the project's standards.
Change-Id: I360b59ed736ef1a0a81fbd5072c5ce7198b19d53
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I360b59ed736ef1a0a81fbd5072c5ce7198b19d53
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: TestCommon try-with-resource
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: TestCommon try-with-resource
......................................................................
core: TestCommon try-with-resource
Use Java 7's try-with-resource syntax to clean up the code and make it
more concise.
Change-Id: I3252f05f3c74644c6cef351deafb294eb277b28a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
2 files changed, 2 insertions(+), 22 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3252f05f3c74644c6cef351deafb294eb277b28a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: SSH test exceptions
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: SSH test exceptions
......................................................................
core: SSH test exceptions
A lot of the tests in the ssh package will catch any exception and
throw a RuntimeException, thus failing the test. A much cleaner
approach would be to just throw the original exception all the way
up. This way the test will still fail, but will at least provide some
useful information on why it failed.
Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
6 files changed, 23 insertions(+), 58 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: TestCommon @BeforeClass and @AfterClass
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: TestCommon @BeforeClass and @AfterClass
......................................................................
core: TestCommon @BeforeClass and @AfterClass
All the tests in the this suite start with calling
TestCommon.initialize() and they all end with calling
TestCommon.terminate().
Instead of repeating these calls, a much cleaner approach would be to
simply annotate them as such, have all the tests extend TestCommon, and
allow JUnit to do all the heavy lifting.
Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
5 files changed, 8 insertions(+), 44 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: TestCommon#main
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: TestCommon#main
......................................................................
core: TestCommon#main
Remove TestCommon's main function - we have a perfectly good Maven
environment set up to run JUnit tests. There's no reason to maintain a
competing main too.
Change-Id: I75c9279a3afd58349371284c0c546061efca6f06
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
1 file changed, 0 insertions(+), 38 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64106
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75c9279a3afd58349371284c0c546061efca6f06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months