September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: spec: Allow upgrade directly from 3.6
by Shirly Radco 13 Sep '16

13 Sep '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: Allow upgrade directly from 3.6 ...................................................................... packaging: spec: Allow upgrade directly from 3.6 Change-Id: I562e44067a6c094a426683fe5d1e13db11e7ab54 Bug-Url: https://bugzilla.redhat.com/1366900 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I562e44067a6c094a426683fe5d1e13db11e7ab54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Update to model 4.1.12 and metamodel 1.1.3
by omachace＠redhat.com 13 Sep '16

13 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.12 and metamodel 1.1.3 ...................................................................... Update to model 4.1.12 and metamodel 1.1.3 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. * Add services to support disk attachments of virtual machines available for import from storage domains. The more relevant changes included in the new version of the metamodel are the following: * Add `finalize` to the list of Java reserved words. Change-Id: Iaf06737fe9a85a4022c03cb1e8ea64f443bbd14f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf06737fe9a85a4022c03cb1e8ea64f443bbd14f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add disk attachments collection to a VM in export d...
by tnisan＠redhat.com 13 Sep '16

13 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add disk attachments collection to a VM in export domain ...................................................................... restapi: Add disk attachments collection to a VM in export domain Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473 Bug-Url: https://bugzilla.redhat.com/1371024 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java 3 files changed, 75 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.9]: packaging: setup: Move hosted-engine check plugin to engine
by tnisan＠redhat.com 13 Sep '16

13 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Move hosted-engine check plugin to engine ...................................................................... packaging: setup: Move hosted-engine check plugin to engine Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Bug-Url: https://bugzilla.redhat.com/1375161 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/he.py 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.9 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: Move hosted-engine check plugin to engine
by tnisan＠redhat.com 13 Sep '16

13 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Move hosted-engine check plugin to engine ...................................................................... packaging: setup: Move hosted-engine check plugin to engine Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Bug-Url: https://bugzilla.redhat.com/1375161 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/he.py 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range
by tnisan＠redhat.com 13 Sep '16

13 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range ...................................................................... restapi: Validate 'nfs_timeo' and 'nfs_retrans' range Current the 'nfs_timeo' and 'nfs_retrans' values used when adding NFS storage aren't validated, their values are just truncated and passed to the backend. That is wrong. As the backend receives a 'short' and the API uses an 'integer' it isn't possible to do the validation in the backend, thus it needs to be done in the API. This patch changes the API so that it performs explicitly this check before trying to do anything with the storage. If the check fails, for example if the value of 'nfs_timeo' is 131077, the operation will fail with error code 400 (Bad Request) and the following response body will be returned: <fault> <reason>Value out of range</reason> <detail>The value 131077 of attribute 'nfs_timeio' is outside of range 0 to 65535.</detail> </fault> Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Bug-Url: https://bugzilla.redhat.com/1373581 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit df3dc73d94ef4020c32c1449b5619a09ccf431d5) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 4 files changed, 28 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Validate images existance for unregistered Template.
by mlipchuk＠redhat.com 13 Sep '16

13 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate images existance for unregistered Template. ...................................................................... core: Validate images existance for unregistered Template. Once an unregister Template entity is being registered to the engine, the engine should verify all its disks existance in the Storage. The reason the engine should perform this validation is since the Template's OVF might not be synced with the disks in the Storage. If one of the disks doesn't exists, the engine should block the operation. This behavior should be compatible with the behavior being performed today once a Template is being imported from an export domain. Change-Id: I3b890bd831c34770d6fd43416d5b15888b45f85b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1367488 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromConfigurationCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b890bd831c34770d6fd43416d5b15888b45f85b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Require WildFly 10.1.0
by sbonazzo＠redhat.com 13 Sep '16

13 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Require WildFly 10.1.0 ...................................................................... core: Require WildFly 10.1.0 Adds requirement on WildFly 10.1.0 Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Bug-Url: https://bugzilla.redhat.com/1368985 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add example of changing VM CD
by omachace＠redhat.com 12 Sep '16

12 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of changing VM CD ...................................................................... Add example of changing VM CD This patch adds example of changing VM CD. Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 5fc83c983d0949b45074e46475a6afc3726835b8) --- A sdk/examples/change_vm_cd.py 1 file changed, 75 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: avoid using interface cfg entries
by stirabos＠redhat.com 12 Sep '16

12 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: network: avoid using interface cfg entries ...................................................................... network: avoid using interface cfg entries Since patch https://gerrit.ovirt.org/#/c/58226 , vdsm doesn't provide anymore the cfg in netinfo entries. Avoid using it. Change-Id: I63017df607b017844d45bea0649667a8e9adf90b Depends-On: https://gerrit.ovirt.org/#/c/58226 Depends-On: https://gerrit.ovirt.org/#/c/58351 Bug-Url: https://bugzilla.redhat.com/1313881 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/gr-he-common/network/bridge.py M src/plugins/gr-he-setup/engine/add_host.py 3 files changed, 27 insertions(+), 79 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63017df607b017844d45bea0649667a8e9adf90b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0